mbox series

[v2,0/3] ASoC: codec: wcd93xx: Convert to GPIO descriptors

Message ID 20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com
Headers show
Series ASoC: codec: wcd93xx: Convert to GPIO descriptors | expand

Message

Peng Fan March 24, 2025, 11:51 a.m. UTC 
Steev,
 I would appreciate if you have time to help test again.
 Hope V2 could work on your platform.

Linus,
 Since v2 is only a minor change to use GPIOD_OUT_LOW to replace
 GPIOD_ASIS when devm_gpio_get, so I still keep you R-b. Appreciate
 for your quick action.

Johan,
 Thanks for help look into V1. Appreciate if you have time to look
 into v2.

Sorry for this quick V2, there is no rush, but just wanna to avoid sending
this out in coming merge window.

of_gpio.h is deprecated, so update driver to use gpiod API.

The current driver use value 0 to assert reset and 1 to deassert reset.
The DTSes in tree that use the codec are using GPIO_ACTIVE_LOW.
So it is safe to use devm_gpiod_get to get GPIO descriptors and
use gpiod_set_value to configure output with value 1 means raw value
0, value 0 means raw value 1.

Note:
I not have devices to test, just my best pratice to do the convertion.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Changes in v2:
- Use GPIOD_OUT_LOW to replace GPIOD_ASIS to configure direction.
- Update commit log with "in-tree DTS files have the right polarity set up
  already so we can expect this to "just work"".
- Link to v1: https://lore.kernel.org/r/20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com

---
Peng Fan (3):
      ASoC: codec: wcd939x: Convert to GPIO descriptors
      ASoC: codec: wcd938x: Convert to GPIO descriptors
      ASoC: codec: wcd9335: Convert to GPIO descriptors

 sound/soc/codecs/wcd9335.c | 15 +++++++--------
 sound/soc/codecs/wcd938x.c | 13 ++++++-------
 sound/soc/codecs/wcd939x.c | 16 ++++++++--------
 3 files changed, 21 insertions(+), 23 deletions(-)
---
base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c
change-id: 20250324-wcd-gpiod-782c4a0d8688

Best regards,

Comments

Mark Brown April 8, 2025, 12:48 p.m. UTC | #1 
On Mon, 24 Mar 2025 19:51:26 +0800, Peng Fan (OSS) wrote:
> Steev,
>  I would appreciate if you have time to help test again.
>  Hope V2 could work on your platform.
> 
> Linus,
>  Since v2 is only a minor change to use GPIOD_OUT_LOW to replace
>  GPIOD_ASIS when devm_gpio_get, so I still keep you R-b. Appreciate
>  for your quick action.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: codec: wcd939x: Convert to GPIO descriptors
      commit: 4bba5d0e51647e06c83036b6c3f0ec65465adc68
[2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors
      commit: c2d359b4acfbe847d3edcc25d3dc4e594daf9010
[3/3] ASoC: codec: wcd9335: Convert to GPIO descriptors
      commit: d5099bc1b56417733f4cccf10c61ee74dadd5562

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark