mbox series

[0/3] Elminate all DTBs check warnings for SDM630/660 boards

Message ID 20250504115120.1432282-1-alexeymin@postmarketos.org
Headers show
Series Elminate all DTBs check warnings for SDM630/660 boards | expand

Message

Alexey Minnekhanov May 4, 2025, 11:51 a.m. UTC
Run the following:

 make -j1  CHECK_DTBS=y 'qcom/sdm630-*.dtb' \
         'qcom/sdm636-*.dtb' 'qcom/sdm660-*.dtb' \
         'qcom/sda660-*.dtb'

Before:

 Observe multiple warning about memory-region is too short,
 one about 'vdda-pll-supply' is a required property, two
 about 'clocks' is a dependency of 'clock-names'. Fix them all!

After:

 SCHEMA  Documentation/devicetree/bindings/processed-schema.json
 DTC [C] arch/arm64/boot/dts/qcom/sdm630-sony-xperia-ganges-kirin.dtb
 DTC [C] arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-discovery.dtb
 DTC [C] arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-pioneer.dtb
 DTC [C] arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-voyager.dtb
 DTC [C] arch/arm64/boot/dts/qcom/sdm636-sony-xperia-ganges-mermaid.dtb
 DTC [C] arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dtb
 DTC [C] arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb

No errors, no warnings.

Alexey Minnekhanov (3):
  arm64: dts: qcom: sdm630: Add modem metadata mem
  arm64: dts: qcom: sdm660-lavender: Add missing USB phy supply
  arm64: dts: qcom: sda660-ifc6560: Fix dt-validate warning

 arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 ++
 arch/arm64/boot/dts/qcom/sdm630.dtsi                | 8 +++++++-
 arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts | 1 +
 3 files changed, 10 insertions(+), 1 deletion(-)

Comments

Dmitry Baryshkov May 4, 2025, 2:48 p.m. UTC | #1
On Sun, May 04, 2025 at 02:51:18PM +0300, Alexey Minnekhanov wrote:
> Similarly to MSM8998, add and use modem metadata memory region.
> This does not seemingly affect device functionality. But it fixes
> DTBs check warning:
> 
>  remoteproc@4080000: memory-region: [[45], [46]] is too short

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

> 
> Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm630.dtsi | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 2d3820536ddf4..8b1a45a4e56ed 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -509,6 +509,12 @@ zap_shader_region: gpu@fed00000 {
>  			reg = <0x0 0xfed00000 0x0 0xa00000>;
>  			no-map;
>  		};
> +
> +		mdata_mem: mpss-metadata {
> +			alloc-ranges = <0x0 0xa0000000 0x0 0x20000000>;
> +			size = <0x0 0x4000>;
> +			no-map;
> +		};
>  	};
>  
>  	smem: smem {
> @@ -1056,7 +1062,7 @@ remoteproc_mss: remoteproc@4080000 {
>  					<&rpmpd SDM660_VDDMX>;
>  			power-domain-names = "cx", "mx";
>  
> -			memory-region = <&mba_region>, <&mpss_region>;
> +			memory-region = <&mba_region>, <&mpss_region>, <&mdata_mem>;
>  
>  			status = "disabled";
>  
> -- 
> 2.49.0
>
Dmitry Baryshkov May 4, 2025, 2:52 p.m. UTC | #2
On Sun, May 04, 2025 at 02:51:20PM +0300, Alexey Minnekhanov wrote:
> If you remove clocks property, you should remove clock-names, too.
> Fixes warning with dtbs check:
> 
>  'clocks' is a dependency of 'clock-names'
> 
> Fixes: 34279d6e3f32c ("arm64: dts: qcom: sdm660: Add initial Inforce IFC6560 board support")
> Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Bjorn Andersson May 7, 2025, 5:18 a.m. UTC | #3
On Sun, 04 May 2025 14:51:17 +0300, Alexey Minnekhanov wrote:
> Run the following:
> 
>  make -j1  CHECK_DTBS=y 'qcom/sdm630-*.dtb' \
>          'qcom/sdm636-*.dtb' 'qcom/sdm660-*.dtb' \
>          'qcom/sda660-*.dtb'
> 
> Before:
> 
> [...]

Applied, thanks!

[1/3] arm64: dts: qcom: sdm630: Add modem metadata mem
      commit: 02a8b9894b9cbf4ffcd8661813826494cf49d3a2
[2/3] arm64: dts: qcom: sdm660-lavender: Add missing USB phy supply
      commit: dbf62a117a1b7f605a98dd1fd1fd6c85ec324ea0
[3/3] arm64: dts: qcom: sda660-ifc6560: Fix dt-validate warning
      commit: f5110806b41eaa0eb0ab1bf2787876a580c6246c

Best regards,