| Message ID | 20250513-qcom_ipq_ppe-v4-0-4fbe40cbbb71@quicinc.com |
|---|---|
| Headers | show |
| Series | Add PPE driver for Qualcomm IPQ9574 SoC | expand |
On 5/15/2025 10:58 AM, Jakub Kicinski wrote: > On Tue, 13 May 2025 17:58:20 +0800 Luo Jie wrote: >> The PPE (packet process engine) hardware block is available in Qualcomm >> IPQ chipsets that support PPE architecture, such as IPQ9574 and IPQ5332. >> The PPE in the IPQ9574 SoC includes six ethernet ports (6 GMAC and 6 >> XGMAC), which are used to connect with external PHY devices by PCS. The >> PPE also includes packet processing offload capabilities for various >> networking functions such as route and bridge flows, VLANs, different >> tunnel protocols and VPN. It also includes an L2 switch function for >> bridging packets among the 6 ethernet ports and the CPU port. The CPU >> port enables packet transfer between the ethernet ports and the ARM >> cores in the SoC, using the ethernet DMA. > > Please make sure the code builds cleanly with W=1. Yes, the patch series is successfully built with W=1 for ARM and ARM64 on my local workspace. make CROSS_COMPILE=arm-linux-gnueabi- ARCH=arm W=1 make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 W=1 However, from the patchwork result as below, it seems the dependent patch series (for FIELD_MODIFY() macro) did not get picked to validate the PPE driver patch series together. This dependency is mentioned in the cover letter. Could you advise what could be wrong here, which is preventing the dependent patch to be picked up? Thanks. https://netdev.bots.linux.dev/static/nipa/962354/14086331/build_32bit/stderr
On 5/15/2025 10:24 PM, Jakub Kicinski wrote: > On Thu, 15 May 2025 22:19:11 +0800 Luo Jie wrote: >> However, from the patchwork result as below, it seems the dependent >> patch series (for FIELD_MODIFY() macro) did not get picked to validate >> the PPE driver patch series together. This dependency is mentioned in >> the cover letter. Could you advise what could be wrong here, which is >> preventing the dependent patch to be picked up? Thanks. > > Please try to read more about kernel development process. > These patches are not in Linus's tree or the networking tree. > If you want to use them you have to wait with your submission > until after the next merge window. OK, understand now. I will push the new version after the next merge window. Thanks for the information.
The PPE (packet process engine) hardware block is available in Qualcomm IPQ chipsets that support PPE architecture, such as IPQ9574 and IPQ5332. The PPE in the IPQ9574 SoC includes six ethernet ports (6 GMAC and 6 XGMAC), which are used to connect with external PHY devices by PCS. The PPE also includes packet processing offload capabilities for various networking functions such as route and bridge flows, VLANs, different tunnel protocols and VPN. It also includes an L2 switch function for bridging packets among the 6 ethernet ports and the CPU port. The CPU port enables packet transfer between the ethernet ports and the ARM cores in the SoC, using the ethernet DMA. This patch series is the first part of a three part series that will together enable Ethernet function for IPQ9574 SoC. While support is initially being added for IPQ9574 SoC, the driver will be easily extendable to enable Ethernet support for other IPQ SoC such as IPQ5332. The driver can also be extended later for adding support for L2/L3 network offload features that the PPE can support. The functionality to be enabled by each of the three series (to be posted sequentially) is as below: Part 1: The PPE patch series (this series), which enables the platform driver, probe and initialization/configuration of different PPE hardware blocks. Part 2: The PPE MAC patch series, which enables the phylink operations for the PPE ethernet ports. Part 3: The PPE EDMA patch series, which enables the Rx/Tx Ethernet DMA and netdevice driver for the 6 PPE ethernet ports. A more detailed description of the functions enabled by part 1 is below: 1. Initialize PPE device hardware functions such as buffer management, queue management, scheduler and clocks in order to bring up PPE device. 2. Enable platform driver and probe functions 3. Register debugfs file to provide access to various PPE packet counters. These statistics are recorded by the various hardware process counters, such as port RX/TX, CPU code and hardware queue counters. 4. A detailed introduction of PPE along with the PPE hardware diagram in the first two patches (dt-bindings and documentation). Below is a reference to an earlier RFC discussion with the community about enabling ethernet driver support for Qualcomm IPQ9574 SoC. This writeup can help provide a higher level architectural view of various other drivers that support the PPE such as clock and PCS drivers. Topic: RFC: Advice on adding support for Qualcomm IPQ9574 SoC Ethernet. https://lore.kernel.org/linux-arm-msm/d2929bd2-bc9e-4733-a89f-2a187e8bf917@quicinc.com/ Signed-off-by: Luo Jie <quic_luoj@quicinc.com> --- Changes in v4: - Simplify statements regarding module load in documentation as per comments. - Improve data structure definitions for scheduler patch for clarity. - Replace u32p_replace_bits() with FIELD_MODIFY(). - Enhance the comment of the PPE scheduler for BM and QM configurations. - Debugfs improvements: *Remove print related macros and inline the code instead. *Return error codes from register read/write wherever applicable. *Split the hardware counter display file into separate files. - Link to v3: https://lore.kernel.org/r/20250209-qcom_ipq_ppe-v3-0-453ea18d3271@quicinc.com Changes in v3: - Add the top-level ref ethernet-switch.yaml and remove node definition ethernet-ports in the DT binding file. - Remove unnecessary error message for devm_kzalloc(). - Reverse the mapping of BM ceiling bits. - Fix multicast queue start/end configurations. - Declare the SoC-specific PPE configuration variables as const. - Fix kernel documentation errors. - Fix the compile errors reported by gcc-14. - Improve the commit message of L2 bridge initialization and debugfs patches. - Link to v2: https://lore.kernel.org/r/20250108-qcom_ipq_ppe-v2-0-7394dbda7199@quicinc.com Changes in v2: - Represent the PPE hardware hierarchy in dtbindings, add PPE hardware diagram. - Remove all SoC specific hardware properties from dtbindings since driver maintains them. - Move out the PCS (UNIPHY) handling into a separate PCS driver posted separately at below. https://lore.kernel.org/all/20250207-ipq_pcs_6-14_rc1-v5-0-be2ebec32921@quicinc.com - Move out the PPE MAC patches into a separate series to limit patch count to 15 or less. (PPE MAC patches will be posted sequentially after this series). - Rename the hardware initialization related files from ppe_ops.c[h] to ppe_config.c[h] - Improve PPE driver documentation and diagram. - Fix dtbinding check errors. - Link to v1: https://lore.kernel.org/r/20240110114033.32575-1-quic_luoj@quicinc.com --- Lei Wei (2): docs: networking: Add PPE driver documentation for Qualcomm IPQ9574 SoC net: ethernet: qualcomm: Initialize PPE L2 bridge settings Luo Jie (12): dt-bindings: net: Add PPE for Qualcomm IPQ9574 SoC net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC net: ethernet: qualcomm: Initialize PPE buffer management for IPQ9574 net: ethernet: qualcomm: Initialize PPE queue management for IPQ9574 net: ethernet: qualcomm: Initialize the PPE scheduler settings net: ethernet: qualcomm: Initialize PPE queue settings net: ethernet: qualcomm: Initialize PPE service code settings net: ethernet: qualcomm: Initialize PPE port control settings net: ethernet: qualcomm: Initialize PPE RSS hash settings net: ethernet: qualcomm: Initialize PPE queue to Ethernet DMA ring mapping net: ethernet: qualcomm: Add PPE debugfs support for PPE counters MAINTAINERS: Add maintainer for Qualcomm PPE driver .../devicetree/bindings/net/qcom,ipq9574-ppe.yaml | 406 ++++ .../networking/device_drivers/ethernet/index.rst | 1 + .../device_drivers/ethernet/qualcomm/ppe/ppe.rst | 194 ++ MAINTAINERS | 8 + drivers/net/ethernet/qualcomm/Kconfig | 15 + drivers/net/ethernet/qualcomm/Makefile | 1 + drivers/net/ethernet/qualcomm/ppe/Makefile | 7 + drivers/net/ethernet/qualcomm/ppe/ppe.c | 234 +++ drivers/net/ethernet/qualcomm/ppe/ppe.h | 39 + drivers/net/ethernet/qualcomm/ppe/ppe_config.c | 2029 ++++++++++++++++++++ drivers/net/ethernet/qualcomm/ppe/ppe_config.h | 317 +++ drivers/net/ethernet/qualcomm/ppe/ppe_debugfs.c | 814 ++++++++ drivers/net/ethernet/qualcomm/ppe/ppe_debugfs.h | 16 + drivers/net/ethernet/qualcomm/ppe/ppe_regs.h | 556 ++++++ 14 files changed, 4637 insertions(+) --- base-commit: acdefab0dcbc3833b5a734ab80d792bb778517a0 change-id: 20250108-qcom_ipq_ppe-aa4c4fa0ab73 prerequisite-change-id: 20250411-field_modify-83b58db99025:v3 prerequisite-patch-id: d67ff5b44b11f3736651f9de10b8c2759111b932 prerequisite-patch-id: e68fa1f578d6ca2fa1f144339711149408774213 prerequisite-patch-id: 3975c5efbaba1ce03d97e701acb438575ff8386c prerequisite-patch-id: 760d6c0ec2b0e5158bff859ba1ed0d49185c702e prerequisite-patch-id: 871c668a11bf3a5959a018b56c474d44dc0e4d7d prerequisite-patch-id: c9ad97859dd5a586afa32ad1daac531dfc11d53d Best regards,