From patchwork Mon May 19 17:51:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 891141 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9483B2874E6; Mon, 19 May 2025 17:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747677258; cv=none; b=Ib2YLsGTr6JpeL9b2jYbR0hojEj3651Tm4juaWGjUZDZ7ttnEAgfHH1abrpwvEya1FSogVYPDy/vqO3/t7cqwrguG8k8DcrNZIX0X8qA6QZH4bX4f/dNtcDzv7R89t3IbP0d8XZ094gLBiW9BogkCFqKUCSv25lpy8krqlexwdc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747677258; c=relaxed/simple; bh=JqSbP2mRbsEIshyq4VeYctrtUBNxPieDIlhv0ksGXH8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BANQBb1HaMX8dxy7PI/70Ki0Wh9/2g52uoP3L4cVKZAYg5rGGBI2/4x/3fwksTyFUz7+nrUL99SoGyihoUMZMi5aRcBxZB7yxL6pwuQkUx8l0+gL2PF3jSnnuW3W5W6whC7fA0j78wuv3fekNGaiwAXnbemeR1iIs6ETuYLRs5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ea54zt69; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ea54zt69" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-306b6ae4fb2so3797817a91.3; Mon, 19 May 2025 10:54:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747677256; x=1748282056; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eZAvWXQeJhHVypWidg5RnFUIsUxQ00MWa7gy2+exJW0=; b=Ea54zt69Bd5LQ9GWTnDnBJd89FrZlTYf6v/FzFHpY7asYE5vabkNlHSbfQoSgetbCa HECjjwLo9LJsU5w1kQSjDV/c0aBsOXeG+ANzSYjpNJG24SGzGX173uDttvVJOHFbNF9n zwKtqIwtLw2OyPNBvJb/jH97/ExL0OK6EppLMOO+0l2SDGjHH/LZxT6w2QFCgCqFYHX0 cUOTZyfizOI8GtKnvNaeBsBrY2h+VcJte8DGlk330ScEiVpBEvN5P/ArSSaQN/zVyHJX xTBqZRiF1tudcve4TAw7Ssp9iIKNesRY9BUxconmw5H2x2MjcQClSUbNJw3A6m4i7ry0 +lHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747677256; x=1748282056; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eZAvWXQeJhHVypWidg5RnFUIsUxQ00MWa7gy2+exJW0=; b=qR2bkJJD8CKp5/5N96Oog+I6joljt4ITO/6hxRHAaxCGMqgx+Xea2Det7BwXZxqYE1 wP0LpE4lWokUcwz1j80iNRfV/1UivI3NlFtx851zov1S0q6W32jTQIZ9fR9dOvZymTbx bBtbIDXoUbwYv6hSnoaFe8CsYZJC33OIo1y9QqozTIMDslx3glsrOzmOJPk0jkTx+Cd6 tjggM18sEzApW7LZYOsVFOyuCNywOKm3MCcxm0k8UnuV/4OWEwP14n64NUX6mG46aNjg FxscqIb+VOhQC1pKZbR4/MYl3Y333hQvXe8e0nJ4plwgESzycmj0eqdm9jV+wQUvZQxy y4Qw== X-Forwarded-Encrypted: i=1; AJvYcCULRyvhXC3MLuE+O61SjpwoP+aEDbPSHnJkkIAZqdJP41QKNhQ+YpSsU0Ef/2Vtz2/L0cQ23/eqyAGt1xfg@vger.kernel.org, AJvYcCWZZ4WNvgz4Tmu8BiYwAOsNieD6HwWZz5kAFvLanNzufGJAnpqCDOH4WXJmGi9zh1CsMctIIi+JAIJZWGM=@vger.kernel.org, AJvYcCXP5sWnswuldgIAI+/XPsxJjwaXU8yKkLmO6VTBhh63U2L1kKltkEy+/ex+j6OKk7hXzh04wH2P8Z4GZT0+@vger.kernel.org X-Gm-Message-State: AOJu0YzC04srcClgVITjMEB2XXyAcA5Rvj9mzWUUqnvP2jwO9t8Ore0h rjMsPO+vKRKzFfD9rzR5DTOQobCSeOn/YMkgEsUnwBODUvclo2arjeAD X-Gm-Gg: ASbGncsrJI84hJXyrEjSjSA1mA/2O4ZYtdhGcB350BZk+E1f1puz8nPlfpYQMzDA4Et FSsGPGTU8K6u+YYDbj24Sh/JT3vyZhSMkmx+EAEKG/7bY32+bUVpKtwdNoGjPdx/3vDQbKB49KP MhUn+Dvjds6HAyh2QxJCUPb2PaRewFyQNnRhbjE3w+JniuUkXE2AskmuOlKdRdhBGaCVaXktcL5 IVU3DK1OBO67Jmb3rjlGYrRZIgY/U+0RaSLaPe9g8Lbbv4vQVQCJAzF9d7yEIBGSOExWqM0XeK2 NugHlHwzMo9PdSsjWuaNk5z7anm18SvsaPP55YNFs3cOZG0u6dCmvT/rc1SL373s1++jLxc01Pq N68UwtfKv0m0i7Td5w8RSjZZ0r6Jktiu2v7FR X-Google-Smtp-Source: AGHT+IH48ofu6vsBIRA77pQQk/Q03Uz8nSOktq6u6GzIKjiC5r3en5LiOZQS/u+qjGmMjOW/KPfXhA== X-Received: by 2002:a17:90b:4a50:b0:30e:7b26:f687 with SMTP id 98e67ed59e1d1-30e7d5cfb22mr21163448a91.29.1747677255528; Mon, 19 May 2025 10:54:15 -0700 (PDT) Received: from localhost ([2a00:79e0:3e00:2601:3afc:446b:f0df:eadc]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30e899cbb20sm5509793a91.1.2025.05.19.10.54.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 May 2025 10:54:14 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Connor Abbott , Rob Clark , Abhinav Kumar , =?utf-8?q?Andr=C3=A9_Almeida?= , Arnd Bergmann , =?utf-8?b?QmFybmFiw6FzIEN6w6ltw6Fu?= , =?utf-8?q?Christian_K=C3=B6nig?= , Christopher Snowhill , Dmitry Baryshkov , Dmitry Baryshkov , Eugene Lepshy , iommu@lists.linux.dev (open list:IOMMU SUBSYSTEM), Jason Gunthorpe , Jessica Zhang , Joao Martins , Jonathan Marek , Jun Nie , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linaro-mm-sig@lists.linaro.org (moderated list:DMA BUFFER SHARING FRAMEWORK:Keyword:\bdma_(?:buf|fence|resv)\b), linux-arm-kernel@lists.infradead.org (moderated list:ARM SMMU DRIVERS), linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:DMA BUFFER SHARING FRAMEWORK:Keyword:\bdma_(?:buf|fence|resv)\b), Marijn Suijten , Nicolin Chen , "Rob Herring (Arm)" , Robin Murphy , Sean Paul , Will Deacon Subject: [PATCH v5 00/40] drm/msm: sparse / "VM_BIND" support Date: Mon, 19 May 2025 10:51:23 -0700 Message-ID: <20250519175348.11924-1-robdclark@gmail.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Rob Clark Conversion to DRM GPU VA Manager[1], and adding support for Vulkan Sparse Memory[2] in the form of: 1. A new VM_BIND submitqueue type for executing VM MSM_SUBMIT_BO_OP_MAP/ MAP_NULL/UNMAP commands 2. A new VM_BIND ioctl to allow submitting batches of one or more MAP/MAP_NULL/UNMAP commands to a VM_BIND submitqueue I did not implement support for synchronous VM_BIND commands. Since userspace could just immediately wait for the `SUBMIT` to complete, I don't think we need this extra complexity in the kernel. Synchronous/immediate VM_BIND operations could be implemented with a 2nd VM_BIND submitqueue. The corresponding mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32533 Changes in v5: - Improved drm/sched enqueue_credit comments, and better define the return from drm_sched_entity_push_job() - Improve DRM_GPUVM_VA_WEAK_REF comments, and additional WARN_ON()s to make it clear that some of the gpuvm functionality is not available in this mode. - Link to v4: https://lore.kernel.org/all/20250514175527.42488-1-robdclark@gmail.com/ Changes in v4: - Various locking/etc fixes - Optimize the pgtable preallocation. If userspace sorts the VM_BIND ops then the kernel detects ops that fall into the same 2MB last level PTD to avoid duplicate page preallocation. - Add way to throttle pushing jobs to the scheduler, to cap the amount of potentially temporary prealloc'd pgtable pages. - Add vm_log to devcoredump for debugging. If the vm_log_shift module param is set, keep a log of the last 1< msm_context drm/msm: Improve msm_context comments drm/msm: Rename msm_gem_address_space -> msm_gem_vm drm/msm: Remove vram carveout support drm/msm: Collapse vma allocation and initialization drm/msm: Collapse vma close and delete drm/msm: Don't close VMAs on purge drm/msm: drm_gpuvm conversion drm/msm: Convert vm locking drm/msm: Use drm_gpuvm types more drm/msm: Split out helper to get iommu prot flags drm/msm: Add mmu support for non-zero offset drm/msm: Add PRR support drm/msm: Rename msm_gem_vma_purge() -> _unmap() drm/msm: Drop queued submits on lastclose() drm/msm: Lazily create context VM drm/msm: Add opt-in for VM_BIND drm/msm: Mark VM as unusable on GPU hangs drm/msm: Add _NO_SHARE flag drm/msm: Crashdump prep for sparse mappings drm/msm: rd dumping prep for sparse mappings drm/msm: Crashdec support for sparse drm/msm: rd dumping support for sparse drm/msm: Extract out syncobj helpers drm/msm: Use DMA_RESV_USAGE_BOOKKEEP/KERNEL drm/msm: Add VM_BIND submitqueue drm/msm: Support IO_PGTABLE_QUIRK_NO_WARN_ON drm/msm: Support pgtable preallocation drm/msm: Split out map/unmap ops drm/msm: Add VM_BIND ioctl drm/msm: Add VM logging for VM_BIND updates drm/msm: Add VMA unmap reason drm/msm: Add mmu prealloc tracepoint drm/msm: use trylock for debugfs drm/msm: Bump UAPI version drivers/gpu/drm/drm_gem.c | 14 +- drivers/gpu/drm/drm_gpuvm.c | 38 +- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 25 +- drivers/gpu/drm/msm/adreno/a2xx_gpummu.c | 5 +- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 17 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 17 +- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 22 +- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 32 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 49 +- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 6 +- drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 4 - drivers/gpu/drm/msm/adreno/adreno_gpu.c | 99 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 23 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 14 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 18 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 14 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 4 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 6 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 28 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 12 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 19 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 12 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 14 +- drivers/gpu/drm/msm/msm_drv.c | 184 +-- drivers/gpu/drm/msm/msm_drv.h | 35 +- drivers/gpu/drm/msm/msm_fb.c | 18 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 494 +++--- drivers/gpu/drm/msm/msm_gem.h | 247 ++- drivers/gpu/drm/msm/msm_gem_prime.c | 15 + drivers/gpu/drm/msm/msm_gem_shrinker.c | 104 +- drivers/gpu/drm/msm/msm_gem_submit.c | 295 ++-- drivers/gpu/drm/msm/msm_gem_vma.c | 1471 ++++++++++++++++- drivers/gpu/drm/msm/msm_gpu.c | 211 ++- drivers/gpu/drm/msm/msm_gpu.h | 144 +- drivers/gpu/drm/msm/msm_gpu_trace.h | 14 + drivers/gpu/drm/msm/msm_iommu.c | 302 +++- drivers/gpu/drm/msm/msm_kms.c | 18 +- drivers/gpu/drm/msm/msm_kms.h | 2 +- drivers/gpu/drm/msm/msm_mmu.h | 38 +- drivers/gpu/drm/msm/msm_rd.c | 62 +- drivers/gpu/drm/msm/msm_ringbuffer.c | 10 +- drivers/gpu/drm/msm/msm_submitqueue.c | 96 +- drivers/gpu/drm/msm/msm_syncobj.c | 172 ++ drivers/gpu/drm/msm/msm_syncobj.h | 37 + drivers/gpu/drm/scheduler/sched_entity.c | 19 +- drivers/gpu/drm/scheduler/sched_main.c | 3 + drivers/iommu/io-pgtable-arm.c | 27 +- include/drm/drm_gem.h | 10 +- include/drm/drm_gpuvm.h | 19 +- include/drm/gpu_scheduler.h | 24 +- include/linux/io-pgtable.h | 8 + include/uapi/drm/msm_drm.h | 149 +- 63 files changed, 3526 insertions(+), 1250 deletions(-) create mode 100644 drivers/gpu/drm/msm/msm_syncobj.c create mode 100644 drivers/gpu/drm/msm/msm_syncobj.h