From patchwork Wed May 21 15:45:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Eric Pelloux-Prayer X-Patchwork-Id: 891573 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2080.outbound.protection.outlook.com [40.107.236.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7BE21CA0E; Wed, 21 May 2025 15:46:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842365; cv=fail; b=lETPZStNbvlk1ah6d3imqUdOzahbglD+2YUPCjQ/YqoxWwvRW/MR/qEqaYE144k5O6mIs/NWMThkZJLUjUs0IxyLJoJYnZvufGlYcktcaqkoVyOQDwtcYcn1RsLHaBMlvZuFb/no1bOc7MgZLtBqPYrd2KYX/FNcf8L4YPB4azs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747842365; c=relaxed/simple; bh=lnXwW1zI7N8abAk3OPbw2zzGpROi7sJiooPA1OgZMh8=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Uz0ce7/IoJQCEo4G5iscMF+4wBMlZ+bHRCPZEyTvTyKMCfRLaomjIi7fFbwtn6w5KODIQuaZV2b61caooXUqRY/gfa45eBqrmp02SisLsaMrcICHC3xrF7kbiVdBSg2dmQC43zsomUVzuyGVc4nlgUqGR4Cu7DDk9BqRY3WRpKk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=vCFnANwx; arc=fail smtp.client-ip=40.107.236.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="vCFnANwx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BIQf42pqK0O5KesoWLgYck2mjtStAwn8CRFkIt6fTLE69vpIHASZUxKpMFzAJWXdKru3AsgLeLITYttatjY02V7FMXjKqynEg1VyI3F5EvmeRJkdkjlmgpP3EsM5BbsI8ED96Lc1JwHDXujtN436J3wuND1P20eWOoTAjJk8OLpUS2kVUpjIWr11x1EBmrcKveFbi28ZIJIb2yHb8aS8xCaBTKj6tufpXRb9ZcuASV6eFfhZop8y4a1LAf3cKmk/A0uKQY5BJkDajbYiJhLTOxTR5qrYfCh7SyU+B6OO3P3geI5Z209gLC0OQD504XeJTC9VWJmfF7vdGM4ZFOKXag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N1b89WLcsFg8CSvbQz6tPUPNbJWiERNve+JswxAVQVw=; b=NzPU6cNKtwNol5nvXBo9J6yhpEoEE/k861IpbyDaBnxB2WD6Bvi7k7Zl3BJtUiVsDxfXt4JzScIubgwGLAXaNk3xy78MzIL/f7N8Y8Ck4Vd2mNsMoWtcQ3CsLGW/aWcntYLIkgPYHZn1ZLuf6bolVc1fada5T6kRDPffBO3TL+cev00bZ60WqZoRWP/FDh4LQGc8zo5pjKmLjIMzH06xjN7VM0R8kKv0kV208uK2PK7Ebf2Dq10tEFpIVc/O7TFTqdHaZ3lCY80ZzyB6MnS941kLQ6sERZBROgr3RD4ZdgyPcgQpfsb8JKgRuOlgNK0IBDDPGDpojmFRIMxeT2dxZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=igalia.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N1b89WLcsFg8CSvbQz6tPUPNbJWiERNve+JswxAVQVw=; b=vCFnANwxMRDeL5OHh/drEEzEqsTrl9pVaqpmWVwwPW/aCWq8F3ePbcdW+IQlf7mUglPtdDf8AF7YK9zLo1mJgSna1ILIrn1rUO84zELN1fIccOFhKLRAkg5Ol3NGhK1ChzLBhofWXJYSkkg9W3XN2SlVzE+AQPb8Tgzbwjk73nQ= Received: from BYAPR05CA0040.namprd05.prod.outlook.com (2603:10b6:a03:74::17) by SJ2PR12MB7800.namprd12.prod.outlook.com (2603:10b6:a03:4c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.31; Wed, 21 May 2025 15:45:58 +0000 Received: from SJ1PEPF00001CE9.namprd03.prod.outlook.com (2603:10b6:a03:74:cafe::bc) by BYAPR05CA0040.outlook.office365.com (2603:10b6:a03:74::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:45:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ1PEPF00001CE9.mail.protection.outlook.com (10.167.242.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8769.18 via Frontend Transport; Wed, 21 May 2025 15:45:57 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 May 2025 10:45:50 -0500 From: Pierre-Eric Pelloux-Prayer To: CC: Pierre-Eric Pelloux-Prayer , =?utf-8?q?Christian_K=C3=B6nig?= , =?utf-8?q?Ma?= =?utf-8?q?=C3=ADra_Canal?= , =?utf-8?q?Thomas_Hellstr?= =?utf-8?q?=C3=B6m?= , Abhinav Kumar , Alex Deucher , Boris Brezillon , Danilo Krummrich , David Airlie , "Dmitry Baryshkov" , Felix Kuehling , "Frank Binns" , Jonathan Corbet , Liviu Dudau , Lizhi Hou , Lucas De Marchi , Lucas Stach , Lyude Paul , Maarten Lankhorst , Matt Coster , Matthew Brost , Maxime Ripard , Melissa Wen , Min Ma , Oded Gabbay , Philipp Stanner , Qiang Yu , Rob Clark , Rob Herring , Rodrigo Vivi , Simona Vetter , Steven Price , Sumit Semwal , "Thomas Zimmermann" , , , , , , , , , , , , Subject: [PATCH v10 00/10] Improve gpu_scheduler trace events + UAPI Date: Wed, 21 May 2025 17:45:02 +0200 Message-ID: <20250521154531.10541-1-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE9:EE_|SJ2PR12MB7800:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c4978cc-11d2-4c80-7b45-08dd987e945c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|7416014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?q?hYeGKIYZMLVp6n/08Wz0ObfKk182lJX?= =?utf-8?q?1T7A2z8C6wg8zjwENcx3tCsng3QGgnD2UDPc+OV4ai+6KNcPvKAAC5r2ydb/31fd1?= =?utf-8?q?sfdd5RVe810xdF+kBzpkeDpHgNn2uoCsiQufwJ3h9OJDkvo8Lm2GBWeN2/MKtdrT5?= =?utf-8?q?DEfRPjTBxpDa2Tu2WKkOP7g5mXmMpuKDyXW4HSs88hjrEfc9Br/ZU8Lj53TjgNCCn?= =?utf-8?q?y5t8EEpvhlirm+2cebq/KW7veeA4bseIiHPdJH1b/7Me2QzI6kvDsfMbGx4AqWfEu?= =?utf-8?q?RxZM8xCN7ua0hGwVlyeMSiEP1pTSJoOVj6cV36efhTawZbdnJD0MLLczmTCrY/2lt?= =?utf-8?q?pb7LGqpXOzL2WTUZxKsxr3URR4mEnscS5aafdM4pTBU5ahk9qFoTXo5VZhPZLnfjO?= =?utf-8?q?M3J2B6pn0IvU1qUvf61qMB/R94q1mae5RoSepyW2rrY+zAYMNQoJMOASwWSL+iJ2g?= =?utf-8?q?6QmkBRjv16Beqy3BNDG1pOlkCXZCd2WxfnxZFU708BLZwrm/b6/XJylkHhOOfweZM?= =?utf-8?q?fS2J8f+zx6ckwSxDySma+nJQZmL3i9bIC7VtRY6njfdS37chpM5cjFAQIYrDZnELZ?= =?utf-8?q?5yUPY2/EN3NPmzkg7EEyXzfDLszZkOVfX0cNOAbatwIf1ZBJU3Wnj6n8tAe4BWk6c?= =?utf-8?q?pLNhDNk1uY/9IZcPERaB/ZOhTovDLJkI+Xx9mhCILWBlzLHBoihzwvcRJnHTGR+3H?= =?utf-8?q?10P4sB032n3Ra0a90azSLzlKnxOLI+74ni0bYfRQJ3kfzp++qOrv17w/s6uiI38PG?= =?utf-8?q?+x84JK6+lHy/3c3s/K/0lcn6KzgikNIIoPq002MylvP78GFgNCYPPcmY4Z9HVVEAX?= =?utf-8?q?+66E8RsPUtRsTZSU3L7Q4t8f6dS6gcW4SYbfnu2ScIVHyeVXi7Z8VixW8pqix+L3Y?= =?utf-8?q?CGlPIEnLWLKtfbZCo+buwgKbQ97bzuJyBID7Ebb2vXENjr+h/F+854ujWtm0I5Y/8?= =?utf-8?q?jYi8qU+s/F+N/2LCiFdGyUSqdG60gP5GsMZM2RD31QFWlsrU7NEWP5jzMHJb+r+rr?= =?utf-8?q?6c+c1sKFUsvFLlJYLPX1R65aREKONB6oJpiYiGLSBPHYPIJHXmMzBzaWltGLLT7Jt?= =?utf-8?q?65ubxQ3iNhio66o5ZgRFrgbCaT54rNmXCtPtOc6EnRcNhZ8SGJwHFyfvvztzp1o1W?= =?utf-8?q?X/6TIiQIXhXs+vPmzjFjw0/dCFVHfjv54JDgZ7DmFokURKelbh3YDliGCQyGp3AUU?= =?utf-8?q?aQD+jyeWA9dsliJzcDDo+PKgq9BGMN9g33zWF1gvyLg8//m6kGNt/wU4Ev/lQLMnI?= =?utf-8?q?D5oWt839ES1ZxSKq52zKzUoOkHMP/MIhFsKHB50XExws5IjbQaoSPBtIStFqwoPtq?= =?utf-8?q?E52z76EfyWRruOwARc2WxhdWtKRR2LCcOxkaJuePUjG8CtiayNh2yxvFWOTJiuImo?= =?utf-8?q?Ryp7gxPJrQe14/ZJu4qsPv18pUnfCYM8Q=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2025 15:45:57.7610 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c4978cc-11d2-4c80-7b45-08dd987e945c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7800 Hi, The initial goal of this series was to improve the drm and amdgpu trace events to be able to expose more of the inner workings of the scheduler and drivers to developers via tools. Then, the series evolved to become focused only on gpu_scheduler. The changes around vblank events will be part of a different series, as well as the amdgpu ones. Moreover Sima suggested to make some trace events stable uAPI, so tools can rely on them long term. The first patches extend and cleanup the gpu scheduler events, then add a documentation entry in drm-uapi.rst. The last 2 patches are new in v8. One is based on a suggestion from Tvrtko and gets rid of drm_sched_job::id. The other is a cleanup of amdgpu trace events to use the fence=%llu:%llu format. The drm_sched_job patches don't affect gpuvis which has code to parse the gpu_scheduler events but these events are not enabled. Changes since v9: * fixed documentation link syntax * fixed typos in commit messages * spelled out that these events cannot be used before drm_sched_job_arm has been called Changes since v8: * swapped patches 8 & 9 * rebased on drm-next Changes since v7: * uint64_t -> u64 * reworked dependencies tracing (Tvrtko) * use common name prefix for all events (Tvrtko) * dropped drm_sched_job::id (Tvrtko) Useful links: - userspace tool using the updated events: https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37 - v8: https://lists.freedesktop.org/archives/dri-devel/2025-March/496781.html Pierre-Eric Pelloux-Prayer (10): drm/debugfs: Output client_id in in drm_clients_info drm/sched: Store the drm client_id in drm_sched_fence drm/sched: Add device name to the drm_sched_process_job event drm/sched: Cleanup gpu_scheduler trace events drm/sched: Trace dependencies for GPU jobs drm/sched: Add the drm_client_id to the drm_sched_run/exec_job events drm/sched: Cleanup event names drm: Get rid of drm_sched_job.id drm/doc: Document some tracepoints as uAPI drm/amdgpu: update trace format to match gpu_scheduler_trace Documentation/gpu/drm-uapi.rst | 19 ++++ drivers/accel/amdxdna/aie2_ctx.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 32 ++---- drivers/gpu/drm/drm_debugfs.c | 10 +- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- drivers/gpu/drm/imagination/pvr_job.c | 2 +- drivers/gpu/drm/imagination/pvr_queue.c | 5 +- drivers/gpu/drm/imagination/pvr_queue.h | 2 +- drivers/gpu/drm/lima/lima_gem.c | 2 +- drivers/gpu/drm/lima/lima_sched.c | 6 +- drivers/gpu/drm/lima/lima_sched.h | 3 +- drivers/gpu/drm/msm/msm_gem_submit.c | 8 +- drivers/gpu/drm/nouveau/nouveau_sched.c | 3 +- drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- drivers/gpu/drm/panthor/panthor_drv.c | 3 +- drivers/gpu/drm/panthor/panthor_mmu.c | 2 +- drivers/gpu/drm/panthor/panthor_sched.c | 5 +- drivers/gpu/drm/panthor/panthor_sched.h | 3 +- .../gpu/drm/scheduler/gpu_scheduler_trace.h | 103 +++++++++++++----- drivers/gpu/drm/scheduler/sched_entity.c | 16 ++- drivers/gpu/drm/scheduler/sched_fence.c | 4 +- drivers/gpu/drm/scheduler/sched_internal.h | 2 +- drivers/gpu/drm/scheduler/sched_main.c | 12 +- .../gpu/drm/scheduler/tests/mock_scheduler.c | 2 +- drivers/gpu/drm/v3d/v3d_submit.c | 2 +- drivers/gpu/drm/xe/xe_sched_job.c | 3 +- include/drm/gpu_scheduler.h | 13 ++- 31 files changed, 188 insertions(+), 97 deletions(-)