mbox series

[v4,0/3] ASoC: remove component->id

Message ID 87bjr4uup4.wl-kuninori.morimoto.gx@renesas.com
Headers show
Series ASoC: remove component->id | expand

Message

Kuninori Morimoto June 4, 2025, 2:06 a.m. UTC 
Hi Mark, Srinivas, Qcom members

snd_soc_component has "id", but no one is using it except Qcom. It is
initialized at snd_soc_component_initialize(), but Qcom overwrites it.

According to Srinivas, unfortunately, current Qcom lpass is broken.
But we can update it and then, avoid to use component->id.
Let's do it, and remove it.

v3 -> v4:
	- based on latest linus/master branch

v2 -> v3
	- add missing Signed-off-by to Qcom patch

v1 -> v2
	- Qcom driver code was updated to Srinivas's code.

Kuninori Morimoto (2):
  ASoC: soc-core: save ID if param was set in fmt_single_name()
  ASoC: remove component->id

Srinivas Kandagatla (1):
  ASoC: qcom: use drvdata instead of component to keep id

 include/sound/soc-component.h   |  1 -
 sound/soc/qcom/lpass-platform.c | 27 +++++++++++++++++----------
 sound/soc/soc-core.c            | 14 +++++++++-----
 3 files changed, 26 insertions(+), 16 deletions(-)

Comments

Mark Brown June 9, 2025, 9 p.m. UTC | #1 
On Wed, 04 Jun 2025 02:06:15 +0000, Kuninori Morimoto wrote:
> snd_soc_component has "id", but no one is using it except Qcom. It is
> initialized at snd_soc_component_initialize(), but Qcom overwrites it.
> 
> According to Srinivas, unfortunately, current Qcom lpass is broken.
> But we can update it and then, avoid to use component->id.
> Let's do it, and remove it.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: qcom: use drvdata instead of component to keep id
      commit: 8167f4f42572818fa8153be2b03e4c2120846603
[2/3] ASoC: soc-core: save ID if param was set in fmt_single_name()
      commit: 6ada7351af0c4e295739adfa2c4b780c037b3d27
[3/3] ASoC: remove component->id
      commit: d3de84858811ea2c501cb45f0aafcae5beba20b6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark