| Message ID | cover.1683630932.git.quic_varada@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable IPQ9754 USB | expand |
On Tue, May 09, 2023 at 04:08:59PM +0300, Dmitry Baryshkov wrote: > On Tue, 9 May 2023 at 14:56, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: > > > > Add LDO regulator node > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Changes in v10: > > - Add LDO regulator node > > --- > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Minor question below: > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > index bdc1434..1f5d14f 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > @@ -60,6 +60,13 @@ > > regulator-min-microvolt = <725000>; > > regulator-max-microvolt = <1075000>; > > }; > > + > > + mp5496_l2: l2 { > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > This usually points out that there are other users which are not yet > enabled/properly specified. What users are there for this supply which > demand it to be always on? The 1.8v rail is used by PCIe PHY, PLL for Ethernet SerDes interface and PLLs that generate SoC clocks. The voting for this rail is managed by the RPM f/w. Thanks Varada > > + }; > > }; > > }; > > > > -- > > 2.7.4 > > > > > -- > With best wishes > Dmitry
On Wed, 10 May 2023 at 13:23, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > On Tue, May 09, 2023 at 04:08:59PM +0300, Dmitry Baryshkov wrote: > > On Tue, 9 May 2023 at 14:56, Varadarajan Narayanan > > <quic_varada@quicinc.com> wrote: > > > > > > Add LDO regulator node > > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > --- > > > Changes in v10: > > > - Add LDO regulator node > > > --- > > > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Minor question below: > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > index bdc1434..1f5d14f 100644 > > > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > > > @@ -60,6 +60,13 @@ > > > regulator-min-microvolt = <725000>; > > > regulator-max-microvolt = <1075000>; > > > }; > > > + > > > + mp5496_l2: l2 { > > > + regulator-min-microvolt = <1800000>; > > > + regulator-max-microvolt = <1800000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > > This usually points out that there are other users which are not yet > > enabled/properly specified. What users are there for this supply which > > demand it to be always on? > > The 1.8v rail is used by PCIe PHY, PLL for Ethernet SerDes > interface and PLLs that generate SoC clocks. The voting for this > rail is managed by the RPM f/w. Then I'm looking forward to seeing the patch which declares all the actual users of the lane. Please do not declare power lanes as boot-on/always-on unless there is a strong reason for doing it. > > Thanks > Varada > > > > + }; > > > }; > > > }; > > > > > > -- > > > 2.7.4 > > > > > > > > > -- > > With best wishes > > Dmitry
On 09-05-23, 17:24, Varadarajan Narayanan wrote: > This patch series adds the relevant phy and controller > configurations for enabling USB on IPQ9754 Applied phy patches, 1,2,5,6
This patch series adds the relevant phy and controller configurations for enabling USB on IPQ9754 Depends on: https://lore.kernel.org/all/20230217142030.16012-1-quic_devipriy@quicinc.com/ https://lore.kernel.org/lkml/20230407155727.20615-1-quic_devipriy@quicinc.com/T/ [v11]: - Rename dwc_0 -> usb_0_dwc3 - Minor change in qcom,sc8280xp-qmp-usb3-uni-phy.yaml to factor in latest updates to the file [v10]: - Fix regulator definitions - Address couple of other comments [v9]: - Update bindings to make power-domains as optional since IPQ9574 doesn't have GDSCs [v8]: - Update bindings for the clock name change [v7]: - com_aux -> cfg_ahb in patch 7 [v6]: - Incorporated review comments - Resolve make dtbs_check messages - Fixed pcs_usb offset - Board dts file name changed [v5]: - Incorporated review comments - 'make dtbs_check' giving the following messages since ipq9574 doesn't have power domains. Hope this is ok /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: phy@7d000: 'power-domains' is a required property From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml /local/mnt/workspace/varada/varda-linux/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dtb: usb@8a00000: 'power-domains' is a required property From schema: /local/mnt/workspace/varada/varda-linux/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml - Move qmp phy DT node to newer specification [v4]: - Incorporated review comments - Address all 'make dtbs_check' errors [v3]: - Incorporated review comments regarding coding style [v2]: - Incorporated review comments regarding coding style, maintaining sorted order of entries and unused phy register offsets - Removed NOC clock entries from DT node (will be implemented later with interconnect support) - Fixed 'make dtbs_check' errors/warnings [v1]: https://lore.kernel.org/linux-arm-msm/5dac3aa4-8dc7-f9eb-5cf3-b361efdc9494@linaro.org/T/ Varadarajan Narayanan (9): dt-bindings: phy: qcom,qusb2: Document IPQ9574 compatible dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY dt-bindings: usb: dwc3: Add IPQ9574 compatible clk: qcom: gcc-ipq9574: Add USB related clocks phy: qcom-qusb2: add QUSB2 support for IPQ9574 phy: qcom: qmp: Update IPQ9574 USB Phy initialization Sequence arm64: dts: qcom: ipq9574: Add USB related nodes arm64: dts: qcom: ipq9574: Add LDO regulator node arm64: dts: qcom: ipq9574: Enable USB .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 3 +- .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 44 ++++++-- .../devicetree/bindings/usb/qcom,dwc3.yaml | 3 +- arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 30 ++++++ arch/arm64/boot/dts/qcom/ipq9574.dtsi | 104 +++++++++++++++++++ drivers/clk/qcom/gcc-ipq9574.c | 37 +++++++ drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 115 +++++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 + include/dt-bindings/clock/qcom,ipq9574-gcc.h | 2 + 9 files changed, 333 insertions(+), 8 deletions(-)