From patchwork Fri Aug 26 21:59:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 74852 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp575917qga; Fri, 26 Aug 2016 14:59:39 -0700 (PDT) X-Received: by 10.66.159.170 with SMTP id xd10mr10055320pab.41.1472248779677; Fri, 26 Aug 2016 14:59:39 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ul9si23327929pab.14.2016.08.26.14.59.39; Fri, 26 Aug 2016 14:59:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753081AbcHZV7g (ORCPT + 8 others); Fri, 26 Aug 2016 17:59:36 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:34437 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbcHZV7f (ORCPT ); Fri, 26 Aug 2016 17:59:35 -0400 Received: by mail-pf0-f172.google.com with SMTP id p64so32337124pfb.1 for ; Fri, 26 Aug 2016 14:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=5FKG3TfPGU3euQ4uFBAiFuHU0w8LHViaQjO6g4g2fYs=; b=bKA60Y3cnhnsmcgIDpdlPqcjsr+SXxrbg10weRwubjQdLHWiOJA/ASIxU1IKN3FiGI yz7Midf1UQR6/65M/uEz/vHyTEq532S+EgWWcHMuqk4o9jAa6kGof8mRHuNj4QrU4tCk uecxQH93lyf990vBkC2nagVpaN888knGJfR00= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5FKG3TfPGU3euQ4uFBAiFuHU0w8LHViaQjO6g4g2fYs=; b=mZmWVieCuwM1ikPIAwb+bVX2EK/7yesvUDRI2s0LY60WKvYDZRsZYkydr+qBD8aQ84 54sY7JI+c8DiX0JIw/Vu1XNAVKnkjIY9kedXr7egfeym9tGeJUtNGDGYMHV6/+eKT01G /6k6gNqAz23ZET3ksCWbtagKxSmbP3mMOct5n5M6Mc6lEgsjimckMpnMBFBzwcxHnEt+ uIPy4UzlfWGpTnChOZraYgEsr4vfwoaK3HaUx4xhR+dnC6aY+V6a+dD3ff7z91gGy2WN YadTeV/U8ZmFMouMJrVR0jlOiRCtATnwevtKNwr9E8HyBJghPinPZTAJ0E0loOktxeyk cvBQ== X-Gm-Message-State: AE9vXwOZ8WbqfoFiDksCbn4svyeZNqtW3mS5lyTDTdcwEKHW7+IGBKTlG3sGruTNUrWy0qCd X-Received: by 10.98.51.131 with SMTP id z125mr9810760pfz.109.1472248760456; Fri, 26 Aug 2016 14:59:20 -0700 (PDT) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id uc1sm31074704pac.24.2016.08.26.14.59.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Aug 2016 14:59:19 -0700 (PDT) From: Bjorn Andersson To: Andy Gross Cc: Jeremy McNicoll , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: qcom: smd: Reset rx tail rather than tx Date: Fri, 26 Aug 2016 14:59:17 -0700 Message-Id: <1472248757-10478-1-git-send-email-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.5.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The local end of each SMD channel is responsible for updating the tx head and the rx tail, as such we should not touch the tx tail during a reset. Reported-by: Jeremy McNicoll Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c index ac1957dfdf24..f11ec84ab0ce 100644 --- a/drivers/soc/qcom/smd.c +++ b/drivers/soc/qcom/smd.c @@ -374,7 +374,7 @@ static void qcom_smd_channel_reset(struct qcom_smd_channel *channel) SET_TX_CHANNEL_FLAG(channel, fSTATE, 1); SET_TX_CHANNEL_FLAG(channel, fBLOCKREADINTR, 1); SET_TX_CHANNEL_INFO(channel, head, 0); - SET_TX_CHANNEL_INFO(channel, tail, 0); + SET_RX_CHANNEL_INFO(channel, tail, 0); qcom_smd_signal_channel(channel);