diff mbox series

[v2,2/2] bus: mhi: Remove unused nr_irqs_req variable

Message ID 1600673819-1698-2-git-send-email-loic.poulain@linaro.org
State Accepted
Commit 9654ab011e28ee756d231035c488509dc214fa6f
Headers show
Series [v2,1/2] bus: mhi: core: Allow shared IRQ for event rings | expand

Commit Message

Loic Poulain Sept. 21, 2020, 7:36 a.m. UTC
nr_irqs_req is unused in MHI stack.

Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
 v2: add this patch to the series

 drivers/bus/mhi/core/init.c | 3 ---
 include/linux/mhi.h         | 2 --
 2 files changed, 5 deletions(-)

Comments

Manivannan Sadhasivam Sept. 21, 2020, 2:22 p.m. UTC | #1
On Mon, Sep 21, 2020 at 09:36:59AM +0200, Loic Poulain wrote:
> nr_irqs_req is unused in MHI stack.
> 
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  v2: add this patch to the series
> 
>  drivers/bus/mhi/core/init.c | 3 ---
>  include/linux/mhi.h         | 2 --
>  2 files changed, 5 deletions(-)
> 
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index 31961af..8798deb 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -643,9 +643,6 @@ static int parse_ev_cfg(struct mhi_controller *mhi_cntrl,
>  		mhi_event++;
>  	}
>  
> -	/* We need IRQ for each event ring + additional one for BHI */
> -	mhi_cntrl->nr_irqs_req = mhi_cntrl->total_ev_rings + 1;
> -
>  	return 0;
>  
>  error_ev_cfg:
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 742dabe..0d277c7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -309,7 +309,6 @@ struct mhi_controller_config {
>   * @total_ev_rings: Total # of event rings allocated
>   * @hw_ev_rings: Number of hardware event rings
>   * @sw_ev_rings: Number of software event rings
> - * @nr_irqs_req: Number of IRQs required to operate (optional)
>   * @nr_irqs: Number of IRQ allocated by bus master (required)
>   * @family_number: MHI controller family number
>   * @device_number: MHI controller device number
> @@ -389,7 +388,6 @@ struct mhi_controller {
>  	u32 total_ev_rings;
>  	u32 hw_ev_rings;
>  	u32 sw_ev_rings;
> -	u32 nr_irqs_req;
>  	u32 nr_irqs;
>  	u32 family_number;
>  	u32 device_number;
> -- 
> 2.7.4
>
Manivannan Sadhasivam Sept. 21, 2020, 3:40 p.m. UTC | #2
On Mon, Sep 21, 2020 at 09:36:59AM +0200, Loic Poulain wrote:
> nr_irqs_req is unused in MHI stack.
> 
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

Applied to mhi-next!

Thanks,
Mani

> ---
>  v2: add this patch to the series
> 
>  drivers/bus/mhi/core/init.c | 3 ---
>  include/linux/mhi.h         | 2 --
>  2 files changed, 5 deletions(-)
> 
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index 31961af..8798deb 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -643,9 +643,6 @@ static int parse_ev_cfg(struct mhi_controller *mhi_cntrl,
>  		mhi_event++;
>  	}
>  
> -	/* We need IRQ for each event ring + additional one for BHI */
> -	mhi_cntrl->nr_irqs_req = mhi_cntrl->total_ev_rings + 1;
> -
>  	return 0;
>  
>  error_ev_cfg:
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 742dabe..0d277c7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -309,7 +309,6 @@ struct mhi_controller_config {
>   * @total_ev_rings: Total # of event rings allocated
>   * @hw_ev_rings: Number of hardware event rings
>   * @sw_ev_rings: Number of software event rings
> - * @nr_irqs_req: Number of IRQs required to operate (optional)
>   * @nr_irqs: Number of IRQ allocated by bus master (required)
>   * @family_number: MHI controller family number
>   * @device_number: MHI controller device number
> @@ -389,7 +388,6 @@ struct mhi_controller {
>  	u32 total_ev_rings;
>  	u32 hw_ev_rings;
>  	u32 sw_ev_rings;
> -	u32 nr_irqs_req;
>  	u32 nr_irqs;
>  	u32 family_number;
>  	u32 device_number;
> -- 
> 2.7.4
>
diff mbox series

Patch

diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index 31961af..8798deb 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -643,9 +643,6 @@  static int parse_ev_cfg(struct mhi_controller *mhi_cntrl,
 		mhi_event++;
 	}
 
-	/* We need IRQ for each event ring + additional one for BHI */
-	mhi_cntrl->nr_irqs_req = mhi_cntrl->total_ev_rings + 1;
-
 	return 0;
 
 error_ev_cfg:
diff --git a/include/linux/mhi.h b/include/linux/mhi.h
index 742dabe..0d277c7 100644
--- a/include/linux/mhi.h
+++ b/include/linux/mhi.h
@@ -309,7 +309,6 @@  struct mhi_controller_config {
  * @total_ev_rings: Total # of event rings allocated
  * @hw_ev_rings: Number of hardware event rings
  * @sw_ev_rings: Number of software event rings
- * @nr_irqs_req: Number of IRQs required to operate (optional)
  * @nr_irqs: Number of IRQ allocated by bus master (required)
  * @family_number: MHI controller family number
  * @device_number: MHI controller device number
@@ -389,7 +388,6 @@  struct mhi_controller {
 	u32 total_ev_rings;
 	u32 hw_ev_rings;
 	u32 sw_ev_rings;
-	u32 nr_irqs_req;
 	u32 nr_irqs;
 	u32 family_number;
 	u32 device_number;