| Message ID | 1644494255-6632-5-git-send-email-quic_sbillaka@quicinc.com |
|---|---|
| State | Accepted |
| Commit | a874aba8bbc529517ed154d88b08e3c437564c88 |
| Headers | show |
| Series | Add support for the eDP panel on sc7280 CRD | expand |
Hi, On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti <quic_sbillaka@quicinc.com> wrote: > > Add support for the 14" sharp,lq140m1jw46 eDP panel. > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > --- > 00 ff ff ff ff ff ff 00 4d 10 23 15 00 00 00 00 > 35 1e 01 04 a5 1f 11 78 07 de 50 a3 54 4c 99 26 > 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 5a 87 80 a0 70 38 4d 40 30 20 > 35 00 35 ae 10 00 00 18 65 38 80 a0 70 38 4d 40 > 30 20 35 00 35 ae 10 00 00 18 00 00 00 fd 00 30 > 90 a7 a7 23 01 00 00 00 00 00 00 00 00 00 00 fc > 00 4c 51 31 34 30 4d 31 4a 57 34 39 0a 20 00 77 > > ---------------- > > Block 0, Base EDID: > EDID Structure Version & Revision: 1.4 > Vendor & Product Identification: > Manufacturer: SHP > Model: 5411 > Made in: week 53 of 2020 > Basic Display Parameters & Features: > Digital display > Bits per primary color channel: 8 > DisplayPort interface > Maximum image size: 31 cm x 17 cm > Gamma: 2.20 > Supported color formats: RGB 4:4:4 > Default (sRGB) color space is primary color space > First detailed timing includes the native pixel format and preferred refresh rate > Display is continuous frequency > Color Characteristics: > Red : 0.6396, 0.3291 > Green: 0.2998, 0.5996 > Blue : 0.1494, 0.0595 > White: 0.3125, 0.3281 > Established Timings I & II: none > Standard Timings: none > Detailed Timing Descriptors: > DTD 1: 1920x1080 143.981 Hz 16:9 166.587 kHz 346.500 MHz (309 mm x 174 mm) > Hfront 48 Hsync 32 Hback 80 Hpol N > Vfront 3 Vsync 5 Vback 69 Vpol N > DTD 2: 1920x1080 59.990 Hz 16:9 69.409 kHz 144.370 MHz (309 mm x 174 mm) > Hfront 48 Hsync 32 Hback 80 Hpol N > Vfront 3 Vsync 5 Vback 69 Vpol N > Display Range Limits: > Monitor ranges (Bare Limits): 48-144 Hz V, 167-167 kHz H, max dotclock 350 MHz > Display Product Name: 'LQ140M1JW49' > Checksum: 0x77 > > Changes in v4: > -Add all modes from EDID > -Provide EDID blob > > Changes in v3: > None > > drivers/gpu/drm/panel/panel-edp.c | 44 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) We want to be moving to the generic edp-panel but even if we move to edp-panel there's no harm in supporting things the old way, especially as people are transitioning. Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hi, On Wed, Feb 16, 2022 at 11:29 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti > <quic_sbillaka@quicinc.com> wrote: > > > > Add support for the 14" sharp,lq140m1jw46 eDP panel. > > > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > > --- > > 00 ff ff ff ff ff ff 00 4d 10 23 15 00 00 00 00 > > 35 1e 01 04 a5 1f 11 78 07 de 50 a3 54 4c 99 26 > > 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > > 01 01 01 01 01 01 5a 87 80 a0 70 38 4d 40 30 20 > > 35 00 35 ae 10 00 00 18 65 38 80 a0 70 38 4d 40 > > 30 20 35 00 35 ae 10 00 00 18 00 00 00 fd 00 30 > > 90 a7 a7 23 01 00 00 00 00 00 00 00 00 00 00 fc > > 00 4c 51 31 34 30 4d 31 4a 57 34 39 0a 20 00 77 > > > > ---------------- > > > > Block 0, Base EDID: > > EDID Structure Version & Revision: 1.4 > > Vendor & Product Identification: > > Manufacturer: SHP > > Model: 5411 > > Made in: week 53 of 2020 > > Basic Display Parameters & Features: > > Digital display > > Bits per primary color channel: 8 > > DisplayPort interface > > Maximum image size: 31 cm x 17 cm > > Gamma: 2.20 > > Supported color formats: RGB 4:4:4 > > Default (sRGB) color space is primary color space > > First detailed timing includes the native pixel format and preferred refresh rate > > Display is continuous frequency > > Color Characteristics: > > Red : 0.6396, 0.3291 > > Green: 0.2998, 0.5996 > > Blue : 0.1494, 0.0595 > > White: 0.3125, 0.3281 > > Established Timings I & II: none > > Standard Timings: none > > Detailed Timing Descriptors: > > DTD 1: 1920x1080 143.981 Hz 16:9 166.587 kHz 346.500 MHz (309 mm x 174 mm) > > Hfront 48 Hsync 32 Hback 80 Hpol N > > Vfront 3 Vsync 5 Vback 69 Vpol N > > DTD 2: 1920x1080 59.990 Hz 16:9 69.409 kHz 144.370 MHz (309 mm x 174 mm) > > Hfront 48 Hsync 32 Hback 80 Hpol N > > Vfront 3 Vsync 5 Vback 69 Vpol N > > Display Range Limits: > > Monitor ranges (Bare Limits): 48-144 Hz V, 167-167 kHz H, max dotclock 350 MHz > > Display Product Name: 'LQ140M1JW49' > > Checksum: 0x77 > > > > Changes in v4: > > -Add all modes from EDID > > -Provide EDID blob > > > > Changes in v3: > > None > > > > drivers/gpu/drm/panel/panel-edp.c | 44 +++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > We want to be moving to the generic edp-panel but even if we move to > edp-panel there's no harm in supporting things the old way, especially > as people are transitioning. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> ...and pushed to drm-misc-next: a874aba8bbc5 drm/panel-edp: Add eDP sharp panel support So v5 shouldn't include this patch. -Doug
diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index a394a15..f9355b2 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1605,6 +1605,47 @@ static const struct panel_desc sharp_lq123p1jx31 = { }, }; +static const struct drm_display_mode sharp_lq140m1jw46_mode[] = { + { + .clock = 346500, + .hdisplay = 1920, + .hsync_start = 1920 + 48, + .hsync_end = 1920 + 48 + 32, + .htotal = 1920 + 48 + 32 + 80, + .vdisplay = 1080, + .vsync_start = 1080 + 3, + .vsync_end = 1080 + 3 + 5, + .vtotal = 1080 + 3 + 5 + 69, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, + }, { + .clock = 144370, + .hdisplay = 1920, + .hsync_start = 1920 + 48, + .hsync_end = 1920 + 48 + 32, + .htotal = 1920 + 48 + 32 + 80, + .vdisplay = 1080, + .vsync_start = 1080 + 3, + .vsync_end = 1080 + 3 + 5, + .vtotal = 1080 + 3 + 5 + 69, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, + }, +}; + +static const struct panel_desc sharp_lq140m1jw46 = { + .modes = sharp_lq140m1jw46_mode, + .num_modes = ARRAY_SIZE(sharp_lq140m1jw46_mode), + .bpc = 8, + .size = { + .width = 309, + .height = 174, + }, + .delay = { + .hpd_absent = 80, + .enable = 50, + .unprepare = 500, + }, +}; + static const struct drm_display_mode starry_kr122ea0sra_mode = { .clock = 147000, .hdisplay = 1920, @@ -1719,6 +1760,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "sharp,lq123p1jx31", .data = &sharp_lq123p1jx31, }, { + .compatible = "sharp,lq140m1jw46", + .data = &sharp_lq140m1jw46, + }, { .compatible = "starry,kr122ea0sra", .data = &starry_kr122ea0sra, }, {
Add support for the 14" sharp,lq140m1jw46 eDP panel. Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> --- 00 ff ff ff ff ff ff 00 4d 10 23 15 00 00 00 00 35 1e 01 04 a5 1f 11 78 07 de 50 a3 54 4c 99 26 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 5a 87 80 a0 70 38 4d 40 30 20 35 00 35 ae 10 00 00 18 65 38 80 a0 70 38 4d 40 30 20 35 00 35 ae 10 00 00 18 00 00 00 fd 00 30 90 a7 a7 23 01 00 00 00 00 00 00 00 00 00 00 fc 00 4c 51 31 34 30 4d 31 4a 57 34 39 0a 20 00 77 ---------------- Block 0, Base EDID: EDID Structure Version & Revision: 1.4 Vendor & Product Identification: Manufacturer: SHP Model: 5411 Made in: week 53 of 2020 Basic Display Parameters & Features: Digital display Bits per primary color channel: 8 DisplayPort interface Maximum image size: 31 cm x 17 cm Gamma: 2.20 Supported color formats: RGB 4:4:4 Default (sRGB) color space is primary color space First detailed timing includes the native pixel format and preferred refresh rate Display is continuous frequency Color Characteristics: Red : 0.6396, 0.3291 Green: 0.2998, 0.5996 Blue : 0.1494, 0.0595 White: 0.3125, 0.3281 Established Timings I & II: none Standard Timings: none Detailed Timing Descriptors: DTD 1: 1920x1080 143.981 Hz 16:9 166.587 kHz 346.500 MHz (309 mm x 174 mm) Hfront 48 Hsync 32 Hback 80 Hpol N Vfront 3 Vsync 5 Vback 69 Vpol N DTD 2: 1920x1080 59.990 Hz 16:9 69.409 kHz 144.370 MHz (309 mm x 174 mm) Hfront 48 Hsync 32 Hback 80 Hpol N Vfront 3 Vsync 5 Vback 69 Vpol N Display Range Limits: Monitor ranges (Bare Limits): 48-144 Hz V, 167-167 kHz H, max dotclock 350 MHz Display Product Name: 'LQ140M1JW49' Checksum: 0x77 Changes in v4: -Add all modes from EDID -Provide EDID blob Changes in v3: None drivers/gpu/drm/panel/panel-edp.c | 44 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)