| Message ID | 1671721502-16587-11-git-send-email-quic_vpolimer@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show
Return-Path: <linux-arm-msm-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
by smtp.lore.kernel.org (Postfix) with ESMTP id BE659C4167B
for <linux-arm-msm@archiver.kernel.org>;
Thu, 22 Dec 2022 15:06:55 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S235876AbiLVPGx (ORCPT
<rfc822;linux-arm-msm@archiver.kernel.org>);
Thu, 22 Dec 2022 10:06:53 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52730 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S235904AbiLVPGh (ORCPT
<rfc822;linux-arm-msm@vger.kernel.org>);
Thu, 22 Dec 2022 10:06:37 -0500
Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com
[205.220.168.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE0702937A;
Thu, 22 Dec 2022 07:06:19 -0800 (PST)
Received: from pps.filterd (m0279865.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
2BM6K55r030248;
Thu, 22 Dec 2022 15:06:16 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-type; s=qcppdkim1;
bh=wmp7CCwDZbHLp4upLiJkXlzPqTD52jGYSTMZYsRLRIQ=;
b=U1nomIwVwb35CNFBdZIzKP96dvHL4OunnEH0DNIdCLj9inDDDrUiSsrfwnpOUMIQdKIm
1BK63ZeS2pbSBtLUaKUzTPY6Dh+AvfmokOji+YeFPCbJYKpLDWIv6f31V4gK++IdqoUd
pU62FBHPOMtMzR1MK+0WsdvqgqBGexCCi+e4vSLetDBR86KEzgHXwspDqNKT8wJl4GLr
YnAIWQb7pbXnDn5KgHfEVeTGcvh2c9Ll9ZHXTyq99CJpvaSk4oDJKs9xYHNjD+50hVrl
8HIZheC5x+WTrnEfUHxHXYvT8m8EDLYzD3vgK7HETyp0wDhTi0PDobGQOl1tsT5i7RZ7 jA==
Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com
[129.46.96.20])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mm4xktmf3-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Thu, 22 Dec 2022 15:06:15 +0000
Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com
[10.47.209.197])
by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
2BMF6FRp015401
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Thu, 22 Dec 2022 15:06:15 GMT
Received: from vpolimer-linux.qualcomm.com (10.80.80.8) by
nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.986.36; Thu, 22 Dec 2022 07:06:10 -0800
From: Vinod Polimera <quic_vpolimer@quicinc.com>
To: <dri-devel@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>,
<freedreno@lists.freedesktop.org>, <devicetree@vger.kernel.org>
CC: Vinod Polimera <quic_vpolimer@quicinc.com>,
<linux-kernel@vger.kernel.org>, <robdclark@gmail.com>,
<dianders@chromium.org>, <swboyd@chromium.org>,
<quic_kalyant@quicinc.com>, <dmitry.baryshkov@linaro.org>,
<quic_khsieh@quicinc.com>, <quic_vproddut@quicinc.com>,
<quic_bjorande@quicinc.com>, <quic_abhinavk@quicinc.com>,
<quic_sbillaka@quicinc.com>
Subject: [PATCH v10 10/15] drm/msm/disp/dpu: check for crtc enable rather than
crtc active to release shared resources
Date: Thu, 22 Dec 2022 20:34:57 +0530
Message-ID: <1671721502-16587-11-git-send-email-quic_vpolimer@quicinc.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1671721502-16587-1-git-send-email-quic_vpolimer@quicinc.com>
References: <1671721502-16587-1-git-send-email-quic_vpolimer@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To
nalasex01b.na.qualcomm.com (10.47.209.197)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-GUID: dZSvd8UyaVLQVRSOoRG3IHRn6UokZ60b
X-Proofpoint-ORIG-GUID: dZSvd8UyaVLQVRSOoRG3IHRn6UokZ60b
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
definitions=2022-12-22_08,2022-12-22_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
malwarescore=0
impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0
priorityscore=1501 adultscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999
phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx
scancount=1 engine=8.12.0-2212070000 definitions=main-2212220131
Precedence: bulk
List-ID: <linux-arm-msm.vger.kernel.org>
X-Mailing-List: linux-arm-msm@vger.kernel.org
|
| Series |
Add PSR support for eDP
|
expand
|
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 98f38d6..f454964 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -683,7 +683,7 @@ static int dpu_encoder_virt_atomic_check( if (drm_atomic_crtc_needs_modeset(crtc_state)) { dpu_rm_release(global_state, drm_enc); - if (!crtc_state->active_changed || crtc_state->active) + if (!crtc_state->active_changed || crtc_state->enable) ret = dpu_rm_reserve(&dpu_kms->rm, global_state, drm_enc, crtc_state, topology); }
According to KMS documentation, The driver must not release any shared resources if active is set to false but enable still true. Fixes: ccc862b957c6 ("drm/msm/dpu: Fix reservation failures in modeset") Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)