From patchwork Thu Feb 7 10:49:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 157744 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp611341jaa; Thu, 7 Feb 2019 04:57:53 -0800 (PST) X-Google-Smtp-Source: AHgI3IY5Qs+eF/D9AVwLXJ1+DaZie0hXsx9JzJ3iVaxMawUsKFLLABWm2YJUADkBhDRaeGPWeel6 X-Received: by 2002:a17:902:f08b:: with SMTP id go11mr850034plb.115.1549544273660; Thu, 07 Feb 2019 04:57:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549544273; cv=none; d=google.com; s=arc-20160816; b=sIYtNokxBcM/YQ77LIAVC7uqZGbaWkYsDbejm+VFICvGZYIxEFSmsDAuMcFHhHXIMT z7zS17hTkMc9854kf76oVCy1F8Ahb9ZoAr3S0kqk9e8+egIkVv39b5+SYjv4iUN9eV91 SXI+emrT/I9JUpjmH5yzdXvjtpGJpORuQcokKEm5wkhBS+RjFPaInawUe/M3xrUF9n/0 pp+hOxwE+b9py9tjvFV2PzWpvfCc3PRQwBPOW3aiYU/+8b5KQsa2G1HrtffyTk/oHcgR MefaxGwPsv7ZRer2qnTEzsCE4yvMpGT0h6N8qQaUOMo1wAK+TbpvisdKykHI5STkcaca Q5YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=slw/UtLaWTHjBrLevWPKmekxiAZPQmP5V+PGuEPSwwr9w+r2msEys5urDGNJrBPMci na6mEiWBCD3r+myxVRLR2a3Pgcq6LvoDwKMnK7WKCB3+M7mixjkVkAOBM2TsS2Us8Ivx sUz9t2kvx1qvaS9k8WWACK44u10z2twgU9xKcIwaWwQ40jqVsAYc68N+4YN/f2/t3bDK OQg3SMosw0yg4YKuZs1YdLK9pLEwvg3UeLbLERSihRYPioPRmXQVIkPpfm2Fuja+GLd1 AI/nhkY+KHKLfQw2BzTPsQhFV9mO1qkbvuP5fgHMnMecpfNjCraPnipEJidf0Oj7bJ1L 9rZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dxv12iw1; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si8861124pge.384.2019.02.07.04.57.53; Thu, 07 Feb 2019 04:57:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dxv12iw1; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727049AbfBGM5w (ORCPT + 15 others); Thu, 7 Feb 2019 07:57:52 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44129 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727003AbfBGM5w (ORCPT ); Thu, 7 Feb 2019 07:57:52 -0500 Received: by mail-pg1-f194.google.com with SMTP id y1so4443114pgk.11 for ; Thu, 07 Feb 2019 04:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=Dxv12iw1540JjbRcyK2umnt9oXCAqkHsByXWPmEn1LVFPu2+B21yLM0K1sJznok8QQ EWxZg0ZAdBmuGcfmVux11ZIjQrnIMCBbCz4CMNGT2ftRiZnvJSsfs35IkSV1JLliz6+W cFom0VgHRXbl/oPGwYJyoTlgRctZJk6yqRUj117llYHYZBcTX9xrf1c8GOBwcyx9HLLt +g1qsVZUGcmkkLzNp9Rp/6bWwu9Nrz1gH12O7qGOeXSs46kOBlzJCfIIiC+VAP/giUvh t4y94WWhhp/KiGr1/QwVtcZ4HtcISy3hMBu3HGtT3+dQthfe/e9U6Srobab0cdFsXFcG fwRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=fCYl6vvW+YZYnifjiw2QLN/bEtXGMGhfGq45ZwUxt+fdVZZgbbHMC4zHCyXhaUnPxw YBUAHRpLRHLast3sUgss0CJLe5qxVQhkNsqinyVyAQ/O5pE0BsDy8XTxSuG7I3ce+FlY ucrDCKK2+RzXl1YkFcA1xliHVmnF8ozgrODVWt/0rkIQp6GSiC66CJWQTnG2/vq69WX0 7+TjY3Kcelyqdm/Tpbi6nw6IZfvJJAO5xEDehCXfb6euJl8i9/3xcKVCeTruWLBh8ejS Yt6qx1XxXZwOEcwFgrMGcXfS8woXkSeJVw8MYyhfCW5Pl08Te5fkQID93gp22W2tjXuH z7Yg== X-Gm-Message-State: AHQUAuaPJQrfFBPN/9VCGj7OvLbxRQlNOcxYJxLsu0flTFA0X/K5F2LA 44qNB0F2z9TzcUMuJYLK4TtRyw== X-Received: by 2002:a63:a55:: with SMTP id z21mr14775670pgk.401.1549544271802; Thu, 07 Feb 2019 04:57:51 -0800 (PST) Received: from localhost ([2402:3a80:c80:4138:75dd:3900:1d90:762f]) by smtp.gmail.com with ESMTPSA id n14sm3714273pgd.48.2019.02.07.04.57.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Feb 2019 04:57:51 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, andy.gross@linaro.org, Daniel Lezcano , David Brown , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v1 06/24] drivers: thermal: tsens: Function prototypes should have argument names Date: Thu, 7 Feb 2019 16:19:24 +0530 Message-Id: <1ff476080e60beab71905ef39f2f703c52ae92f9.1549525708.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org check_patch complains a lot as follows: WARNING: function definition argument 'struct tsens_priv *' should also have an identifier name + int (*init)(struct tsens_priv *); Fix it. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.17.1 diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h index 61ca2905ee7a..4d6a406f8dca 100644 --- a/drivers/thermal/qcom/tsens.h +++ b/drivers/thermal/qcom/tsens.h @@ -47,15 +47,15 @@ struct tsens_sensor { */ struct tsens_ops { /* mandatory callbacks */ - int (*init)(struct tsens_priv *); - int (*calibrate)(struct tsens_priv *); - int (*get_temp)(struct tsens_priv *, int, int *); + int (*init)(struct tsens_priv *priv); + int (*calibrate)(struct tsens_priv *priv); + int (*get_temp)(struct tsens_priv *priv, int i, int *temp); /* optional callbacks */ - int (*enable)(struct tsens_priv *, int); - void (*disable)(struct tsens_priv *); - int (*suspend)(struct tsens_priv *); - int (*resume)(struct tsens_priv *); - int (*get_trend)(struct tsens_priv *, int, enum thermal_trend *); + int (*enable)(struct tsens_priv *priv, int i); + void (*disable)(struct tsens_priv *priv); + int (*suspend)(struct tsens_priv *priv); + int (*resume)(struct tsens_priv *priv); + int (*get_trend)(struct tsens_priv *priv, int i, enum thermal_trend *trend); }; enum reg_list { @@ -111,10 +111,10 @@ struct tsens_priv { struct tsens_sensor sensor[0]; }; -char *qfprom_read(struct device *, const char *); -void compute_intercept_slope(struct tsens_priv *, u32 *, u32 *, u32); -int init_common(struct tsens_priv *); -int get_temp_common(struct tsens_priv *, int, int *); +char *qfprom_read(struct device *dev, const char *cname); +void compute_intercept_slope(struct tsens_priv *priv, u32 *pt1, u32 *pt2, u32 mode); +int init_common(struct tsens_priv *priv); +int get_temp_common(struct tsens_priv *priv, int i, int *temp); /* TSENS v1 targets */ extern const struct tsens_plat_data data_8916, data_8974, data_8960;