From patchwork Sat Jun 29 12:59:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 168152 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp722053ilk; Sat, 29 Jun 2019 06:02:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzShUnknQ9AmVEVjD6rsIPr3LdEkPn4IH392faj4f4otid9go8k8ZL+8tIYN7M8wI1qW9a5 X-Received: by 2002:a17:902:e011:: with SMTP id ca17mr17941745plb.328.1561813331210; Sat, 29 Jun 2019 06:02:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561813331; cv=none; d=google.com; s=arc-20160816; b=mnQSSEn27Lqv6xk/ME85JlclI1OZ1LjjkYlBWUWCmxwWP3m5wtH9wVXqTvFnA0GMb7 kCA2vfw3uUN5l/YPw6NQL9Ltp8fH/piLoPD/25Xnysk31ew6BeWEWMc/FEuSIgJI9Tfe J5hHzyaPNZhJXcGyH7hX/zWe8CKFtkrqJp1aW6+7bzPtTx1lyiWuS8L54DqHn3EwMPwv Ug1+XALG3vY1tsMSxbRf2ARJ4+NQyVd6q00J/VEot+dcIfSLjBj7V9uTA0zIIegcSiIR awSoMfILj1KBn5ADKzTAa8XyUAX45wtcDFt5bmIPBQwod06xiAR3e7xYyCsInhgtpqWc q9Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gUhHBzqpeqf9laCyRDqe0YTreYPsBAWIdDU1MBCLr1k=; b=l0he1movzHNypti+RG9e2bRvK6jjfCv6lnAuQu1TlCAX9fesS5qb1sNG9ngad16aw7 VodPzFnXmTX9CNvHFTF/u6TBaFXt9pvLHQ1i9BjjYwdz0ye7woj0wFROorsQmeWl5hbU 70atLgB4UTlwLjcSxs6U0DOUDjxkIHILhAdI/nJYT/UwJvBaMu/Bh/5EydPbIQaUrlZ3 eyR5Qqlul9Oi9/txAwnuZ2aRU5YQ+DbXCH3d9NWDSwxWCwXcPa5XpCQcw/+dCnz/O5QV Ja/zTi6IrH585XNYToTgINtgUEWMocEUfcm9XctZJZTRtEVL7QsqWAFSDi8cWWXhy+r7 hphA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BYavBGMB; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j16si4972636pff.262.2019.06.29.06.02.10; Sat, 29 Jun 2019 06:02:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BYavBGMB; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726828AbfF2NCK (ORCPT + 15 others); Sat, 29 Jun 2019 09:02:10 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:44820 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726716AbfF2NCK (ORCPT ); Sat, 29 Jun 2019 09:02:10 -0400 Received: by mail-lf1-f67.google.com with SMTP id r15so5731068lfm.11 for ; Sat, 29 Jun 2019 06:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gUhHBzqpeqf9laCyRDqe0YTreYPsBAWIdDU1MBCLr1k=; b=BYavBGMBtik6r+A9tFdwUyOfHqHK+Yl4c7/OJSbz75XF2NUDjc4Jw7+6wvc3ssAnDF 9sq25tD60Ch3GCG0hM/5PRkqSgHcW/LYOm35ZiNdaPczwua7xlkaQTtJrqZOM9Tpv2HK ZvXChwFa1/VVDUg/f4Nyh3tUquPVnrg2zNpac70vRhAUi7CZ8hpGVSeRuy+q36Hhso+h Ks17fIaZ1Z+66/HbPp9dwbic5x4vw3gyVfV98DTntLs57UNkVYUKwuust+xKTjaLKoct 7zQUCFkufCWR85bg3HzsRWlJ42Nostw2IEcGdvH3kk5vn0kj3ZdmlMrn0Ij8qrwefETN THcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gUhHBzqpeqf9laCyRDqe0YTreYPsBAWIdDU1MBCLr1k=; b=VV0oUPx/AZC26+xD4NYEu9FL2n2WmaWzXQF1LgeofbxRNYALPhHINNHoF4r7Lz4VWq FJ202iCN7cyUsQB6KiLtJY2vy4+1wQL42I3A4xeploC22fRSrAzRP4+Fwpum1vJAXuP5 9rHC+RCqWxPo6aj98Pw6M1i/PIc1KYl/W336MnL+8X15uNheElQAo+OIi2PlCUyFRnYN brssdz3a7Hw7PwojJ16FG23aMQ9QX5sZ1fTQG0lwjWB7xAD5w+ZGnpjX2lddmH7Cyx1f RwXEt4eTNgt596ZWgCqpeMXXWA3HUQLIP5ayhK/qbZMNXrEyp451sT6ogZTR1KOSetku Xecg== X-Gm-Message-State: APjAAAX4AGRLe7/xi6eU6Soxnixr2/niO5reTn6OhLAB3bojsDMsMuzb tGSgPcOUd/fV5aLBJOJTGsz7Yw== X-Received: by 2002:ac2:4891:: with SMTP id x17mr7657045lfc.60.1561813328311; Sat, 29 Jun 2019 06:02:08 -0700 (PDT) Received: from localhost.localdomain (c-22cd225c.014-348-6c756e10.bbcust.telenor.se. [92.34.205.34]) by smtp.gmail.com with ESMTPSA id v2sm1354500lfi.52.2019.06.29.06.02.07 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 29 Jun 2019 06:02:07 -0700 (PDT) From: Linus Walleij To: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul Cc: linux-arm-kernel@lists.infradead.org, Linus Walleij , Rob Clark , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH 7/7] RFT: drm/msm/hdmi: Do not initialize HPD line value Date: Sat, 29 Jun 2019 14:59:33 +0200 Message-Id: <20190629125933.679-7-linus.walleij@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190629125933.679-1-linus.walleij@linaro.org> References: <20190629125933.679-1-linus.walleij@linaro.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org After untangling the MSM HDMI GPIO code we see that the code is deliberately setting the output value of the HPD (hot plug detect) line to high, even though it is being used as input which is of course the only viable use of a HPD pin. This seems dubious: GPIO lines set up as input will have high impedance (tristate) and the typical electronic construction involves this line being used with a pull-down resistor around 10KOhm to keep it low (this is sometimes part of a levelshifter component) and then an inserted connector will pull it up to VDD and this asserts the HPD signal, as can be seen from the code reading the HPD GPIO. Stop try driving a value to the HPD input GPIO. Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-msm@vger.kernel.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c index 89c64cc85027..ecbcd8638b66 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c @@ -87,7 +87,7 @@ static int gpio_config(struct hdmi *hdmi, bool on) struct hdmi_gpio_data gpio = config->gpios[i]; /* The value indicates the value for turning things on */ - if (gpio.gpiod) + if (gpio.gpiod && gpio.output) gpiod_set_value_cansleep(gpio.gpiod, gpio.value); }