From patchwork Fri Jul 26 11:27:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 169817 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp12909107ilk; Fri, 26 Jul 2019 04:27:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhsdrQFxR37cfO0XFotmUxzjSZuLv+hZLX6ZV8kTaUZXZRLvYc/UTV4JhCP1rSwRxklPN6 X-Received: by 2002:a63:20d:: with SMTP id 13mr80079877pgc.253.1564140478571; Fri, 26 Jul 2019 04:27:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140478; cv=none; d=google.com; s=arc-20160816; b=tEgX56tipl7HTaoWG4U0ZAWFTeGjQM9tTYtYHElNMQ8tFnEtfONwoj9VR3M3SyRuur IbPql0wB+PHYYyaaFkZuds1P60CV9bOB39CTwDcOq2isli9AFe23zpZcU8f6kieh201m bB2rToMYlUDNG5+6OSqZL87CExSdjSA8CFZR/lASONmJbE9MECmPLpkNCm90RThDMFZQ ntq5J4KU6ygQzXUzE4gysCrST9caZVeXM+vAkooQAQ+4P7AJzs9kDYEy8hUMcncaaYvD +NmtFfGAC3ayffFLot8XE6qk6PTMYNajBXRT5vQhb9dgNJMokiK8pZDcCHO8N6M1rZ6Y KorA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mhZxThgFyoxuQkXVr0Rs3Bv05HhD+nUqY4oSH8BKepE=; b=o3UhTS2Fa7p3jVaMbSg86DcuzrYDG290HyX9tlv8QcQjbkMIVY1si4wQkMwLRfY2Hu FzYkGXVGtatqUg+uIc8jYcBpIS4/XZjOKphv7Kg4KGu0VDn8vob/cT0jjjEm7EUx4OjW +0cxGvFxBfBxxFkxniy779RYYcb4m++3sShbCzCDcTkXmqoGhVrMXVDbmGd5GvZ+Noj/ 2mg1pWCl1vjw1NIrORFk4S98fcCqnEUWTZSakh44ouHiJkFb3twVGwp8iAK2TsjGe7dj 3WA8oBTvvjnQqUGilMyBmZkXQFZvNqHgXHzKEi0YCCqXzuvb8n8I6ERF+V7lLdSd76Lg 4elw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SjTC7eCV; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y193si19708860pgd.108.2019.07.26.04.27.58; Fri, 26 Jul 2019 04:27:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SjTC7eCV; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbfGZL15 (ORCPT + 15 others); Fri, 26 Jul 2019 07:27:57 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:43574 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbfGZL15 (ORCPT ); Fri, 26 Jul 2019 07:27:57 -0400 Received: by mail-lf1-f65.google.com with SMTP id c19so36843809lfm.10 for ; Fri, 26 Jul 2019 04:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mhZxThgFyoxuQkXVr0Rs3Bv05HhD+nUqY4oSH8BKepE=; b=SjTC7eCVIgTYtXnx7wObMb0ka5YstKwcZt/k/di80kRHdujbyS/FGyHfIdL0+e5y5E lqNmDrIWjd3F9+9qNIu4+G/nKrBArgVH4eRkpSgNjIXUQQL7OqX6HUs2x1Ml+I+sZnno pX9ipCGgGEy+PzZxblaZr+5iGjAtNujUqzId+cjtqMooZh4FFYyb3Mqp8+wyp89GbEc8 S/X/V6xNLx+1QVsSv3+xGI8bHqkzYa+wYLHyJNbhHBQ8AwbrpN4BRpYeHEoZPCiCftxX vPR8yGPV9CnGyRSDMW7ctHuhGVRHFFfSE8q8D8pC8txmN0jZ2KdSIq5gvMjpAZvoSEQE FuIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mhZxThgFyoxuQkXVr0Rs3Bv05HhD+nUqY4oSH8BKepE=; b=g/1nbmJrHMaayES4YvFZIHbc+K+tEXPVMMdn+duFA6Xs8pCgfii4Mk2qXmEUQvWn55 Omh3AtcrUvLF11F5q1AikBlGs4iT3G2OAXC+t0RMazM5wDjCoxLU24woSBnZEEG33EPS SIDxndf/yUv3DH8fIko8IpLtR60eRoljmDFXfj0B7g/1TKixZNHvgwnJAkHya6j05ksf DRG5QUHL5yv+MoCRr8vfjrJiv+Huu6JW29I81SFtlGASTaeq8C8csnUkJnDpCfHZFNTa 5QJ3OdD5tWEk36lb6o3R8IpaqPJCE/IoABfbBzhOAFI4Ox0y4DF2GJpdnStF+VfUS+tM SeCQ== X-Gm-Message-State: APjAAAUh4d/nZTMPEh7zNNFJ+42CXRxZ6qbM68ecQ9I0hqs5Nx5jlO1M 6KiHKg01Z2ro9S4bMNU1ZMwi3g== X-Received: by 2002:a19:6557:: with SMTP id c23mr2265309lfj.12.1564140475478; Fri, 26 Jul 2019 04:27:55 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id l22sm9911343ljc.4.2019.07.26.04.27.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:27:54 -0700 (PDT) From: Anders Roxell To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH 2/3] drm: msm: a5xx: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:27:51 +0200 Message-Id: <20190726112751.19461-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c: In function ‘a5xx_submit’: ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:150:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (priv->lastctx == ctx) ^ ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:152:3: note: here case MSM_SUBMIT_CMD_BUF: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1 diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c index 1671db47aa57..71397ed3c99f 100644 --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c @@ -59,6 +59,7 @@ static void a5xx_submit_in_rb(struct msm_gpu *gpu, struct msm_gem_submit *submit case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: if (priv->lastctx == ctx) break; + /* Fall through */ case MSM_SUBMIT_CMD_BUF: /* copy commands into RB: */ obj = submit->bos[submit->cmd[i].idx].obj; @@ -149,6 +150,7 @@ static void a5xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit, case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: if (priv->lastctx == ctx) break; + /* Fall through */ case MSM_SUBMIT_CMD_BUF: OUT_PKT7(ring, CP_INDIRECT_BUFFER_PFE, 3); OUT_RING(ring, lower_32_bits(submit->cmd[i].iova));