From patchwork Thu Feb 20 09:58:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 190285 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A17B3C11D04 for ; Thu, 20 Feb 2020 10:00:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71FB424681 for ; Thu, 20 Feb 2020 10:00:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YL4hhtPu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727954AbgBTKAK (ORCPT ); Thu, 20 Feb 2020 05:00:10 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:34924 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727158AbgBTKAK (ORCPT ); Thu, 20 Feb 2020 05:00:10 -0500 Received: by mail-pg1-f194.google.com with SMTP id v23so1692913pgk.2 for ; Thu, 20 Feb 2020 02:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=STguu8hQLWj9WVWj4qpf0JO+0y2RGkENLnYzyuJ11Rs=; b=YL4hhtPuavqZ7PcvFuIq9Cw4zsOE64AqsTSZP+jvQ0zUpOYzfFU69SqfK/6oiqG0M+ j6qIaMapA0Z+g1Zd6sBqzUiwfTBGRSksAMOjO1MqAFy1i4hRM/5iTHybz6zA121kphes TFZdfLdNYsNyVYDkeBWis5LJdaFdLTghDSX5R8QUXVwGSb54YOjAmMiAivQgY9GH04Rw rPp3vFpOtaClY4Dwr4fq5hoyMdxX9ha1WRhjbs3eMGH5zlsWH+utBXWRyhWh/CaKj+aF g2KhAe9ipdtFSdRv3KbO5AVt9m8XnMmK1nVOSotyzVcZsw8emc6/EgJbcrPxobir5HXg rCGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=STguu8hQLWj9WVWj4qpf0JO+0y2RGkENLnYzyuJ11Rs=; b=A8L59hDbaOOqKOulkoKImEjMcc9Wpmuh61mueW54dZY1RRTBrIxCeB5e3HwoMACj8R 9aWyPcU0Q6otRiiG0U0bppki3CFcEUIfCoecDdi1TgcQV9rAjHAA5To3Od/A9p+w7vH5 3VWhxnn3yq4WjVozLnNJFtu5nnXago+F/5echKtXlQs1t7V9HQZI/eGeFJMfxf0EFCH/ cienHG8qS4gQ8w1aClMX+MzhYlsgEaj8u8PsNlYjRBlOLp2bZHCt1KeE4qoZPMoKehwc AiSnq/pyDtSINz9dtgOyqPL8b0dLMwuVAJ5CO3BDTXlLhkEIP4RHZ33DhdfzeKx4uJXk lovg== X-Gm-Message-State: APjAAAWYAOtUKiUYJl+QmO3jwAi5rC3xFhAChvZM+ZeO1EQZhL25p4mk SRJDec0+xBnWGLpkFf0OI+Lf X-Google-Smtp-Source: APXvYqzIhVsM1bc4+ADXxV137lBirL8qk0uEpkNeSBG5Rlzd8KBB+SS8Q6nO4UOIXVWtUSQ3l14DZw== X-Received: by 2002:a63:3688:: with SMTP id d130mr32724734pga.422.1582192809970; Thu, 20 Feb 2020 02:00:09 -0800 (PST) Received: from localhost.localdomain ([2409:4072:315:9501:edda:4222:88ae:442f]) by smtp.gmail.com with ESMTPSA id b3sm2678644pjo.30.2020.02.20.02.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 02:00:09 -0800 (PST) From: Manivannan Sadhasivam To: gregkh@linuxfoundation.org, arnd@arndb.de Cc: smohanad@codeaurora.org, jhugo@codeaurora.org, kvalo@codeaurora.org, bjorn.andersson@linaro.org, hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH v3 12/16] bus: mhi: core: Add uevent support for module autoloading Date: Thu, 20 Feb 2020 15:28:50 +0530 Message-Id: <20200220095854.4804-13-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200220095854.4804-1-manivannan.sadhasivam@linaro.org> References: <20200220095854.4804-1-manivannan.sadhasivam@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add uevent support to MHI bus so that the client drivers can be autoloaded by udev when the MHI devices gets created. The client drivers are expected to provide MODULE_DEVICE_TABLE with the MHI id_table struct so that the alias can be exported. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Jeffrey Hugo Tested-by: Jeffrey Hugo --- drivers/bus/mhi/core/init.c | 9 +++++++++ include/linux/mod_devicetable.h | 1 + scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 10 ++++++++++ 4 files changed, 23 insertions(+) diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c index 7bfffa9a5ad1..5fb756ca335e 100644 --- a/drivers/bus/mhi/core/init.c +++ b/drivers/bus/mhi/core/init.c @@ -1210,6 +1210,14 @@ void mhi_driver_unregister(struct mhi_driver *mhi_drv) } EXPORT_SYMBOL_GPL(mhi_driver_unregister); +static int mhi_uevent(struct device *dev, struct kobj_uevent_env *env) +{ + struct mhi_device *mhi_dev = to_mhi_device(dev); + + return add_uevent_var(env, "MODALIAS=" MHI_DEVICE_MODALIAS_FMT, + mhi_dev->chan_name); +} + static int mhi_match(struct device *dev, struct device_driver *drv) { struct mhi_device *mhi_dev = to_mhi_device(dev); @@ -1236,6 +1244,7 @@ struct bus_type mhi_bus_type = { .name = "mhi", .dev_name = "mhi", .match = mhi_match, + .uevent = mhi_uevent, }; static int __init mhi_init(void) diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h index be15e997fe39..f10e779a3fd0 100644 --- a/include/linux/mod_devicetable.h +++ b/include/linux/mod_devicetable.h @@ -821,6 +821,7 @@ struct wmi_device_id { const void *context; }; +#define MHI_DEVICE_MODALIAS_FMT "mhi:%s" #define MHI_NAME_SIZE 32 /** diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devicetable-offsets.c index 054405b90ba4..fe3f4a95cb21 100644 --- a/scripts/mod/devicetable-offsets.c +++ b/scripts/mod/devicetable-offsets.c @@ -231,5 +231,8 @@ int main(void) DEVID(wmi_device_id); DEVID_FIELD(wmi_device_id, guid_string); + DEVID(mhi_device_id); + DEVID_FIELD(mhi_device_id, chan); + return 0; } diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c index c91eba751804..cae6a4e471b5 100644 --- a/scripts/mod/file2alias.c +++ b/scripts/mod/file2alias.c @@ -1335,6 +1335,15 @@ static int do_wmi_entry(const char *filename, void *symval, char *alias) return 1; } +/* Looks like: mhi:S */ +static int do_mhi_entry(const char *filename, void *symval, char *alias) +{ + DEF_FIELD_ADDR(symval, mhi_device_id, chan); + sprintf(alias, MHI_DEVICE_MODALIAS_FMT, *chan); + + return 1; +} + /* Does namelen bytes of name exactly match the symbol? */ static bool sym_is(const char *name, unsigned namelen, const char *symbol) { @@ -1407,6 +1416,7 @@ static const struct devtable devtable[] = { {"typec", SIZE_typec_device_id, do_typec_entry}, {"tee", SIZE_tee_client_device_id, do_tee_entry}, {"wmi", SIZE_wmi_device_id, do_wmi_entry}, + {"mhi", SIZE_mhi_device_id, do_mhi_entry}, }; /* Create MODULE_ALIAS() statements.