diff mbox series

[1/2] arm64: dts: broadcom: remove an unused property dma-ranges

Message ID 20201013060623.1711-2-thunder.leizhen@huawei.com
State New
Headers show
Series eliminate two common errors reported by any yaml on arm64 | expand

Commit Message

Leizhen (ThunderTown) Oct. 13, 2020, 6:06 a.m. UTC
stingray-usb.dtsi is finally included by three dts files:
bcm958802a802x.dts, bcm958742k.dts and bcm958742t.dts. I searched all
these three entire expanded dts files, and each of them contains only one
dma-ranges. No conversion range is specified, so it cannot work properly.
I think this property "dma-ranges" is added by mistake, just remove it.
Otherwise, the following error will be reported when any YAML detection
is performed on arm64.

arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \
(dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \
its #address-cells (1) differs from / (2)
arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \
(dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \
its #size-cells (1) differs from / (2)

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Florian Fainelli Oct. 14, 2020, 3:12 a.m. UTC | #1
On 10/12/2020 11:06 PM, Zhen Lei wrote:
> stingray-usb.dtsi is finally included by three dts files:

> bcm958802a802x.dts, bcm958742k.dts and bcm958742t.dts. I searched all

> these three entire expanded dts files, and each of them contains only one

> dma-ranges. No conversion range is specified, so it cannot work properly.

> I think this property "dma-ranges" is added by mistake, just remove it.

> Otherwise, the following error will be reported when any YAML detection

> is performed on arm64.

> 

> arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \

> (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \

> its #address-cells (1) differs from / (2)

> arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi:7.3-14: Warning \

> (dma_ranges_format): /usb:dma-ranges: empty "dma-ranges" property but \

> its #size-cells (1) differs from / (2)

> 

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>


This looks fine to me, Scott, Ray do you want to Ack this patch before I 
take it?
-- 
Florian
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
index 55259f973b5a9e4..9ac8be6c65aa031 100644
--- a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
+++ b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
@@ -4,7 +4,6 @@ 
  */
 	usb {
 		compatible = "simple-bus";
-		dma-ranges;
 		#address-cells = <1>;
 		#size-cells = <1>;
 		ranges = <0x0 0x0 0x68500000 0x00400000>;