From patchwork Wed Dec 2 09:41:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 335953 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp777891ejs; Wed, 2 Dec 2020 01:44:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyGjkc9oidK2EfKi8cDFurzHC1nA4SLd693FVJTyICm8MCrKGKh7lEaQw4RUWB7WYTYmVR X-Received: by 2002:a17:906:c312:: with SMTP id s18mr1509302ejz.185.1606902292623; Wed, 02 Dec 2020 01:44:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606902292; cv=none; d=google.com; s=arc-20160816; b=MgiHC4ElKOtMKuRbl4NKEHcoxD9Wzq4ZQdJFzloAawOTyq6oL2Daw9iQeuvi3DabkV BOuMQlDJfAXHwdyts/VDfTZKQNvGQdhyVci46szJOfeHePtjs8Pufgrb/w6Lb+MuYzte LbQQhwfELIVibmc6VSYJUGWpYT/qd8N4zramVTD2DhPfYvl6lxiKso9W6O0c8gGC3w57 hFuVmSAp0BHvoGFvTPrK10ai6JJvzR71TDmzBZtFGcgKyq3pdN5jPvF5XrT1l97OU+y5 7wogDEhzeDso3MfddBrTrjiRYbGS6zDdxYk2w9wF6VIpujPlIj0m5waEbP17AAd5PR2A rYTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nTb4bDaGBERzc1DVzOJ+hYUZw8vd3IFev46E0aJe5pM=; b=Kslx4yeFxKZuyJ3tT6HaLlrg9Pe/yflV5iwPTbifsthI3zvoxInK90wv5rfMm5Cn/e pjEiLoOeGhQYrNpQ2auS13Ofe2jPSVfPGyHzQIwg1ziMY9qtAvEzVC/5T3BJ/7PitqZL DxEP0oLCpqqQyu+/i8bcchKrbI7k2xj/bhLmlR6UU6mAqQQubK86KjpzNRzMIyaB0+KH K8oA+R2Uc9JmC6sKAnnPWhqR4lmdJ6k0o0EDXFQe7NQ1p+L0TMkm8yhGy6nlVnk7VOCu FHOFC5Wsviw863/YWpcs8Xx0BRrclRYQ14AyTh+P4nvD5zJyfbLDI1TcgDVmR0pswXN5 uzYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k7weTbPz; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do13si531726ejc.286.2020.12.02.01.44.52; Wed, 02 Dec 2020 01:44:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k7weTbPz; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729031AbgLBJoZ (ORCPT + 15 others); Wed, 2 Dec 2020 04:44:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388374AbgLBJoY (ORCPT ); Wed, 2 Dec 2020 04:44:24 -0500 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6141C094243 for ; Wed, 2 Dec 2020 01:43:41 -0800 (PST) Received: by mail-pj1-x1041.google.com with SMTP id h7so418790pjk.1 for ; Wed, 02 Dec 2020 01:43:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nTb4bDaGBERzc1DVzOJ+hYUZw8vd3IFev46E0aJe5pM=; b=k7weTbPzd4qGAVsY0L3rLmh9fBgRionLY7FttqxE6LGukCO2max1ZCFgN9WSbe+lZG JGoOF1iLesIb/xK6tMaVEoTJBYjUfqUctyBTLDYLxxJU9vdgGbgK46NrGKvXtgm+/XJ5 n3xU45AhitmECN9KrB16z3uy3Rzn5byBI3UTZu/4BNihJiwfEKqv0mSQwcDzB1+CNm5m kYOO5Ty7F7jhmnhTRbZgWz58Eok8ejEekHBBPvMUBUFx3vT/2nyu49YPRbdlF3sopMuu lpZlGdXlWkJ6yyg9xpFnQtkvMOJ8D/9ecOdUP9Wfrc7b1PtiMrOGf3fTFQZ6qhWk+BTC TbSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nTb4bDaGBERzc1DVzOJ+hYUZw8vd3IFev46E0aJe5pM=; b=abtjXIb8rqR/5xC0QoBagaj7+2dbMakp0UuAbOJ2gXzMBksDzabRcupd4oy9Z5KOuT 1E4VgXYSKGTnFxfpHc7FGiqgjNSfDKAbnXVFFEZx+SLaPiD/ZwD1hEdYxepgyImtNmmo B7xtGuDNUE4vj1T1Tm+gGnhXuVGT3cageCTeCJQ6dhPDbLboR8e+Hn1g2xL6HLocw5Q+ rbho0SU69FvTcCtPttZEnGkpwCUF5frFWhd8QIPXAgO8Hy0lkYNfFqZmI89kf7ea6dfR /B2OOXccdA8SLUpY8XTQb0q+Zg/m0oGP0kEKnww/N22vJyPoWcEwJ2GEkOkZsoFCsKb2 Y0Sg== X-Gm-Message-State: AOAM533/PqyDEAeffAK2tTiVttSx0yB7IMSFjyumq8Qsn/YWlzuezluW FnWzh1B5WFTJJMtBPePmMGD3Oa0ZIF1A X-Received: by 2002:a17:902:469:b029:da:17d0:e755 with SMTP id 96-20020a1709020469b02900da17d0e755mr1943968ple.53.1606902221432; Wed, 02 Dec 2020 01:43:41 -0800 (PST) Received: from localhost.localdomain ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id bg8sm1393990pjb.52.2020.12.02.01.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 01:43:40 -0800 (PST) From: Manivannan Sadhasivam To: gregkh@linuxfoundation.org Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, Manivannan Sadhasivam Subject: [PATCH 19/29] bus: mhi: core: Use appropriate label in firmware load handler API Date: Wed, 2 Dec 2020 15:11:49 +0530 Message-Id: <20201202094159.107075-20-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201202094159.107075-1-manivannan.sadhasivam@linaro.org> References: <20201202094159.107075-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Bhaumik Bhatt Correct the "error_read" label to say "error_ready_state" as that is the appropriate usage of the label. Signed-off-by: Bhaumik Bhatt Reviewed-by: Manivannan Sadhasivam Signed-off-by: Manivannan Sadhasivam --- drivers/bus/mhi/core/boot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c index 7b57bb9a3080..c2546bf229fb 100644 --- a/drivers/bus/mhi/core/boot.c +++ b/drivers/bus/mhi/core/boot.c @@ -497,7 +497,7 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl) if (ret) { dev_err(dev, "MHI did not enter READY state\n"); - goto error_read; + goto error_ready_state; } /* Wait for the SBL event */ @@ -508,7 +508,7 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl) if (!ret || MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state)) { dev_err(dev, "MHI did not enter SBL\n"); - goto error_read; + goto error_ready_state; } /* Start full firmware image download */ @@ -524,7 +524,7 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl) return; -error_read: +error_ready_state: mhi_free_bhie_table(mhi_cntrl, mhi_cntrl->fbc_image); mhi_cntrl->fbc_image = NULL;