From patchwork Wed Feb 17 11:21:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Foss X-Patchwork-Id: 383799 Delivered-To: patch@linaro.org Received: by 2002:a02:c80e:0:0:0:0:0 with SMTP id p14csp2716470jao; Wed, 17 Feb 2021 03:25:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9oX+ieGq2gawlf4bcG6ymSuHD707ECSMN4Sp+lYNjSDLP69fzSakq8zZiS5sEqRMr/xl+ X-Received: by 2002:a17:906:503:: with SMTP id j3mr24906873eja.172.1613561148274; Wed, 17 Feb 2021 03:25:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613561148; cv=none; d=google.com; s=arc-20160816; b=do3wfAxhtw++tj8/0VbfYvOlpU2W16rWxbMHq8bprUf/Wk+AHV24VMXizlnPVIm/5e flR0sURMFtyheYvEkDBRD8pTi/v0VGrVTUF5ZFWTI0HJ9tea15pVagS5r9eE5mRx/c2/ XY4qx1gTXunjj9UnT8PZ84xwhF+2UlfVY5gM9ed2ah2n379kcnypvHtBSTuaA57fu9Ax +EWg04k3F5WZwwXXVahmCa/Ug43sqjQOuRNk6ds10t8R4SIIg/Non0GeJWUS4SxMxxkC r/sYZFyYJXlR1Xgw9N7mPE7pIM0C+jU9MIE420/m3nJrRxRK3ZBcgMeRXRw2L/8h7BRm xHLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nrHbWWbk2rn4IgAeIJ5AADSHdSvYjEee+qi1skngB4w=; b=Ncw9J/rE8MMTmOKX6vKKSq8r1pC4CGtjSjdq/8RHVztSTZr1/nmGaTpDLS2/AkAKdA qqS1wi6fv/lQsz+dxAxXu3Nj366j2RaWi5DUS4o6w7UkXmsMGQvkEOWMX+ufGBvouUSW nxELFUeCXJAXHDPN+9PNvUSjSWpl8WfRc11WvHWRZxXxY118tT8bVn10tXfqtGTSenn+ YFo8QoZ+79Wr+DKlRNenvDyM+Ju0XwZWS6iuy80KU9RRnqx9GJJMBCj3owPnQVmCfd0d nKvA9bC0aZa3TksjG0tQPu2jIgAaAQ7wb3dxTj0Jq3F/pp84Vb8GPECJb/I75oom8+jZ mT4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="wi3Vn+F/"; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si1160150edu.9.2021.02.17.03.25.48; Wed, 17 Feb 2021 03:25:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="wi3Vn+F/"; spf=pass (google.com: domain of linux-arm-msm-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231868AbhBQLYW (ORCPT + 16 others); Wed, 17 Feb 2021 06:24:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231769AbhBQLX2 (ORCPT ); Wed, 17 Feb 2021 06:23:28 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EC72C0617A9 for ; Wed, 17 Feb 2021 03:22:01 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id h10so11238824edl.6 for ; Wed, 17 Feb 2021 03:22:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nrHbWWbk2rn4IgAeIJ5AADSHdSvYjEee+qi1skngB4w=; b=wi3Vn+F/Dy9291Ae5vqGlad1VjtNnqArapfUeVTKnZonu3StWp+o5fkfgyyKIpl8a2 G3QyFAjEVWT+iGFno5mOQwwWHnGvAwbkknvHN2xRLvLuSzAR4PF2CLRffaVihW1jlkM+ bj1oU/KdXxngIuNf0dWdoYvG3B7MrgZCh8mBLabiNEVReNJvHyl0JgIJGwnj+tJuz4qN hqJ8mgIwunqKE5ahQ31kSOhCgwlMPBFdQqOJ6JqjzjUn6C631MLb8h2MP0CxBriIG+by esaYgqHRQrlZwg5Bg5tUh5MC4C/A3BHzhPvnb0yI72ozjPJppORXE98+AE3n8RTfChYR V8ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nrHbWWbk2rn4IgAeIJ5AADSHdSvYjEee+qi1skngB4w=; b=hjgnAoOz1HZxFHrYGosCogI9/OrdlON5k14TnWriz0BTytzrFA/iFvhGRWQC9T4C5r jHMCIjgURxo5oK198PG4RTcraEwlVev65SjS8d0ys2A+Uj4yOJdVkqFC52T4ZmTNdAf7 Xb5y/vpFiQQC7wYXmCGZQyaD2rM7MsIR6XL/Zfx+FXqG86iuVLijg+h5OM4BiSQJtRAN PzjAgq1CkVcVY2D+pFeQSq6dSLzZ2s7qv2IeI49usLkImfCQdVpwCuxBh3pfQms5bUJ0 P/0f3c0HifLmWOkckPb/67BUvqqadryQhTSHhH8XCU+ubEX6LRtaIxQ6YQ+rk/I+8T0Y /g2w== X-Gm-Message-State: AOAM531bMCP+pdxd7lhQkU8vvdeyLhC46UK7Syqg2u+JyLhNfn65QNTS hwzt426kOjGnfFL3j0lJTeFagQ== X-Received: by 2002:a50:ee10:: with SMTP id g16mr25760918eds.62.1613560920427; Wed, 17 Feb 2021 03:22:00 -0800 (PST) Received: from localhost.localdomain ([2a02:2450:102f:d6a:4815:d4dc:ff5a:704a]) by smtp.gmail.com with ESMTPSA id h10sm934344edk.45.2021.02.17.03.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 03:22:00 -0800 (PST) From: Robert Foss To: agross@kernel.org, bjorn.andersson@linaro.org, robert.foss@linaro.org, todor.too@gmail.com, mchehab@kernel.org, robh+dt@kernel.org, angelogioacchino.delregno@somainline.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Sakari Ailus , Nicolas Boichat , Andrey Konovalov Cc: Rob Herring , Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart , Jonathan Marek Subject: [PATCH v5 03/22] media: camss: Replace trace_printk() with dev_dbg() Date: Wed, 17 Feb 2021 12:21:03 +0100 Message-Id: <20210217112122.424236-4-robert.foss@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210217112122.424236-1-robert.foss@linaro.org> References: <20210217112122.424236-1-robert.foss@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org trace_printk() should not be used in production code, since extra memory is used for special buffers whenever trace_puts() is used. Replace it with dev_dbg() which provides all of the desired debugging functionality. Signed-off-by: Robert Foss Suggested-by: Nicolas Boichat Reviewed-by: Nicolas Boichat --- Changes since v3: - Nicolas: Create this patch Changes since v4: - Nicolas: Added r-b drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 5 +++-- drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) -- 2.27.0 diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c index a1b56b89130d..85b9bcbc7321 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -936,8 +937,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe); diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c index 84c33b8f9fe3..f7e00a2de393 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -1069,8 +1070,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe);