From patchwork Thu Mar 11 01:32:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junlin Yang X-Patchwork-Id: 397690 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9ADFC433E0 for ; Thu, 11 Mar 2021 01:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70DF464FAD for ; Thu, 11 Mar 2021 01:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229672AbhCKBfi (ORCPT ); Wed, 10 Mar 2021 20:35:38 -0500 Received: from m12-17.163.com ([220.181.12.17]:47963 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbhCKBfL (ORCPT ); Wed, 10 Mar 2021 20:35:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=5WoMy ZTHQdfaqA4EOcYW9rkD3AGGiDpAdh4AxhYcP50=; b=gpvH1ePN0uk4Fyj6Zz+14 T/Vh7g61LCZwbkbfao6OYQdf7uJ2GSeqpysDqS5DBU4lrpiTUQSJC6cjZ8aWEHlc EKGYtzMA5bcD3qCEoHXzsrEEY+N4RkTezVaQ+ppNM3klTtimVunxgUebqCBDTfSZ XRVok8d+MzLEQU7FINcpC4= Received: from yangjunlin.ccdomain.com (unknown [119.137.52.247]) by smtp13 (Coremail) with SMTP id EcCowACnG4iqc0lgV70upQ--.50520S2; Thu, 11 Mar 2021 09:34:35 +0800 (CST) From: angkery To: agross@kernel.org, bjorn.andersson@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Junlin Yang Subject: [PATCH] firmware: qcom_scm: remove a duplicative condition Date: Thu, 11 Mar 2021 09:32:35 +0800 Message-Id: <20210311013235.1458-1-angkery@163.com> X-Mailer: git-send-email 2.24.0.windows.2 MIME-Version: 1.0 X-CM-TRANSID: EcCowACnG4iqc0lgV70upQ--.50520S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZF1kuF1kJF4UZFWrJw4xZwb_yoW3WFcEkr 1xuF48WryjkrZ09r1DKFW3X3s5t3yDWwsagF12vw4ayFW7Zw4DXr97Z3y8ua9rJw1xZFy7 Zr95Zr4rCw10kjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnb4SUUUUUU== X-Originating-IP: [119.137.52.247] X-CM-SenderInfo: 5dqjyvlu16il2tof0z/xtbCBgtSI13I0-ETNQAAst Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Junlin Yang Fixes coccicheck warnings: ./drivers/firmware/qcom_scm.c:324:20-22: WARNING !A || A && B is equivalent to !A || B Signed-off-by: Junlin Yang --- drivers/firmware/qcom_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index f57779f..5483416 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -321,7 +321,7 @@ int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus) .owner = ARM_SMCCC_OWNER_SIP, }; - if (!cpus || (cpus && cpumask_empty(cpus))) + if (!cpus || cpumask_empty(cpus)) return -EINVAL; for_each_cpu(cpu, cpus) {