diff mbox series

[v6,2/3] drm/bridge: ti-sn65dsi86: Use regmap_bulk_write API

Message ID 20210930030557.1426-2-bjorn.andersson@linaro.org
State New
Headers show
Series [v6,1/3] pwm: Introduce single-PWM of_xlate function | expand

Commit Message

Bjorn Andersson Sept. 30, 2021, 3:05 a.m. UTC
The multi-register u16 write operation can use regmap_bulk_write()
instead of two separate regmap_write() calls.

It's uncertain if this has any effect on the actual updates of the
underlying registers, but this at least gives the hardware the
opportunity and saves us one transation on the bus.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

---

Changes since v5:
- Extracted this hunk from patch 3.

 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.32.0

Comments

Doug Anderson Sept. 30, 2021, 3:40 p.m. UTC | #1
Hi,

On Wed, Sep 29, 2021 at 8:06 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>

> The multi-register u16 write operation can use regmap_bulk_write()

> instead of two separate regmap_write() calls.

>

> It's uncertain if this has any effect on the actual updates of the

> underlying registers, but this at least gives the hardware the

> opportunity and saves us one transation on the bus.


s/transation/transaction/


> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---

>

> Changes since v5:

> - Extracted this hunk from patch 3.

>

>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 +++--

>  1 file changed, 3 insertions(+), 2 deletions(-)


Looks keen. I'll plan to apply this after giving it a few days on the
list to make sure nobody is upset, though I'm not sure why they would
be. ;-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 41d48a393e7f..412fb6f564ea 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -193,8 +193,9 @@  static const struct regmap_config ti_sn65dsi86_regmap_config = {
 static void ti_sn65dsi86_write_u16(struct ti_sn65dsi86 *pdata,
 				   unsigned int reg, u16 val)
 {
-	regmap_write(pdata->regmap, reg, val & 0xFF);
-	regmap_write(pdata->regmap, reg + 1, val >> 8);
+	u8 buf[2] = { val & 0xff, val >> 8 };
+
+	regmap_bulk_write(pdata->regmap, reg, buf, ARRAY_SIZE(buf));
 }
 
 static u32 ti_sn_bridge_get_dsi_freq(struct ti_sn65dsi86 *pdata)