From patchwork Wed Feb 2 21:23:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 539641 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF783C433F5 for ; Wed, 2 Feb 2022 21:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235950AbiBBVYU (ORCPT ); Wed, 2 Feb 2022 16:24:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232854AbiBBVYR (ORCPT ); Wed, 2 Feb 2022 16:24:17 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDF24C061714 for ; Wed, 2 Feb 2022 13:24:17 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id c194so386866pfb.12 for ; Wed, 02 Feb 2022 13:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ERootrk4zEfHUOhgfH+rtttwTculem/Ci38KL1ItthA=; b=kTFPH7ge3u8ih6rXPvUXkPrD716e8ZuO6zMoUv2PUu6ouO8/1Wyf3VttthKbKX/xnC Ubo2iv6gfgibz21/E0sZOk3M1bTFk6d/myXdcgvBSNCBTof66XJa/Ol0AbJLy6jSWw4l 8j+sfBdoH5OnlJdU9qCARzJlfCLbO3KHXbJlY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ERootrk4zEfHUOhgfH+rtttwTculem/Ci38KL1ItthA=; b=CmsVN9JVw2fa7RC1sXSv8RyXF2CBLDb6WDluQxKbbx3zm/OGXXDkYRSBmK5ocO/u1u UiG1Q2CRqgXleyiBo3XtmxmjgwEKIASrhEbO9vb2D7wYDUeeFmtm1493GnXIdxrPJ6Gv sdQDjI8SaZjObIfNhNBbFzgLa18O6Mcm5eSWH0OXuY9Mf/lFfA2I7feM/aZ2kZfK9ZgH Hed1guPWTRb0P0MH1BiHee7A72AjDyi91T1hEgW7/F9Hj7FWxhVNPj8HHTLINUNbQazW 3aj1iFL9pCXFRemvEaCjTFDdQSul36MWcmOj6g3yt/UbGL5gt3/V1o1LOANbGNbhY67P MFpw== X-Gm-Message-State: AOAM5309zkMlizbhDZsi+3m/azPlLADuoYFtBtGbJLjmAB7H8szj729m DQ80I+Cm6YEFfIolIqtU+/oKNA== X-Google-Smtp-Source: ABdhPJzGt9IZqVcKjMM8YZfcWuKOpKUaKOweWeXNxVqlnJLPq3Hl62vZ/F/iW15Vou7b8cOhjD3irg== X-Received: by 2002:a63:5908:: with SMTP id n8mr25626217pgb.390.1643837057379; Wed, 02 Feb 2022 13:24:17 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:f1c4:10b6:b4ef:16e5]) by smtp.gmail.com with ESMTPSA id on9sm7627983pjb.16.2022.02.02.13.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 13:24:16 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson Cc: pmaliset@codeaurora.org, mka@chromium.org, quic_rjendra@quicinc.com, Shaik Sajida Bhanu , kgodara@codeaurora.org, konrad.dybcio@somainline.org, Sankeerth Billakanti , sibis@codeaurora.org, swboyd@chromium.org, Douglas Anderson , Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 05/14] arm64: dts: qcom: sc7280-idp: No need for "input-enable" on sw_ctrl Date: Wed, 2 Feb 2022 13:23:39 -0800 Message-Id: <20220202132301.v3.5.Ibaf8a803802beb089cc6266b37e6156cff3ddaec@changeid> X-Mailer: git-send-email 2.35.0.rc2.247.g8bbb082509-goog In-Reply-To: <20220202212348.1391534-1-dianders@chromium.org> References: <20220202212348.1391534-1-dianders@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Specifying "input-enable" on a MSM GPIO is a no-op for the most part. The only thing it really does is to explicitly force the output of a GPIO to be disabled right at the point of a pinctrl transition. We don't need to do this and we don't typically specify "input-enable" unless there's a good reason to. Remove it. Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 7a987bc9b758..23e656e51904 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -534,7 +534,6 @@ sd_cd: sd-cd { sw_ctrl: sw-ctrl { pins = "gpio86"; function = "gpio"; - input-enable; bias-pull-down; }; };