From patchwork Wed Mar 2 10:39:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh Sharma X-Patchwork-Id: 548233 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E74C433F5 for ; Wed, 2 Mar 2022 10:40:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241066AbiCBKky (ORCPT ); Wed, 2 Mar 2022 05:40:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241080AbiCBKkw (ORCPT ); Wed, 2 Mar 2022 05:40:52 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49862BECE7 for ; Wed, 2 Mar 2022 02:40:06 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id e13so1214201plh.3 for ; Wed, 02 Mar 2022 02:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3OW6Vzq0apzZ0AvI5XYyUy01zZckjEhZ83VWyjEGv1M=; b=lxb5ga3VT2jhzJzOvy/QTv1oGLd8ZdoJf29WIXqBa7cDDqZcmYiqSfbXwiC+bo484R rvULaR6bCyDxTl6cE1/UB6zyP+N2xmjciFjbkjCJULIfn65SIXDSrAKvaBQ9QEMkbifz yPHGw41EvzJopM+AGQaPMN8FlmR5ewdhu0Kvmu9osMpAaSFV6MgMlIpBspPlHT6gcsE3 2WvBiP5tAdfvKeTRciolbdItL/bblTAqpx6KM561EOy0Mk68z8FiXMRELdsYxRP2tnrZ DHJfYphDZJVFKiDZsoHu0oNP3lCPreoozlXG5QCyPLEmltUXX4xZWaRuL/aXj7gSWi7j B7SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3OW6Vzq0apzZ0AvI5XYyUy01zZckjEhZ83VWyjEGv1M=; b=QguF8uI4hsG9ewCDGgp+/60cJcnLbe971h5W03gPC0FT36cdH0tnxwz5XSrntnIKvQ TWI4lz3vZd+wmoVJdoKoHbH9LT8c8zTCFcknitCYKRY04fIofv3PIxODSTLEVRPf5ujy c6XTI9iA2wdLif9iEl4QWXgw6OCuZ/O9Kr2CvLRBkPXbJ964coTHndwaD6jdkoSuey0V r9iLXOpKXXHtzsOexyRhqsnHFl5m3FnGNmB5/acF0k/WH46OD6L3nmPwqf6TcxVxZZLa 6plLn77o26OAkK0O3u1qdgvd4RsE0oaJUHBejXztIDYYY2q31Vcs+Kv5xbAYmjS7LaXs Q1IA== X-Gm-Message-State: AOAM532Gug8EsyFtQqWQpjfWEOeEmpQWIVvI7VwvthP/Vkl4KqLqHtdZ uHmmbqduBrJ5a/2a94QIa77FDA== X-Google-Smtp-Source: ABdhPJxBX9zldaofDMQXAyS43Qk+pwolnE7L6eIRQD0Ydlk47m5P4RU24uvzpKq26vhLtsXNxAIS8g== X-Received: by 2002:a17:902:ef52:b0:151:84fe:bccb with SMTP id e18-20020a170902ef5200b0015184febccbmr7215972plx.9.1646217605772; Wed, 02 Mar 2022 02:40:05 -0800 (PST) Received: from localhost.localdomain ([171.50.175.145]) by smtp.gmail.com with ESMTPSA id m20-20020a634c54000000b003739af127c9sm15612308pgl.70.2022.03.02.02.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 02:40:05 -0800 (PST) From: Bhupesh Sharma To: netdev@vger.kernel.org Cc: bhupesh.sharma@linaro.org, bhupesh.linux@gmail.com, vkoul@kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org Subject: [PATCH v2 2/2 net-next] net: stmmac: dwmac-qcom-ethqos: Adjust rgmii loopback_en per platform Date: Wed, 2 Mar 2022 16:09:50 +0530 Message-Id: <20220302103950.30356-3-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220302103950.30356-1-bhupesh.sharma@linaro.org> References: <20220302103950.30356-1-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Bjorn Andersson Not all platforms should have RGMII_CONFIG_LOOPBACK_EN and the result it about 50% packet loss on incoming messages. So make it possile to configure this per compatible and enable it for QCS404. Cc: David S. Miller Signed-off-by: Bjorn Andersson --- .../stmicro/stmmac/dwmac-qcom-ethqos.c | 22 +++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 8cdba9d521ec..0cc28c79cc61 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -78,6 +78,7 @@ struct ethqos_emac_por { struct ethqos_emac_driver_data { const struct ethqos_emac_por *por; unsigned int num_por; + bool rgmii_config_looback_en; }; struct qcom_ethqos { @@ -90,6 +91,7 @@ struct qcom_ethqos { const struct ethqos_emac_por *por; unsigned int num_por; + bool rgmii_config_looback_en; }; static int rgmii_readl(struct qcom_ethqos *ethqos, unsigned int offset) @@ -181,6 +183,7 @@ static const struct ethqos_emac_por emac_v2_3_0_por[] = { static const struct ethqos_emac_driver_data emac_v2_3_0_data = { .por = emac_v2_3_0_por, .num_por = ARRAY_SIZE(emac_v2_3_0_por), + .rgmii_config_looback_en = true, }; static const struct ethqos_emac_por emac_v2_1_0_por[] = { @@ -195,6 +198,7 @@ static const struct ethqos_emac_por emac_v2_1_0_por[] = { static const struct ethqos_emac_driver_data emac_v2_1_0_data = { .por = emac_v2_1_0_por, .num_por = ARRAY_SIZE(emac_v2_1_0_por), + .rgmii_config_looback_en = false, }; static int ethqos_dll_configure(struct qcom_ethqos *ethqos) @@ -311,8 +315,12 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos) rgmii_updatel(ethqos, SDCC_DDR_CONFIG_PRG_DLY_EN, SDCC_DDR_CONFIG_PRG_DLY_EN, SDCC_HC_REG_DDR_CONFIG); - rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, - RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + if (ethqos->rgmii_config_looback_en) + rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, + RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + else + rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, + 0, RGMII_IO_MACRO_CONFIG); break; case SPEED_100: @@ -345,8 +353,13 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos) rgmii_updatel(ethqos, SDCC_DDR_CONFIG_EXT_PRG_RCLK_DLY_EN, SDCC_DDR_CONFIG_EXT_PRG_RCLK_DLY_EN, SDCC_HC_REG_DDR_CONFIG); - rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, - RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + if (ethqos->rgmii_config_looback_en) + rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, + RGMII_CONFIG_LOOPBACK_EN, RGMII_IO_MACRO_CONFIG); + else + rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, + 0, RGMII_IO_MACRO_CONFIG); + break; case SPEED_10: @@ -518,6 +531,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev) data = of_device_get_match_data(&pdev->dev); ethqos->por = data->por; ethqos->num_por = data->num_por; + ethqos->rgmii_config_looback_en = data->rgmii_config_looback_en; ethqos->rgmii_clk = devm_clk_get(&pdev->dev, "rgmii"); if (IS_ERR(ethqos->rgmii_clk)) {