| Message ID | 20220503220927.960821-4-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1,1/5] arm64: dts: qcom: sdm660: disable dsi1/dsi1_phy by default | expand |
On 04/05/2022 00:09, Dmitry Baryshkov wrote: > According to the downstram DT file, the qusb2phy ref clock should be > GCC_RX0_USB2_CLKREF_CLK, not GCC_RX1_USB2_CLKREF_CLK. > > Fixes: c65a4ed2ea8b ("arm64: dts: qcom: sdm630: Add USB configuration") > Cc: Konrad Dybcio <konrad.dybcio@somainline.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- So it always worked by miracle, as bootloader left it on. Nice catch. Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index 45eaaa6a4a74..d8c3d2569340 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -1262,7 +1262,7 @@ qusb2phy: phy@c012000 { > #phy-cells = <0>; > > clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, > - <&gcc GCC_RX1_USB2_CLKREF_CLK>; > + <&gcc GCC_RX0_USB2_CLKREF_CLK>; > clock-names = "cfg_ahb", "ref"; > > resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>; >
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index 45eaaa6a4a74..d8c3d2569340 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -1262,7 +1262,7 @@ qusb2phy: phy@c012000 { #phy-cells = <0>; clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>, - <&gcc GCC_RX1_USB2_CLKREF_CLK>; + <&gcc GCC_RX0_USB2_CLKREF_CLK>; clock-names = "cfg_ahb", "ref"; resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
According to the downstram DT file, the qusb2phy ref clock should be GCC_RX0_USB2_CLKREF_CLK, not GCC_RX1_USB2_CLKREF_CLK. Fixes: c65a4ed2ea8b ("arm64: dts: qcom: sdm630: Add USB configuration") Cc: Konrad Dybcio <konrad.dybcio@somainline.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)