| Message ID | 20220623094614.1410180-3-stephan.gerhold@kernkonzept.com |
|---|---|
| State | Accepted |
| Commit | 8cbb948a7cc2875d09234e2ce0424bc501c370b9 |
| Headers | show |
| Series | regulator: qcom_smd: Add PM8909 and fix pm8916_pldo range | expand |
On Fri, Jun 24, 2022 at 11:26:34AM -0600, Rob Herring wrote: > On Thu, 23 Jun 2022 11:46:13 +0200, Stephan Gerhold wrote: > > Document the "qcom,rpm-pm8909-regulators" compatible for describing > > the regulators available in the PM8909 PMIC (controlled via the RPM > > firmware). > > > > PM8909 is very similar to the existing PM8916 but lacks 3 of the > > regulators (s3, s4 and l16). > > > > Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> > > --- > > .../devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > pm8994-regulators: 'vdd_lvs1_2' does not match any of the regexes: '.*-supply$', '^((s|l|lvs|5vs)[0-9]*)|(boost-bypass)|(bob)$', 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dtb > arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dtb > arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dtb > Thanks for the (automated) report, Rob! :) The failure is unrelated to my patch. It seems to be a simple typo in the device tree (not a mistake in the DT schema) so I posted a quick fix in a separate patch: https://lore.kernel.org/linux-arm-msm/20220627135938.2901871-1-stephan.gerhold@kernkonzept.com/ It should land separately through the Qualcomm tree so no need to wait for it to be applied. :) Thanks, Stephan
diff --git a/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml index 6a9a7eed466f..c233461cc980 100644 --- a/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml @@ -30,6 +30,9 @@ description: For pm8841, s1, s2, s3, s4, s5, s6, s7, s8 + For pm8909, s1, s2, l1, l2, l3, l4, l5, l6, l7, l8, l9, l10, l11, l12, l13, + l14, l15, l17, l18 + For pm8916, s1, s2, s3, s4, l1, l2, l3, l4, l5, l6, l7, l8, l9, l10, l11, l12, l13, l14, l15, l16, l17, l18 @@ -78,6 +81,7 @@ properties: - qcom,rpm-mp5496-regulators - qcom,rpm-pm8226-regulators - qcom,rpm-pm8841-regulators + - qcom,rpm-pm8909-regulators - qcom,rpm-pm8916-regulators - qcom,rpm-pm8941-regulators - qcom,rpm-pm8950-regulators
Document the "qcom,rpm-pm8909-regulators" compatible for describing the regulators available in the PM8909 PMIC (controlled via the RPM firmware). PM8909 is very similar to the existing PM8916 but lacks 3 of the regulators (s3, s4 and l16). Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> --- .../devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml | 4 ++++ 1 file changed, 4 insertions(+)