From patchwork Mon Jul 4 01:06:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 587576 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87942CCA473 for ; Mon, 4 Jul 2022 01:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbiGDBHG (ORCPT ); Sun, 3 Jul 2022 21:07:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiGDBHG (ORCPT ); Sun, 3 Jul 2022 21:07:06 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 461645FA1 for ; Sun, 3 Jul 2022 18:07:05 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id ay16so14098359ejb.6 for ; Sun, 03 Jul 2022 18:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2uCwmHdjg21zPOoZO9GyiM8A7cUULvVI0yDuz4f3uYI=; b=bS7RcMoEft/5NjhWNeRimGLsTQ+Wg0UZPDQzUxvdMyoMeRKchuqpc+mJ2oE2gWenuk T1P980rkW10S8CBIC6wSCTa1gnEEzrR33lkx7GsXFDsmEWib18aYK4d0OVcqIkwX+8aq 9M1T4LmblBTEsdiWmBrPhwh5B45+52mf3TK9Q1Eg5YS6cE3vbHgEUxv1bDshjAp0cc0C W6b7ErrhqqMaKWm20RcMarE3nw8k1dt7f5gV3fFV1R9zjMngK+2E4c4/cowO+zXxwQ8z pW1+qRuAGAvMU+qqSsH7Jk08x7b5L7D15lSkLPH03WhL8Pm+1czu7PKflbzR1DceNvMx XH0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2uCwmHdjg21zPOoZO9GyiM8A7cUULvVI0yDuz4f3uYI=; b=rEPD1knSZDXhF5uLZMz6KrmrBFBuoKROgsAn+I5Lc9uXyqkwRg1O9Yy5EYOmrISaxv FUgZg1n7ZJA71hzLgmtShz4WkLF5R88Ylllh0zR2zDO2Ed9g0+Nl0M6+hh2Pe19Dqqr7 D4Yd9vKT+HWAH642ENqUztOQugG8UAYU78MJXwbb5OB+/bzxls+l8iyu4t4n/32b3gU3 gF55mEo3LkzcZ8xWdYt68GGoCNfQevNA1tfBMvMu7mMsg8klkwRv8Oxot2rHb83h2PUk E80JyZfyePaxkdbwelPO0V/MKX8ICdV3OLLR5jtBbihogHrkUjzrfdhSOLWQeZhXwoRk CQyQ== X-Gm-Message-State: AJIora++1mqsWQp5VVpoH8hw3CJkMopn8u2O+xC5D7pocvegfOvaNpQK 5dqBuZpqr67Z7nnypzYCmC/dDQ== X-Google-Smtp-Source: AGRyM1szTyfoz9drJjJ1gIz9yqZ/HmCYzgbwCHm3azSy/cMq02SmmaZKLpilTJDQD1+fHf3Zt0SELQ== X-Received: by 2002:a17:907:7283:b0:727:b4c0:b1f6 with SMTP id dt3-20020a170907728300b00727b4c0b1f6mr26449877ejc.197.1656896823887; Sun, 03 Jul 2022 18:07:03 -0700 (PDT) Received: from localhost.localdomain ([146.70.96.66]) by smtp.gmail.com with ESMTPSA id lu4-20020a170906fac400b006fec69696a0sm13466082ejb.220.2022.07.03.18.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Jul 2022 18:07:03 -0700 (PDT) From: Bryan O'Donoghue To: agross@kernel.org, bjorn.andersson@linaro.org, myungjoo.ham@samsung.com, cw00.choi@samsung.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, stephan@gerhold.net, marijn.suijten@somainline.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, bryan.odonoghue@linaro.org, Rob Herring Subject: [PATCH v3 1/2] dt-bindings: pm8941-misc: Fix usb_id and usb_vbus definitions Date: Mon, 4 Jul 2022 02:06:58 +0100 Message-Id: <20220704010659.223596-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220704010659.223596-1-bryan.odonoghue@linaro.org> References: <20220704010659.223596-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org dts validation is throwing an error for me on 8916 and 8939 with extcon@1300. In that case we have usb_vbus but not usb_id. It wasn't immediately obvious if there was a valid use-case for the existing code for usb_id in isolation, however discussing further, we concluded that usb_id, usb_vbus or (usb_id | usb_vbus) are valid combinations as an external IC may be responsible for usb_id or usb_vbus. Expand the definition with anyOf to capture the three different valid modes. Fixes: 4fcdd677c4ea ("bindings: pm8941-misc: Add support for VBUS detection") Reviewed-by: Rob Herring Reviewed-by: Marijn Suijten Signed-off-by: Bryan O'Donoghue --- .../devicetree/bindings/extcon/qcom,pm8941-misc.yaml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml index 6a9c96f0352ac..1bc412a4ac5e6 100644 --- a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml +++ b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml @@ -27,10 +27,14 @@ properties: interrupt-names: minItems: 1 - items: - - const: usb_id - - const: usb_vbus - + anyOf: + - items: + - const: usb_id + - const: usb_vbus + - items: + - const: usb_id + - items: + - const: usb_vbus required: - compatible - reg