| Message ID | 20220706225321.26215-5-ansuelsmth@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: qcom: Drop use of pxo/cxo_board for rpm devices | expand |
On Wed 06 Jul 17:53 CDT 2022, Christian Marangi wrote: > Now that these clock are defined as fixed clk in dts, we can drop the > register_board_clk for cxo_board and pxo_board in gcc_ipq806x_probe. > Are you trying to say, that now that we have .fw_name based lookup of these clocks we don't need the globally registered [cp]xo clocks to bridge towards the [cp]xo_board_clocks which was introduced in: 30fc4212d541 ("arm: dts: qcom: Add more board clocks") I think this change would work out if you also replace .name = "pxo" with .name = "pxo_board_clk" (and same for cxo)... But I don't think we can just drop these, as it would break compatibility with existing devicetree. Regards, Bjorn > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > drivers/clk/qcom/gcc-ipq806x.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c > index 718de17a1e60..883629de2751 100644 > --- a/drivers/clk/qcom/gcc-ipq806x.c > +++ b/drivers/clk/qcom/gcc-ipq806x.c > @@ -3384,14 +3384,6 @@ static int gcc_ipq806x_probe(struct platform_device *pdev) > struct regmap *regmap; > int ret; > > - ret = qcom_cc_register_board_clk(dev, "cxo_board", "cxo", 25000000); > - if (ret) > - return ret; > - > - ret = qcom_cc_register_board_clk(dev, "pxo_board", "pxo", 25000000); > - if (ret) > - return ret; > - > if (of_machine_is_compatible("qcom,ipq8065")) { > ubi32_core1_src_clk.freq_tbl = clk_tbl_nss_ipq8065; > ubi32_core2_src_clk.freq_tbl = clk_tbl_nss_ipq8065; > -- > 2.36.1 >
diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c index 718de17a1e60..883629de2751 100644 --- a/drivers/clk/qcom/gcc-ipq806x.c +++ b/drivers/clk/qcom/gcc-ipq806x.c @@ -3384,14 +3384,6 @@ static int gcc_ipq806x_probe(struct platform_device *pdev) struct regmap *regmap; int ret; - ret = qcom_cc_register_board_clk(dev, "cxo_board", "cxo", 25000000); - if (ret) - return ret; - - ret = qcom_cc_register_board_clk(dev, "pxo_board", "pxo", 25000000); - if (ret) - return ret; - if (of_machine_is_compatible("qcom,ipq8065")) { ubi32_core1_src_clk.freq_tbl = clk_tbl_nss_ipq8065; ubi32_core2_src_clk.freq_tbl = clk_tbl_nss_ipq8065;
Now that these clock are defined as fixed clk in dts, we can drop the register_board_clk for cxo_board and pxo_board in gcc_ipq806x_probe. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- drivers/clk/qcom/gcc-ipq806x.c | 8 -------- 1 file changed, 8 deletions(-)