Message ID | 20220802153434.v3.2.I94b3c3e412b7c208061349f05659e126483171b1@changeid |
---|---|
State | Superseded |
Headers | show |
Series | drm/msm/dsi regulator improvements | expand |
On 03/08/2022 01:37, Douglas Anderson wrote: > 1 regulators is specified listed but the number 2 is specified. This > presumably means we try to get a regulator with no name. Fix it. > > Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > > (no changes since v2) > > Changes in v2: > - ("Fix number of regulators for SDM660") new for v2. > > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index 02000a7b7a18..72c018e26f47 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -148,7 +148,7 @@ static const char * const dsi_sdm660_bus_clk_names[] = { > static const struct msm_dsi_config sdm660_dsi_cfg = { > .io_offset = DSI_6G_REG_SHIFT, > .reg_cfg = { > - .num = 2, > + .num = 1, > .regs = { > {"vdda", 12560, 4 }, /* 1.2 V */ We should find some time and switch the reg_cfg.regs to be the external array, so that we can use ARRAY_SIZE for the amount of regs. However it is definitely not a showstopper for this series.
On 2022-08-02 15:37:34, Douglas Anderson wrote: > 1 regulators is specified listed but the number 2 is specified. This > presumably means we try to get a regulator with no name. Fix it. > > Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") This should be: Fixes: 462f7017a691 ("drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660") The original patch included two regulators; that "fix" patch removed "vdd". After that: Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > (no changes since v2) > > Changes in v2: > - ("Fix number of regulators for SDM660") new for v2. > > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index 02000a7b7a18..72c018e26f47 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -148,7 +148,7 @@ static const char * const dsi_sdm660_bus_clk_names[] = { > static const struct msm_dsi_config sdm660_dsi_cfg = { > .io_offset = DSI_6G_REG_SHIFT, > .reg_cfg = { > - .num = 2, > + .num = 1, > .regs = { > {"vdda", 12560, 4 }, /* 1.2 V */ > }, > -- > 2.37.1.455.g008518b4e5-goog >
On 8/2/2022 3:37 PM, Douglas Anderson wrote: > 1 regulators is specified listed but the number 2 is specified. This > presumably means we try to get a regulator with no name. Fix it. > > Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Agree with Marijn's comment here: https://patchwork.freedesktop.org/patch/496153/?series=106731&rev=2#comment_894595 Will queue for -fixes with the fixes tag he has given Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > > (no changes since v2) > > Changes in v2: > - ("Fix number of regulators for SDM660") new for v2. > > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index 02000a7b7a18..72c018e26f47 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -148,7 +148,7 @@ static const char * const dsi_sdm660_bus_clk_names[] = { > static const struct msm_dsi_config sdm660_dsi_cfg = { > .io_offset = DSI_6G_REG_SHIFT, > .reg_cfg = { > - .num = 2, > + .num = 1, > .regs = { > {"vdda", 12560, 4 }, /* 1.2 V */ > },
diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c index 02000a7b7a18..72c018e26f47 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c @@ -148,7 +148,7 @@ static const char * const dsi_sdm660_bus_clk_names[] = { static const struct msm_dsi_config sdm660_dsi_cfg = { .io_offset = DSI_6G_REG_SHIFT, .reg_cfg = { - .num = 2, + .num = 1, .regs = { {"vdda", 12560, 4 }, /* 1.2 V */ },
1 regulators is specified listed but the number 2 is specified. This presumably means we try to get a regulator with no name. Fix it. Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- (no changes since v2) Changes in v2: - ("Fix number of regulators for SDM660") new for v2. drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)