| Message ID | 20220831134626.2803117-7-stephan.gerhold@kernkonzept.com |
|---|---|
| State | New |
| Headers | show |
| Series | remoteproc: qcom_q6v5_mss: Add MSM8909 and MSM8953 | expand |
On 31/08/2022 15:46, Stephan Gerhold wrote: > Add the compatible for MSS as found on the MSM8953 platform. > > The situation is similar to the existing bindings for MSM8974: there is > an additional "mss" power domain that must be voted for while starting > up the remote processor. The difference is that on MSM8974 the power > domain is represented as a regulator (firmware expects specific voltage) > while on MSM8953 it is represented as power domain (firmware expects > performance state instead of voltage). > > Handle this difference by adding the "mss" power domain as optional > third item, and then restrict it (and make it required) only when using > the MSM8953 compatible. > > Co-developed-by: Sireesh Kodali <sireeshkodali1@gmail.com> > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> > Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml index 98b19296bde5..3686aabf074a 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml @@ -19,6 +19,7 @@ properties: - enum: - qcom,msm8909-mss-pil - qcom,msm8916-mss-pil + - qcom,msm8953-mss-pil - qcom,msm8974-mss-pil - const: qcom,q6v5-pil @@ -69,11 +70,16 @@ properties: items: - description: CX proxy power domain (control handed over after startup) - description: MX proxy power domain (control handed over after startup) + - description: MSS proxy power domain (control handed over after startup) + (only valid for qcom,msm8953-mss-pil) + minItems: 2 power-domain-names: items: - const: cx - const: mx + - const: mss # only valid for qcom,msm8953-mss-pil + minItems: 2 pll-supply: description: PLL proxy supply (control handed over after startup) @@ -186,6 +192,27 @@ required: - smd-edge allOf: + # mss power domain is only valid (and required) for MSM8953 + - if: + properties: + compatible: + const: qcom,msm8953-mss-pil + then: + properties: + power-domains: + minItems: 3 + power-domain-names: + minItems: 3 + required: + - power-domains + - power-domain-names + else: + properties: + power-domains: + maxItems: 2 + power-domain-names: + maxItems: 2 + # mss-supply is only valid (and required) for MSM8974 - if: properties: