diff mbox series

[1/2] ARM: dts: qcom: msm8974: Align dsi phy-names with schema

Message ID 20220925172443.92900-1-luca@z3ntu.xyz
State New
Headers show
Series [1/2] ARM: dts: qcom: msm8974: Align dsi phy-names with schema | expand

Commit Message

Luca Weiss Sept. 25, 2022, 5:24 p.m. UTC
Use dsi instead of dsi-phy as required by the binding.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Neil Armstrong Sept. 26, 2022, 8:47 a.m. UTC | #1
On 25/09/2022 19:24, Luca Weiss wrote:
> Use dsi instead of dsi-phy as required by the binding.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>   arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 620900e5ffd5..da247d799492 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1571,7 +1571,7 @@ dsi0: dsi@fd922800 {
>   					      "core_mmss";
>   
>   				phys = <&dsi0_phy>;
> -				phy-names = "dsi-phy";
> +				phy-names = "dsi";
>   
>   				status = "disabled";
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Neil Armstrong Sept. 26, 2022, 8:47 a.m. UTC | #2
On 25/09/2022 19:24, Luca Weiss wrote:
> Use dsi instead of dsi-phy as required by the binding.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>   arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index a831064700ee..48f4b4deb8b1 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1046,7 +1046,7 @@ dsi0: dsi@1a98000 {
>   					      "pixel",
>   					      "core";
>   				phys = <&dsi_phy0>;
> -				phy-names = "dsi-phy";
> +				phy-names = "dsi";
>   
>   				#address-cells = <1>;
>   				#size-cells = <0>;

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Krzysztof Kozlowski Sept. 26, 2022, 8:52 a.m. UTC | #3
On 25/09/2022 19:24, Luca Weiss wrote:
> Use dsi instead of dsi-phy as required by the binding.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>  arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-

Already sent:

https://lore.kernel.org/all/20220924090108.166934-3-dmitry.baryshkov@linaro.org/

Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 26, 2022, 8:53 a.m. UTC | #4
On 25/09/2022 19:24, Luca Weiss wrote:
> Use dsi instead of dsi-phy as required by the binding.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---

Already sent:

https://lore.kernel.org/all/20220924090108.166934-4-dmitry.baryshkov@linaro.org/

Best regards,
Krzysztof
Dmitry Baryshkov Sept. 26, 2022, 10:09 a.m. UTC | #5
On 25/09/2022 20:24, Luca Weiss wrote:
> Use dsi instead of dsi-phy as required by the binding.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>   arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 620900e5ffd5..da247d799492 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1571,7 +1571,7 @@ dsi0: dsi@fd922800 {
>   					      "core_mmss";
>   
>   				phys = <&dsi0_phy>;
> -				phy-names = "dsi-phy";
> +				phy-names = "dsi";

I'd prefer to merge [1] instead

[1] 
https://lore.kernel.org/linux-arm-msm/20220907000105.786265-1-bryan.odonoghue@linaro.org/

>   
>   				status = "disabled";
>
Luca Weiss Sept. 26, 2022, 3:02 p.m. UTC | #6
Hi Krzysztof,

On Montag, 26. September 2022 10:53:03 CEST Krzysztof Kozlowski wrote:
> On 25/09/2022 19:24, Luca Weiss wrote:
> > Use dsi instead of dsi-phy as required by the binding.
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> 
> Already sent:
> 
> https://lore.kernel.org/all/20220924090108.166934-4-dmitry.baryshkov@linaro.
> org/

This patch is phy-names property while the other patch is for node name, 
unless I'm missing something.

But as Dmitry pointed out, there's a patchset to completely remove the 
property which is also totally fine by me.

Regards
Luca

> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski Sept. 26, 2022, 3:22 p.m. UTC | #7
On 26/09/2022 17:02, Luca Weiss wrote:
> Hi Krzysztof,
> 
> On Montag, 26. September 2022 10:53:03 CEST Krzysztof Kozlowski wrote:
>> On 25/09/2022 19:24, Luca Weiss wrote:
>>> Use dsi instead of dsi-phy as required by the binding.
>>>
>>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>>> ---
>>
>> Already sent:
>>
>> https://lore.kernel.org/all/20220924090108.166934-4-dmitry.baryshkov@linaro.
>> org/
> 
> This patch is phy-names property while the other patch is for node name, 
> unless I'm missing something.

Ah, right. -ETOOMANYPHYs...

> 
> But as Dmitry pointed out, there's a patchset to completely remove the 
> property which is also totally fine by me.
Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index 620900e5ffd5..da247d799492 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -1571,7 +1571,7 @@  dsi0: dsi@fd922800 {
 					      "core_mmss";
 
 				phys = <&dsi0_phy>;
-				phy-names = "dsi-phy";
+				phy-names = "dsi";
 
 				status = "disabled";