| Message ID | 20220930185236.867655-11-dmitry.baryshkov@linaro.org |
|---|---|
| State | Accepted |
| Commit | ab1605f45421a1ef112cc917dab8d3b3367813f8 |
| Headers | show |
| Series | ARM: dts: qcom: rework DT for apq8064, msm8960 and msm8660 | expand |
On 30/09/2022 20:52, Dmitry Baryshkov wrote: > There are no need to add additional simple-bus nodes just to populate > a single pwrseq device. Pull it up one level into /. While we are at it > also fix node name replacing underscore with dash. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > index 5ff0d9a275cc..d6ecfd8addb7 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > @@ -15,18 +15,11 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > - pwrseq { > - #address-cells = <1>; > - #size-cells = <1>; > - ranges; > - compatible = "simple-bus"; > - > - sdcc4_pwrseq: sdcc4_pwrseq { > - pinctrl-names = "default"; > - pinctrl-0 = <&wlan_default_gpios>; > - compatible = "mmc-pwrseq-simple"; > - reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>; > - }; > + sdcc4_pwrseq: pwrseq-sdcc4 { > + pinctrl-names = "default"; > + pinctrl-0 = <&wlan_default_gpios>; > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>; > }; > > /* on board fixed 3.3v supply */ Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts index 5ff0d9a275cc..d6ecfd8addb7 100644 --- a/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts @@ -15,18 +15,11 @@ chosen { stdout-path = "serial0:115200n8"; }; - pwrseq { - #address-cells = <1>; - #size-cells = <1>; - ranges; - compatible = "simple-bus"; - - sdcc4_pwrseq: sdcc4_pwrseq { - pinctrl-names = "default"; - pinctrl-0 = <&wlan_default_gpios>; - compatible = "mmc-pwrseq-simple"; - reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>; - }; + sdcc4_pwrseq: pwrseq-sdcc4 { + pinctrl-names = "default"; + pinctrl-0 = <&wlan_default_gpios>; + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>; }; /* on board fixed 3.3v supply */
There are no need to add additional simple-bus nodes just to populate a single pwrseq device. Pull it up one level into /. While we are at it also fix node name replacing underscore with dash. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-)