| Message ID | 20230312183622.460488-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | de88b1759b35086d5e63736fb604ea2d06486b1a |
| Headers | show |
| Series | None | expand |
Hi, On Sun, Mar 12, 2023 at 11:36 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other > Herobrine boards which use elan,ekth3000 with valid VCC: > > sc7280-herobrine-villager-r1-lte.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Fixes: ee2a62116015 ("arm64: dts: qcom: sc7280: Add device tree for herobrine villager") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Luckily it didn't matter since this regulator is always on, but good to have things described properly. Reviewed-by: Douglas Anderson <dianders@chromium.org>
Quoting Krzysztof Kozlowski (2023-03-12 11:36:16) > The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other > Herobrine boards which use elan,ekth3000 with valid VCC: > > sc7280-herobrine-villager-r1-lte.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > > Fixes: ee2a62116015 ("arm64: dts: qcom: sc7280: Add device tree for herobrine villager") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi index 818d4046d2c7..38c8a3679fcb 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi @@ -33,7 +33,7 @@ trackpad: trackpad@2c { interrupts = <7 IRQ_TYPE_EDGE_FALLING>; hid-descr-addr = <0x20>; - vcc-supply = <&pp3300_z1>; + vdd-supply = <&pp3300_z1>; wakeup-source; };
The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other Herobrine boards which use elan,ekth3000 with valid VCC: sc7280-herobrine-villager-r1-lte.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+' Fixes: ee2a62116015 ("arm64: dts: qcom: sc7280: Add device tree for herobrine villager") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)