diff mbox series

[1/5] arm64: dts: qcom: msm8916-thwc-ufi001c: add function to pin config

Message ID 20230324202244.744271-1-krzysztof.kozlowski@linaro.org
State New
Headers show
Series [1/5] arm64: dts: qcom: msm8916-thwc-ufi001c: add function to pin config | expand

Commit Message

Krzysztof Kozlowski March 24, 2023, 8:22 p.m. UTC
Bindings require pin configuration nodes to have the function, even if
it is GPIO:

  msm8916-thwc-ufi001c.dtb: pinctrl@1000000: sim-ctrl-default-state: 'oneOf' conditional failed, one must be fixed:
    'esim-sel-pins', 'sim-en-pins', 'sim-sel-pins' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts | 3 +++
 1 file changed, 3 insertions(+)

Comments

Bjorn Andersson March 26, 2023, 3:04 a.m. UTC | #1
On Fri, 24 Mar 2023 21:22:40 +0100, Krzysztof Kozlowski wrote:
> Bindings require pin configuration nodes to have the function, even if
> it is GPIO:
> 
>   msm8916-thwc-ufi001c.dtb: pinctrl@1000000: sim-ctrl-default-state: 'oneOf' conditional failed, one must be fixed:
>     'esim-sel-pins', 'sim-en-pins', 'sim-sel-pins' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> 
> [...]

Applied, thanks!

[2/5] arm64: dts: qcom: apq8096-db820c: drop simple-bus from clocks
      commit: 704e26678c8d50d8988e30a47edddbb361e9e973
[3/5] arm64: dts: qcom: msm8994-msft-lumia: drop simple-bus from clocks
      commit: 5574a5022df4cf67fdcf8c94bfbafb2cc296beee
[4/5] arm64: dts: qcom: msm8996-xiaomi: drop simple-bus from clocks
      commit: 338958e30c6897b7978019b5ea3fa1897cd511ba
[5/5] arm64: dts: qcom: sdm630: move DSI opp-table into DSI node
      commit: a2e5260d07555834d14431399cefdd3220b917d6

Best regards,
Bjorn Andersson April 7, 2023, 7:26 p.m. UTC | #2
On Fri, 24 Mar 2023 21:22:40 +0100, Krzysztof Kozlowski wrote:
> Bindings require pin configuration nodes to have the function, even if
> it is GPIO:
> 
>   msm8916-thwc-ufi001c.dtb: pinctrl@1000000: sim-ctrl-default-state: 'oneOf' conditional failed, one must be fixed:
>     'esim-sel-pins', 'sim-en-pins', 'sim-sel-pins' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> 
> [...]

Applied, thanks!

[1/5] arm64: dts: qcom: msm8916-thwc-ufi001c: add function to pin config
      commit: d4a7e17f402de8ebdbae4844b011a5b18f93e341

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts b/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts
index 8433c9710b1c..978f0abcdf8f 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts
@@ -44,18 +44,21 @@  &msmgpio {
 	sim_ctrl_default: sim-ctrl-default-state {
 		esim-sel-pins {
 			pins = "gpio0", "gpio3";
+			function = "gpio";
 			bias-disable;
 			output-low;
 		};
 
 		sim-en-pins {
 			pins = "gpio1";
+			function = "gpio";
 			bias-disable;
 			output-low;
 		};
 
 		sim-sel-pins {
 			pins = "gpio2";
+			function = "gpio";
 			bias-disable;
 			output-high;
 		};