| Message ID | 20230327163249.1081824-3-quic_mohs@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Remove the qdsp6ss register from lpasscc | expand |
On 27/03/2023 18:32, Mohammad Rafi Shaik wrote: > The qdsp6ss memory region 0x3000000 is being shared by ADSP remoteproc > device and lpasscc clock device, hence causing memory conflict and > as the qdsp6ss clocks are being enabled in remoteproc driver, > remove the qdsp6ss register from lpasscc. > > Changing the base address of lpasscc based on the first register memory. > > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> What this patch is not saying is that several clocks are going to disappear as well. It clearly should cause some impact on users of the binding and driver however commit msg lacks explanation here. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml index 6151fdebbff8..9c72b8eca450 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml @@ -33,12 +33,10 @@ properties: reg: items: - - description: LPASS qdsp6ss register - description: LPASS top-cc register reg-names: items: - - const: qdsp6ss - const: top_cc required: @@ -54,10 +52,10 @@ examples: - | #include <dt-bindings/clock/qcom,gcc-sc7280.h> #include <dt-bindings/clock/qcom,lpass-sc7280.h> - clock-controller@3000000 { + clock-controller@3c04000 { compatible = "qcom,sc7280-lpasscc"; - reg = <0x03000000 0x40>, <0x03c04000 0x4>; - reg-names = "qdsp6ss", "top_cc"; + reg = <0x03c04000 0x4>; + reg-names = "top_cc"; clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>; clock-names = "iface"; #clock-cells = <1>;
The qdsp6ss memory region 0x3000000 is being shared by ADSP remoteproc device and lpasscc clock device, hence causing memory conflict and as the qdsp6ss clocks are being enabled in remoteproc driver, remove the qdsp6ss register from lpasscc. Changing the base address of lpasscc based on the first register memory. Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> --- .../devicetree/bindings/clock/qcom,sc7280-lpasscc.yaml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)