| Message ID | 20230815140030.1068590-3-robimarko@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/5] dt-bindings: firmware: qcom,scm: Document SDI disable | expand |
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index abb54df663ea..71d886626233 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -1491,6 +1491,12 @@ static int qcom_scm_probe(struct platform_device *pdev) if (download_mode) qcom_scm_set_download_mode(true); + /* + * Disable SDI if indicated by DT. + */ + if (of_property_read_bool(pdev->dev.of_node, "qcom,sdi-disable")) + qcom_scm_disable_sdi(); + return 0; }
IPQ5018 has SDI (Secure Debug Image) enabled by TZ by default, and that means that WDT being asserted or just trying to reboot will hang the board in the debug mode and only pulling the power and repowering will help. Some IPQ4019 boards like Google WiFI have it enabled as well. So, lets use the boolean DT property to disable SDI during SCM probe. It is important to disable it as soon as possible as we might have a WDT assertion at any time which would then leave the board in debug mode, thus disabling it during SCM removal is not enough. Signed-off-by: Robert Marko <robimarko@gmail.com> --- drivers/firmware/qcom_scm.c | 6 ++++++ 1 file changed, 6 insertions(+)