| Message ID | 20230908152225.432139-7-vignesh.raman@collabora.com |
|---|---|
| State | Accepted |
| Commit | 806f49a6eadc008cb86a110727e394389ccde379 |
| Headers | show |
| Series | drm: ci: fixes | expand |
Il 08/09/23 17:22, Vignesh Raman ha scritto: > Mediatek mt8173 board fails to boot with DA9211 regulator disabled. > Enabling CONFIG_REGULATOR_DA9211=y in drm-ci fixes the issue. > > So enable it in the defconfig since kernel-ci also requires it. > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > > v3: > - New patch in the series to enable CONFIG_REGULATOR_DA9211 in defconfig > > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index a25d783dfb95..ef22b532b63a 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -711,6 +711,7 @@ CONFIG_REGULATOR_AXP20X=y > CONFIG_REGULATOR_BD718XX=y > CONFIG_REGULATOR_BD9571MWV=y > CONFIG_REGULATOR_CROS_EC=y > +CONFIG_REGULATOR_DA9211=m > CONFIG_REGULATOR_FAN53555=y > CONFIG_REGULATOR_GPIO=y > CONFIG_REGULATOR_HI6421V530=y
On 08/09/2023 12:22, Vignesh Raman wrote: > Mediatek mt8173 board fails to boot with DA9211 regulator disabled. > Enabling CONFIG_REGULATOR_DA9211=y in drm-ci fixes the issue. > > So enable it in the defconfig since kernel-ci also requires it. tbh, =m doesn't solve for mesa-ci (since we don't use an initrd, not sure if it solves for kernel-ci. > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.co In any case: Acked-by: Helen Koike <helen.koike@collabora.com> > --- > > v3: > - New patch in the series to enable CONFIG_REGULATOR_DA9211 in defconfig > > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index a25d783dfb95..ef22b532b63a 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -711,6 +711,7 @@ CONFIG_REGULATOR_AXP20X=y > CONFIG_REGULATOR_BD718XX=y > CONFIG_REGULATOR_BD9571MWV=y > CONFIG_REGULATOR_CROS_EC=y > +CONFIG_REGULATOR_DA9211=m Question for the maintainers: would it be acceptable to make it a =y instead of =m here ? Since this is something required for booting. Regards, Helen > CONFIG_REGULATOR_FAN53555=y > CONFIG_REGULATOR_GPIO=y > CONFIG_REGULATOR_HI6421V530=y
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index a25d783dfb95..ef22b532b63a 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -711,6 +711,7 @@ CONFIG_REGULATOR_AXP20X=y CONFIG_REGULATOR_BD718XX=y CONFIG_REGULATOR_BD9571MWV=y CONFIG_REGULATOR_CROS_EC=y +CONFIG_REGULATOR_DA9211=m CONFIG_REGULATOR_FAN53555=y CONFIG_REGULATOR_GPIO=y CONFIG_REGULATOR_HI6421V530=y
Mediatek mt8173 board fails to boot with DA9211 regulator disabled. Enabling CONFIG_REGULATOR_DA9211=y in drm-ci fixes the issue. So enable it in the defconfig since kernel-ci also requires it. Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> --- v3: - New patch in the series to enable CONFIG_REGULATOR_DA9211 in defconfig --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)