| Message ID | 20231003152927.15000-5-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Commit | ade7941a478e797f781040f96ae530a0abf7cbfe |
| Headers | show |
| Series | mfd: qcom-spmi-pmic: fix revid implementation | expand |
Quoting Johan Hovold (2023-10-03 08:29:26) > Add a comment documenting that the spmi_device_from_of() takes a > reference to the embedded struct device that needs to be dropped after > use. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Acked-by: Stephen Boyd <sboyd@kernel.org>
On Tue, 03 Oct 2023 17:29:26 +0200, Johan Hovold wrote: > Add a comment documenting that the spmi_device_from_of() takes a > reference to the embedded struct device that needs to be dropped after > use. > > Applied, thanks! [4/5] spmi: document spmi_device_from_of() refcounting commit: 7db72c01ae2359dbab29f4a60cda49757cf84516 -- Lee Jones [李琼斯]
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index 7313d4c18a04..ca2fd4d72fa6 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -392,6 +392,9 @@ static struct bus_type spmi_bus_type = { * * @np: device node * + * Takes a reference to the embedded struct device which needs to be dropped + * after use. + * * Returns the struct spmi_device associated with a device node or NULL. */ struct spmi_device *spmi_device_from_of(struct device_node *np)
Add a comment documenting that the spmi_device_from_of() takes a reference to the embedded struct device that needs to be dropped after use. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/spmi/spmi.c | 3 +++ 1 file changed, 3 insertions(+)