| Message ID | 20231208004417.3393299-10-dmitry.baryshkov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | soc: qcom: spm: add support for SPM regulator | expand |
On Freitag, 8. Dezember 2023 01:44:15 CET Dmitry Baryshkov wrote: > The SAW2 device should describe the regulator constraints rather than > just declaring that it has the regulator. > > Drop the 'regulator' property. If/when CPU voltage scaling is > implemented for this platform, proper regulator node show be added > instead. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi > b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi index ee202f3f161e..3e1e88d69c2e > 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi > @@ -349,7 +349,6 @@ apcs: syscon@f9011000 { > saw_l2: power-controller@f9012000 { > compatible = "qcom,saw2"; Hi Dmitry, With the patches touching the dt bindings I don't see this "qcom,saw2" compatible without a second one being accepted by the bindings? Do you have a suggestion what do to there? Also thinking about msm8226 which also has a saw_l2. Thanks for working on this old stuff! Regards Luca > reg = <0xf9012000 0x1000>; > - regulator; > }; > > watchdog@f9017000 {
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi index ee202f3f161e..3e1e88d69c2e 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi @@ -349,7 +349,6 @@ apcs: syscon@f9011000 { saw_l2: power-controller@f9012000 { compatible = "qcom,saw2"; reg = <0xf9012000 0x1000>; - regulator; }; watchdog@f9017000 {