diff mbox series

[2/3] arm64: dts: qcom: pmi8950: Remove address from lpg node

Message ID 20240722-pmic-bindings-v1-2-555942b3c4e1@linaro.org
State Superseded
Headers show
Series arm(64): dts: qcom: fix dtbs_check warnings for qcom,spmi-pmic.yaml | expand

Commit Message

Rayyan Ansari July 22, 2024, 11:47 a.m. UTC
Remove the address in both the reg property and node name, as it is
hardcoded in the driver, meaning it is unneeded.

Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
---
 arch/arm64/boot/dts/qcom/pmi8950.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Konrad Dybcio July 22, 2024, 10:46 p.m. UTC | #1
On 22.07.2024 1:47 PM, Rayyan Ansari wrote:
> Remove the address in both the reg property and node name, as it is
> hardcoded in the driver, meaning it is unneeded.
> 
> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
> ---

Well the bindings are opaque to the implementation, and the commit
message could reference adhering to those instead

The contents are fine
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
index b4822cb17a37..4aff437263a2 100644
--- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
@@ -84,9 +84,8 @@  pmic@3 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		pmi8950_pwm: pwm@b000 {
+		pmi8950_pwm: pwm {
 			compatible = "qcom,pmi8950-pwm";
-			reg = <0xb000 0x100>;
 			#pwm-cells = <2>;
 
 			status = "disabled";