diff mbox series

[v2,3/3] ARM: dts: qcom: pma8084: add pon node

Message ID 20240723-pmic-bindings-v2-3-e1cd614f8c4a@linaro.org
State Superseded
Headers show
Series arm(64): dts: qcom: fix dtbs_check warnings for qcom,spmi-pmic.yaml | expand

Commit Message

Rayyan Ansari July 23, 2024, 9:38 a.m. UTC 
Wrap existing pwrkey node inside a pon node, to conform to dt schema.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
---
 arch/arm/boot/dts/qcom/pma8084.dtsi | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

Comments

kernel test robot July 23, 2024, 11:53 p.m. UTC | #1 
Hi Rayyan,

kernel test robot noticed the following build errors:

[auto build test ERROR on dee7f101b64219f512bb2f842227bd04c14efe30]

url:    https://github.com/intel-lab-lkp/linux/commits/Rayyan-Ansari/arm64-dts-qcom-pmi8994-Add-label-to-wled-node/20240723-175020
base:   dee7f101b64219f512bb2f842227bd04c14efe30
patch link:    https://lore.kernel.org/r/20240723-pmic-bindings-v2-3-e1cd614f8c4a%40linaro.org
patch subject: [PATCH v2 3/3] ARM: dts: qcom: pma8084: add pon node
config: arm-randconfig-051-20240723 (https://download.01.org/0day-ci/archive/20240724/202407240711.f7qtQGZG-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
dtschema version: 2024.6.dev4+g23441a4
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240724/202407240711.f7qtQGZG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407240711.f7qtQGZG-lkp@intel.com/

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/qcom/pma8084.dtsi:31.19-20 syntax error
   FATAL ERROR: Unable to parse input tree
Konrad Dybcio July 24, 2024, 9:34 a.m. UTC | #2 
On 24.07.2024 1:53 AM, kernel test robot wrote:
> Hi Rayyan,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on dee7f101b64219f512bb2f842227bd04c14efe30]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Rayyan-Ansari/arm64-dts-qcom-pmi8994-Add-label-to-wled-node/20240723-175020
> base:   dee7f101b64219f512bb2f842227bd04c14efe30
> patch link:    https://lore.kernel.org/r/20240723-pmic-bindings-v2-3-e1cd614f8c4a%40linaro.org
> patch subject: [PATCH v2 3/3] ARM: dts: qcom: pma8084: add pon node
> config: arm-randconfig-051-20240723 (https://download.01.org/0day-ci/archive/20240724/202407240711.f7qtQGZG-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
> dtschema version: 2024.6.dev4+g23441a4
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240724/202407240711.f7qtQGZG-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407240711.f7qtQGZG-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>>> Error: arch/arm/boot/dts/qcom/pma8084.dtsi:31.19-20 syntax error

Need #include <dt-bindings/input/linux-event-codes.h>

Konrad
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom/pma8084.dtsi b/arch/arm/boot/dts/qcom/pma8084.dtsi
index 2985f4805b93..06e9193b87bc 100644
--- a/arch/arm/boot/dts/qcom/pma8084.dtsi
+++ b/arch/arm/boot/dts/qcom/pma8084.dtsi
@@ -19,12 +19,17 @@  rtc@6000 {
 			interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
 		};
 
-		pwrkey@800 {
-			compatible = "qcom,pm8941-pwrkey";
+		pon@800 {
+			compatible = "qcom,pm8941-pon";
 			reg = <0x800>;
-			interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
-			debounce = <15625>;
-			bias-pull-up;
+
+			pwrkey {
+				compatible = "qcom,pm8941-pwrkey";
+				interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
+				debounce = <15625>;
+				bias-pull-up;
+				linux,code = <KEY_POWER>;
+			};
 		};
 
 		pma8084_gpios: gpio@c000 {