From patchwork Tue Oct 22 10:26:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 837611 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E433919ADB0 for ; Tue, 22 Oct 2024 10:27:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729592840; cv=none; b=mN3wacYkHjLkQ7/8gXio3VAbqeVoIuZlbYaV31asX3je+JaZVY+BVJorSNaDaI4yKkN3grG7w1BKYvM6vFZOTh+cX2IWCYPVGZGimGCZM6ucVrtRc1KiDG9s5VSH02wK/JQROdw4FstzI5Rl4q6mvbMESArjG21cKE+tlDXnLW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729592840; c=relaxed/simple; bh=GT1lbn8k9f8u7nUop/6c4FxPN3Au4MB9IOd8jwwntOY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BaUuYTKOpXx1xK0G+w/jDFsAUuKqvIz442uxDDe2lfYCj9oqQo/SwReDK0Lvn/jnsY3nr46SmgoF/TcJIzwZ4Jfl11sRql5I+Dn60OtzNyuA4PCTozabwJFIozTdvf4eY6SzHQePpugoTKmUj/3YOpp1pYMOUXmZg6uv7Wwn/kg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vVgL0Cve; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vVgL0Cve" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43163667f0eso38955105e9.0 for ; Tue, 22 Oct 2024 03:27:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729592835; x=1730197635; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iCneS4918jymns8z073TqPGXPKyYLc8jzTvfksUCAL0=; b=vVgL0CveoSuu9i7Pnng11uNITn42Fw0g/HF3ebDaDqfc8+jk4HL4aJdKJUrlG5U8k5 bvD62gETaoXhiufibEj0Bntgbk7s8FHBZvpvNxxj6tRFrdCD2Cjhf2yam7i0xRJcztjl hStpSNcK8yy446CtF7ktfv1q+Lz1i4ICiiHotkYfoIUJYysG+01eYIDlHS2zGIU+O29H JGs0T6Z09udxaklIoY752t9DkrV54Ql0NGEm6Yed7qr4x5wpG3DFtwwEanNe8EQCGqu9 39dKnDe6ezm6aV7bY0DV22Y7zJFqxkSztjleX7f5dyrp6DCcXrpG3sJht6wHR2+OYDok 2PXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729592835; x=1730197635; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iCneS4918jymns8z073TqPGXPKyYLc8jzTvfksUCAL0=; b=aDNs8Y5oicP0zijZui1tWT9XCcKf/aCCqA4Obr02/I0LjJtkMQjKXWbK8zhX3gSLvF PLguxEapYvhkIfFXdjdk/ukGkZ5PUX8aRRubSwH4orfVdbaJlt1JPFjW72fzwPm1CIe/ ewlXSHS9Py1RR7u3NpDKFXIznbQiEoQ6igAQNyGSmse/lCyxWMN/8eiECbE9QVgpQrBR Ovz7Mv/9JosPmiFapwwGrx/qfiCke5t84DTIExJlgi2pChoc4OIy/9LMb+o1pp3ssIhp TrlOTMpeZ/l5MBhmjtryyVwliqKBiO4U3CWWrJGGgyB3jGdujhmdSjSVG4tPdCKPz1Mr wvuw== X-Gm-Message-State: AOJu0YxqJ6FFuXs8bzOHblH+WSZxAHf+97/zz3yvcbDutOXcUaxGv6E1 H+rCnG3EErP2uzI2q19YlDk/lgoUMEJgiSLjhTI4CAm6cRMUdspY7LYMX5V1fwID70Xdr5yWx9a / X-Google-Smtp-Source: AGHT+IEE9894QnivsKTVhLD7g4Fmpoai4Ob88SLkK/Yn+Y1ilJsK/eI0RtauyuMrgjPR6B5mfCPy+Q== X-Received: by 2002:a5d:5266:0:b0:37d:509e:8742 with SMTP id ffacd0b85a97d-37ea2140fe2mr8679991f8f.1.1729592834903; Tue, 22 Oct 2024 03:27:14 -0700 (PDT) Received: from [127.0.1.1] ([82.76.168.176]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0b94048sm6285184f8f.85.2024.10.22.03.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 03:27:14 -0700 (PDT) From: Abel Vesa Date: Tue, 22 Oct 2024 13:26:55 +0300 Subject: [PATCH v3 2/4] usb: typec: Add support for Parade PS8830 Type-C Retimer Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241022-x1e80100-ps8830-v3-2-68a95f351e99@linaro.org> References: <20241022-x1e80100-ps8830-v3-0-68a95f351e99@linaro.org> In-Reply-To: <20241022-x1e80100-ps8830-v3-0-68a95f351e99@linaro.org> To: Heikki Krogerus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rajendra Nayak , Sibi Sankar , Johan Hovold , Dmitry Baryshkov , Trilok Soni , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Abel Vesa X-Mailer: b4 0.15-dev-dedf8 X-Developer-Signature: v=1; a=openpgp-sha256; l=13620; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=GT1lbn8k9f8u7nUop/6c4FxPN3Au4MB9IOd8jwwntOY=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBnF336ZfXkiqHeFt96rNsKu6nlQAT6wwo1jg/Sd TaNpCW6qTSJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZxd9+gAKCRAbX0TJAJUV VnXPEACimn3hZrXZ9WAD2w9hCxvvXDt/nc4ON25A68jKG+s/iodjy/ElBvbET+fBGZ8G6+yl0Mh zD4BcrC21sgZ4J2XpzoWlXemmL+zM0jSrPvheHaEXtv14LtomD8tf9uTUZEy414X3i07J7WTEub MFI2Fw2ByMU2MXnW8NqVCxfaMUlOOKZHv6JxMJba4xRiHPY5owWtQ2uCMeiqNaVg/lEoRfRr65e FYnKGv5EBSGJ6H3vfqOtQwUOAbrQKi/zOt1xmYPXrSGy41N0SljgfUlpQIfUieF604eZATROxXf XygvW4FS4BgtaVvl3a9cLkYE999o3ot3ySemj7iNDt2TlKMm1Wot5aEzDInAYWmNpqGXe2xb9wD QS4c0RRaLYdsvcZKIoZUGik23iER4bcSEmZ7YlzkBE3MMmyYlTakGEy7bna44prxu0jjiP7eAw+ Z91+jQg37fPl2r/HNSkWMR9Z5IRQgUG9T3Oe45PAKi1YnhuVIj7FQe939LB633wjW9CYl7Tenr4 vRjoKfpM0PioJXJbY3YzgNnIp9AiDKkyCh7PoWrxAU91n/CZIke2iiKGQVbYzaAOu6atiSX21S8 kytiR5kzpohslXvBDFnRGCw+wgVIgli7MsBxGdMGwe+gDtxTCY8o6LOvL2oBjplSzbBMNe9Lc4e 7Qfm5LIJglQx7/w== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE The Parade PS8830 is a Type-C muti-protocol retimer controlled over I2C. It provides both altmode and orientation handling. Add a driver with support for the following modes: - DP 4lanes - DP 2lanes + USB3 - USB3 Signed-off-by: Abel Vesa --- drivers/usb/typec/mux/Kconfig | 10 + drivers/usb/typec/mux/Makefile | 1 + drivers/usb/typec/mux/ps8830.c | 423 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 434 insertions(+) diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig index ce7db6ad30572a0a74890f5f11944fb3ff07f635..48613b67f1c5dacd14d54baf91c3066377cf97be 100644 --- a/drivers/usb/typec/mux/Kconfig +++ b/drivers/usb/typec/mux/Kconfig @@ -56,6 +56,16 @@ config TYPEC_MUX_NB7VPQ904M Say Y or M if your system has a On Semiconductor NB7VPQ904M Type-C redriver chip found on some devices with a Type-C port. +config TYPEC_MUX_PS8830 + tristate "Parade PS8830 Type-C retimer driver" + depends on I2C + depends on DRM || DRM=n + select DRM_AUX_BRIDGE if DRM_BRIDGE && OF + select REGMAP_I2C + help + Say Y or M if your system has a Parade PS8830 Type-C retimer chip + found on some devices with a Type-C port. + config TYPEC_MUX_PTN36502 tristate "NXP PTN36502 Type-C redriver driver" depends on I2C diff --git a/drivers/usb/typec/mux/Makefile b/drivers/usb/typec/mux/Makefile index bb96f30267af05b33b9277dcf1cc0e1527d2dcdd..4b23b12cfe45a0ff8a37f38c7ba050f572d556e7 100644 --- a/drivers/usb/typec/mux/Makefile +++ b/drivers/usb/typec/mux/Makefile @@ -6,5 +6,6 @@ obj-$(CONFIG_TYPEC_MUX_PI3USB30532) += pi3usb30532.o obj-$(CONFIG_TYPEC_MUX_INTEL_PMC) += intel_pmc_mux.o obj-$(CONFIG_TYPEC_MUX_IT5205) += it5205.o obj-$(CONFIG_TYPEC_MUX_NB7VPQ904M) += nb7vpq904m.o +obj-$(CONFIG_TYPEC_MUX_PS8830) += ps8830.o obj-$(CONFIG_TYPEC_MUX_PTN36502) += ptn36502.o obj-$(CONFIG_TYPEC_MUX_WCD939X_USBSS) += wcd939x-usbss.o diff --git a/drivers/usb/typec/mux/ps8830.c b/drivers/usb/typec/mux/ps8830.c new file mode 100644 index 0000000000000000000000000000000000000000..df83b2f3b562aec3794a27ca643325898c45c6ae --- /dev/null +++ b/drivers/usb/typec/mux/ps8830.c @@ -0,0 +1,423 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Parade PS8830 usb retimer driver + * + * Copyright (C) 2024 Linaro Ltd. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct ps8830_retimer { + struct i2c_client *client; + struct gpio_desc *reset_gpio; + struct regmap *regmap; + struct typec_switch_dev *sw; + struct typec_retimer *retimer; + struct clk *xo_clk; + struct regulator *vdd_supply; + struct regulator *vdd33_supply; + struct regulator *vdd33_cap_supply; + struct regulator *vddat_supply; + struct regulator *vddar_supply; + struct regulator *vddio_supply; + + struct typec_switch *typec_switch; + struct typec_mux *typec_mux; + + struct mutex lock; /* protect non-concurrent retimer & switch */ + + enum typec_orientation orientation; + unsigned long mode; + unsigned int svid; +}; + +static void ps8830_write(struct ps8830_retimer *retimer, int cfg0, int cfg1, int cfg2) +{ + regmap_write(retimer->regmap, 0x0, cfg0); + regmap_write(retimer->regmap, 0x1, cfg1); + regmap_write(retimer->regmap, 0x2, cfg2); +} + +static void ps8830_configure(struct ps8830_retimer *retimer, int cfg0, int cfg1, int cfg2) +{ + /* Write safe-mode config before switching to new config */ + ps8830_write(retimer, 0x1, 0x0, 0x0); + + ps8830_write(retimer, cfg0, cfg1, cfg2); +} + +static int ps8380_set(struct ps8830_retimer *retimer) +{ + int cfg0 = 0x00; + int cfg1 = 0x00; + int cfg2 = 0x00; + + if (retimer->orientation == TYPEC_ORIENTATION_NONE || + retimer->mode == TYPEC_STATE_SAFE) { + ps8830_write(retimer, 0x1, 0x0, 0x0); + return 0; + } + + if (retimer->mode != TYPEC_STATE_USB && retimer->svid != USB_TYPEC_DP_SID) + return -EINVAL; + + if (retimer->orientation == TYPEC_ORIENTATION_NORMAL) + cfg0 = 0x01; + else + cfg0 = 0x03; + + switch (retimer->mode) { + case TYPEC_STATE_USB: + cfg0 |= 0x20; + break; + + case TYPEC_DP_STATE_C: + cfg1 = 0x85; + break; + + case TYPEC_DP_STATE_D: + cfg0 |= 0x20; + cfg1 = 0x85; + break; + + case TYPEC_DP_STATE_E: + cfg1 = 0x81; + break; + + default: + return -EOPNOTSUPP; + } + + ps8830_configure(retimer, cfg0, cfg1, cfg2); + + return 0; +} + +static int ps8830_sw_set(struct typec_switch_dev *sw, + enum typec_orientation orientation) +{ + struct ps8830_retimer *retimer = typec_switch_get_drvdata(sw); + int ret = 0; + + ret = typec_switch_set(retimer->typec_switch, orientation); + if (ret) + return ret; + + mutex_lock(&retimer->lock); + + if (retimer->orientation != orientation) { + retimer->orientation = orientation; + + ret = ps8380_set(retimer); + } + + mutex_unlock(&retimer->lock); + + return ret; +} + +static int ps8830_retimer_set(struct typec_retimer *rtmr, + struct typec_retimer_state *state) +{ + struct ps8830_retimer *retimer = typec_retimer_get_drvdata(rtmr); + struct typec_mux_state mux_state; + int ret = 0; + + mutex_lock(&retimer->lock); + + if (state->mode != retimer->mode) { + retimer->mode = state->mode; + + if (state->alt) + retimer->svid = state->alt->svid; + else + retimer->svid = 0; // No SVID + + ret = ps8380_set(retimer); + } + + mutex_unlock(&retimer->lock); + + if (ret) + return ret; + + mux_state.alt = state->alt; + mux_state.data = state->data; + mux_state.mode = state->mode; + + return typec_mux_set(retimer->typec_mux, &mux_state); +} + +static int ps8830_enable_vregs(struct ps8830_retimer *retimer) +{ + struct device *dev = &retimer->client->dev; + int ret; + + ret = regulator_enable(retimer->vdd33_supply); + if (ret) { + dev_err(dev, "cannot enable VDD 3.3V regulator: %d\n", ret); + return ret; + } + + ret = regulator_enable(retimer->vdd33_cap_supply); + if (ret) { + dev_err(dev, "cannot enable VDD 3.3V CAP regulator: %d\n", ret); + goto err_vdd33_disable; + } + + usleep_range(4000, 10000); + + ret = regulator_enable(retimer->vdd_supply); + if (ret) { + dev_err(dev, "cannot enable VDD regulator: %d\n", ret); + goto err_vdd33_cap_disable; + } + + ret = regulator_enable(retimer->vddar_supply); + if (ret) { + dev_err(dev, "cannot enable VDD AR regulator: %d\n", ret); + goto err_vdd_disable; + } + + ret = regulator_enable(retimer->vddat_supply); + if (ret) { + dev_err(dev, "cannot enable VDD AT regulator: %d\n", ret); + goto err_vddar_disable; + } + + ret = regulator_enable(retimer->vddio_supply); + if (ret) { + dev_err(dev, "cannot enable VDD IO regulator: %d\n", ret); + goto err_vddat_disable; + } + + return 0; + +err_vddat_disable: + regulator_disable(retimer->vddat_supply); +err_vddar_disable: + regulator_disable(retimer->vddar_supply); +err_vdd_disable: + regulator_disable(retimer->vdd_supply); +err_vdd33_cap_disable: + regulator_disable(retimer->vdd33_cap_supply); +err_vdd33_disable: + regulator_disable(retimer->vdd33_supply); + + return ret; +} + +static int ps8830_get_vregs(struct ps8830_retimer *retimer) +{ + struct device *dev = &retimer->client->dev; + + retimer->vdd_supply = devm_regulator_get(dev, "vdd"); + if (IS_ERR(retimer->vdd_supply)) + return dev_err_probe(dev, PTR_ERR(retimer->vdd_supply), + "failed to get VDD\n"); + + retimer->vdd33_supply = devm_regulator_get(dev, "vdd33"); + if (IS_ERR(retimer->vdd33_supply)) + return dev_err_probe(dev, PTR_ERR(retimer->vdd33_supply), + "failed to get VDD 3.3V\n"); + + retimer->vdd33_cap_supply = devm_regulator_get(dev, "vdd33-cap"); + if (IS_ERR(retimer->vdd33_cap_supply)) + return dev_err_probe(dev, PTR_ERR(retimer->vdd33_cap_supply), + "failed to get VDD CAP 3.3V\n"); + + retimer->vddat_supply = devm_regulator_get(dev, "vddat"); + if (IS_ERR(retimer->vddat_supply)) + return dev_err_probe(dev, PTR_ERR(retimer->vddat_supply), + "failed to get VDD AT\n"); + + retimer->vddar_supply = devm_regulator_get(dev, "vddar"); + if (IS_ERR(retimer->vddar_supply)) + return dev_err_probe(dev, PTR_ERR(retimer->vddar_supply), + "failed to get VDD AR\n"); + + retimer->vddio_supply = devm_regulator_get(dev, "vddio"); + if (IS_ERR(retimer->vddio_supply)) + return dev_err_probe(dev, PTR_ERR(retimer->vddio_supply), + "failed to get VDD IO\n"); + + return 0; +} + +static const struct regmap_config ps8830_retimer_regmap = { + .max_register = 0x1f, + .reg_bits = 8, + .val_bits = 8, + .cache_type = REGCACHE_FLAT, +}; + +static int ps8830_retimer_probe(struct i2c_client *client) +{ + struct device *dev = &client->dev; + struct typec_switch_desc sw_desc = { }; + struct typec_retimer_desc rtmr_desc = { }; + struct ps8830_retimer *retimer; + bool skip_reset = false; + int ret; + + retimer = devm_kzalloc(dev, sizeof(*retimer), GFP_KERNEL); + if (!retimer) + return -ENOMEM; + + retimer->client = client; + + mutex_init(&retimer->lock); + + if (of_property_read_bool(dev->of_node, "ps8830,boot-on")) + skip_reset = true; + + retimer->regmap = devm_regmap_init_i2c(client, &ps8830_retimer_regmap); + if (IS_ERR(retimer->regmap)) { + ret = PTR_ERR(retimer->regmap); + dev_err(dev, "failed to allocate register map: %d\n", ret); + return ret; + } + + ret = ps8830_get_vregs(retimer); + if (ret) + return ret; + + retimer->xo_clk = devm_clk_get(dev, "xo"); + if (IS_ERR(retimer->xo_clk)) + return dev_err_probe(dev, PTR_ERR(retimer->xo_clk), + "failed to get xo clock\n"); + + retimer->reset_gpio = devm_gpiod_get(dev, "reset", + skip_reset ? GPIOD_OUT_LOW : GPIOD_OUT_HIGH); + if (IS_ERR(retimer->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(retimer->reset_gpio), + "failed to get reset gpio\n"); + + retimer->typec_switch = fwnode_typec_switch_get(dev->fwnode); + if (IS_ERR(retimer->typec_switch)) + return dev_err_probe(dev, PTR_ERR(retimer->typec_switch), + "failed to acquire orientation-switch\n"); + + retimer->typec_mux = fwnode_typec_mux_get(dev->fwnode); + if (IS_ERR(retimer->typec_mux)) { + ret = dev_err_probe(dev, PTR_ERR(retimer->typec_mux), + "failed to acquire mode-mux\n"); + goto err_switch_put; + } + + sw_desc.drvdata = retimer; + sw_desc.fwnode = dev_fwnode(dev); + sw_desc.set = ps8830_sw_set; + + ret = drm_aux_bridge_register(dev); + if (ret) + goto err_mux_put; + + retimer->sw = typec_switch_register(dev, &sw_desc); + if (IS_ERR(retimer->sw)) { + ret = PTR_ERR(retimer->sw); + dev_err(dev, "failed to register typec switch: %d\n", ret); + goto err_aux_bridge_unregister; + } + + rtmr_desc.drvdata = retimer; + rtmr_desc.fwnode = dev_fwnode(dev); + rtmr_desc.set = ps8830_retimer_set; + + retimer->retimer = typec_retimer_register(dev, &rtmr_desc); + if (IS_ERR(retimer->retimer)) { + ret = PTR_ERR(retimer->retimer); + dev_err(dev, "failed to register typec retimer: %d\n", ret); + goto err_switch_unregister; + } + + ret = clk_prepare_enable(retimer->xo_clk); + if (ret) { + dev_err(dev, "failed to enable XO: %d\n", ret); + goto err_retimer_unregister; + } + + ret = ps8830_enable_vregs(retimer); + if (ret) + goto err_clk_disable; + + /* delay needed as per datasheet */ + usleep_range(4000, 14000); + + if (!skip_reset) + gpiod_set_value(retimer->reset_gpio, 0); + + return 0; + +err_clk_disable: + clk_disable_unprepare(retimer->xo_clk); +err_retimer_unregister: + typec_retimer_unregister(retimer->retimer); +err_switch_unregister: + typec_switch_unregister(retimer->sw); +err_aux_bridge_unregister: + if (!skip_reset) + gpiod_set_value(retimer->reset_gpio, 1); + + clk_disable_unprepare(retimer->xo_clk); +err_mux_put: + typec_mux_put(retimer->typec_mux); +err_switch_put: + typec_switch_put(retimer->typec_switch); + + return ret; +} + +static void ps8830_retimer_remove(struct i2c_client *client) +{ + struct ps8830_retimer *retimer = i2c_get_clientdata(client); + + typec_retimer_unregister(retimer->retimer); + typec_switch_unregister(retimer->sw); + + gpiod_set_value(retimer->reset_gpio, 1); + + regulator_disable(retimer->vddio_supply); + regulator_disable(retimer->vddat_supply); + regulator_disable(retimer->vddar_supply); + regulator_disable(retimer->vdd_supply); + regulator_disable(retimer->vdd33_cap_supply); + regulator_disable(retimer->vdd33_supply); + + clk_disable_unprepare(retimer->xo_clk); + + typec_mux_put(retimer->typec_mux); + typec_switch_put(retimer->typec_switch); +} + +static const struct of_device_id ps8830_retimer_of_table[] = { + { .compatible = "parade,ps8830" }, + { } +}; +MODULE_DEVICE_TABLE(of, ps8830_retimer_of_table); + +static struct i2c_driver ps8830_retimer_driver = { + .driver = { + .name = "ps8830_retimer", + .of_match_table = ps8830_retimer_of_table, + }, + .probe = ps8830_retimer_probe, + .remove = ps8830_retimer_remove, +}; + +module_i2c_driver(ps8830_retimer_driver); + +MODULE_DESCRIPTION("Parade PS8830 Type-C Retimer driver"); +MODULE_LICENSE("GPL");