From patchwork Tue Oct 29 07:52:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 839376 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 586A92010F4; Tue, 29 Oct 2024 07:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730188430; cv=none; b=OBOAq9HWTofAEtkwuJJT2Si7tZzeUjetOA5qDew7MNiYXEFFp3wzC44DJG9OIk1Vi9x1LcNtfIx7RmkwB8ASXKDRocdriraXW7sf6BPyeW5AoDOj/cwJbmeghPr1MAPyVt5SVfiu+LHUfJHW8uuiKlxoLinCHoSBTEIg41iveg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730188430; c=relaxed/simple; bh=rYKLJG/cGy6PWVHFLv8OcSjLD+SMiwoShTSmF2XtG7I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Nvx0KzWpjNxWZCey5Ini7b0HsEM289SwX+tlBCh/wNMdzsxGr9luplpCiOfLauVqgKx2/pvAnVCmdVsiBrefOHjFOGq+jhGDHJjLWDZs2eK/++mxBSoHGI6y1tFTx57TCY56+7PyBI4t3zdB5uPxWL1YH5W0SiabqV7szvsulV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e4KhMT1X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e4KhMT1X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2B6AC4CECD; Tue, 29 Oct 2024 07:53:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730188429; bh=rYKLJG/cGy6PWVHFLv8OcSjLD+SMiwoShTSmF2XtG7I=; h=From:To:Cc:Subject:Date:From; b=e4KhMT1XFmyQP9rLTR1paaw4xQ/HGRLlixTAL5qcbS1HymUrTToiIEc0IfZepgFL2 eIjTVRQkQw6yVHDyEz6maRNsySlc6gI1DSiSNbY/ZTgYRYM5WpFxcmXiJplOEXVN8V kFKDF2B2L5nLXxe/fwt37QYZA/tkP2VvEaU4tkgX9zPx1MnXb5C9b6Flwbp3fby2b9 fxEFe6f0+cC3KEZsdWpzq9c4VNGK2nMsttlsXPfAWpT8cGbWY2KiScdYTJNZD0Vv19 +NoL02863UEjLl7mzvXevR5pfQxYMA3w85v3Rz+RKM3XcJIM5Z6OyXM3B7btcK4w4K qP0iqhA5LQ4hg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1t5h3I-0000000058U-25Z4; Tue, 29 Oct 2024 08:54:08 +0100 From: Johan Hovold To: Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , Stephan Gerhold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2] arm64: dts: x1e80100-crd: describe HID supplies Date: Tue, 29 Oct 2024 08:52:58 +0100 Message-ID: <20241029075258.19642-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add the missing HID supplies to avoid relying on other consumers to keep them on. This also avoids the following warnings on boot: i2c_hid_of 0-0010: supply vdd not found, using dummy regulator i2c_hid_of 0-0010: supply vddl not found, using dummy regulator i2c_hid_of 1-0015: supply vdd not found, using dummy regulator i2c_hid_of 1-0015: supply vddl not found, using dummy regulator i2c_hid_of 1-003a: supply vdd not found, using dummy regulator i2c_hid_of 1-003a: supply vddl not found, using dummy regulator Note that VREG_MISC_3P3 is also used for things like the fingerprint reader which are not yet fully described so mark the regulator as always on for now. Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") Reviewed-by: Abel Vesa Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- Changes in v2: - amend the pin config in order not to rely on the boot firmware arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 40 +++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index b50accb220e5..c5478fd08e51 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -8,6 +8,7 @@ #include #include #include +#include #include #include "x1e80100.dtsi" @@ -277,6 +278,23 @@ vreg_edp_3p3: regulator-edp-3p3 { regulator-boot-on; }; + vreg_misc_3p3: regulator-misc-3p3 { + compatible = "regulator-fixed"; + + regulator-name = "VREG_MISC_3P3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + gpio = <&pm8550ve_8_gpios 6 GPIO_ACTIVE_HIGH>; + enable-active-high; + + pinctrl-names = "default"; + pinctrl-0 = <&misc_3p3_reg_en>; + + regulator-boot-on; + regulator-always-on; + }; + vreg_nvme: regulator-nvme { compatible = "regulator-fixed"; @@ -691,6 +709,9 @@ touchpad@15 { hid-descr-addr = <0x1>; interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>; + vdd-supply = <&vreg_misc_3p3>; + vddl-supply = <&vreg_l12b_1p2>; + pinctrl-0 = <&tpad_default>; pinctrl-names = "default"; @@ -704,6 +725,9 @@ keyboard@3a { hid-descr-addr = <0x1>; interrupts-extended = <&tlmm 67 IRQ_TYPE_LEVEL_LOW>; + vdd-supply = <&vreg_misc_3p3>; + vddl-supply = <&vreg_l12b_1p2>; + pinctrl-0 = <&kybd_default>; pinctrl-names = "default"; @@ -723,6 +747,9 @@ touchscreen@10 { hid-descr-addr = <0x1>; interrupts-extended = <&tlmm 51 IRQ_TYPE_LEVEL_LOW>; + vdd-supply = <&vreg_misc_3p3>; + vddl-supply = <&vreg_l15b_1p8>; + pinctrl-0 = <&ts0_default>; pinctrl-names = "default"; }; @@ -856,6 +883,19 @@ &pcie6a_phy { status = "okay"; }; +&pm8550ve_8_gpios { + misc_3p3_reg_en: misc-3p3-reg-en-state { + pins = "gpio6"; + function = "normal"; + bias-disable; + input-disable; + output-enable; + drive-push-pull; + power-source = <1>; /* 1.8 V */ + qcom,drive-strength = ; + }; +}; + &pmc8380_3_gpios { edp_bl_en: edp-bl-en-state { pins = "gpio4";