| Message ID | 20241130-fix-board-clocks-v2-22-b9a35858657e@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: move board clocks to SoC DTSI files | expand |
On 30/11/2024 02:44, Dmitry Baryshkov wrote: > IPQ5424 is one of the platforms where board-level clocks (XO, sleep) > definitions are split between the SoC dtsi file and the board file. > This is not optimal, as the clocks are a part of the SoC + PMICs design. > Frequencies are common for the whole set of devices using the same SoC. > Remove the split and move frequencies to the SoC DTSI file. > > Suggested-by: Bjorn Andersson <andersson@kernel.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Nacked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts index d4d31026a02624fb5ca08cd7fc6dde9d10fc9b81..e78d2dd9148d7daaffc007322493577ff2ca6c7a 100644 --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts @@ -18,10 +18,6 @@ aliases { }; }; -&sleep_clk { - clock-frequency = <32000>; -}; - &tlmm { sdc_default_state: sdc-default-state { clk-pins { @@ -52,8 +48,3 @@ &uart1 { pinctrl-names = "default"; status = "okay"; }; - -&xo_board { - clock-frequency = <24000000>; -}; - diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi index 5e219f9004123caa45e5e9e303662e3e92a56c57..85bfe5edd9ddc2da0897aa5a4d43a68116007d9a 100644 --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi @@ -20,11 +20,13 @@ clocks { sleep_clk: sleep-clk { compatible = "fixed-clock"; #clock-cells = <0>; + clock-frequency = <32000>; }; xo_board: xo-board-clk { compatible = "fixed-clock"; #clock-cells = <0>; + clock-frequency = <24000000>; }; };
IPQ5424 is one of the platforms where board-level clocks (XO, sleep) definitions are split between the SoC dtsi file and the board file. This is not optimal, as the clocks are a part of the SoC + PMICs design. Frequencies are common for the whole set of devices using the same SoC. Remove the split and move frequencies to the SoC DTSI file. Suggested-by: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 9 --------- arch/arm64/boot/dts/qcom/ipq5424.dtsi | 2 ++ 2 files changed, 2 insertions(+), 9 deletions(-)