From patchwork Wed Feb 26 06:51:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maulik Shah X-Patchwork-Id: 868600 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E5572686AA for ; Wed, 26 Feb 2025 06:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740552702; cv=none; b=M1SNLLc2p3VJpb6VWqRu/JaRTSIfFrs/aAUmdpViyZM5C60GpslITH7ZQiGbmkWIDO828EahetWN8fzAb+QgTMlajlDDZ7Cw4B/M7PVGaglPSkBxFbx0HNS38G62eErG9qZEgabDxpj36jQhhKkiSFkAy340qautaPTsVQwDRX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740552702; c=relaxed/simple; bh=Nr2XquDEcWIZ32z5BYr9PlI+GG2FDN7caaV4ha/WbSw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=dXnTNaHPiP/EuxOVUz4UiUNAbqEG5T5zPNUQ+ZXbiCcwIEZyh04RxLe5wy0UgAoPSepZCIvvihFue/LjC/VdyYr2dl63alvMC3mMCO+DO6Phb5o97d6N8lVU4qXWMpfgcHeFPJ5hlQ8F5pazQ4D/3O05Xlq97cS8U+qO9PW6mUw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BH6DQXoY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BH6DQXoY" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51PMWsYE011784 for ; Wed, 26 Feb 2025 06:51:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=FiRAMpMCidsWJ+AiRYeRMK aPo0YDrXFe78L3MNnq64k=; b=BH6DQXoYwvAs0OqRJ//NyeFaXkOod3Pk5PLbPP Fcjd8aCvQXTSR1JR22/unUxXZeNyLtuGPphtKhhrR4fMJKxglsJD4gJjvIZZX4AY opOhqg5KaGAfsvm/rtWY34q//o4EgTwlECFINJKy6s064AzQOElr6nrxYQl5VOTo aAtFEDVDf6kTl+RP6LcRtbqpG7RWSbVQhi31SOdzvZXuKnhI68uIFv0zGe+2lRSx AETZ1CTkNp6lIy0gl7+Vwikitj3ehmqQxXHbDiDETzjJkhpZ5W31jpV+c4r/MGuw RMZ+/1XF0sL7UKxv8nH5TT5TFHGUnt95U1Tv7OlK0yRSTR/Q== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 451prmh12t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 26 Feb 2025 06:51:38 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-220d8599659so119732425ad.0 for ; Tue, 25 Feb 2025 22:51:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740552697; x=1741157497; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FiRAMpMCidsWJ+AiRYeRMKaPo0YDrXFe78L3MNnq64k=; b=OnCH0quO94ExvTzLGAejM0TlJmhTzesuIRqtGrt6Cn4kvRHoJPqUMiXg8WiwYr+v+l NCSMLoGPYaZP25UWJCp+CDDlBv41kf7hZnIDRb4KXdLpZ9hKU+XrPXCEjXGVj7Vo7yVA 6w6yahYJ5Zlh+Sw/np2MEC2DB98MMOroSnePGQWdAGAYIDWsPUHqrFzyM//GOJhcXg6T 9/O5Gk8gs7FbUAhyrBRle0UCDHZYhrYX8HKT1rUy3LddygukW74SCqDJzmKbLQmJjKvc jCAsxl7lGsAyEr1pFz4KbXD6qsC4aXP24QrbuYeq118/Rp2JQdoSxMuvRKVzJgGQoZGU +bjA== X-Forwarded-Encrypted: i=1; AJvYcCWuJsZVanLbqomnW5TYqSNrS8oO3gajP7JS8ABjVYQtqbqhfGGc8vixfX50duiJ7Kj4nizx8EBLWmNLMn8h@vger.kernel.org X-Gm-Message-State: AOJu0Yzw0VdXghai7Jx7V2hWlPCCZ4FPMW35KE+C35DR/3mTBwZD94/u PMl9yBUF91uVdXYtybWfZ/8RY+TJKKVAxwNiu9jOyDXjA7WfE8LetA1sTa1yyDumYZj9zBsWWum YONmw7ii8TNXV6tTITQEf5q+KUI7F98PIK3Y0Urm0M0Swt/4p8SQi1ssmbqf7trLO X-Gm-Gg: ASbGncskJP0Rd8eZq1r8Vai9VaInG8j3POIHIVpIbJi11Z19eYvQeD2aa/931QOgo9e 2OS/TttjZv5U6vu8i4Waft7mx95bROpLwyyqINrM1oKYrTL+JgE7VqScueDTqoCyoBvnePm7s2r D+zr04WUG/7RQJn1ssJlM5JtcAXu4+od4NZbXD0F9luTYSCuHFjTdZ+BCIHW2wTAyIOGuHrm8bM aTKHFKdXmei23U7tKKLZrUxXB7x34T1ANpoJo+FVtbqvwoQTSN79S652mnpyNuLq7oNLC6MGgNt 983WH5k4Ty/cQePBHPja1YIgKJPZvQ== X-Received: by 2002:a17:902:f706:b0:215:b058:289c with SMTP id d9443c01a7336-22320061fd6mr33779395ad.8.1740552697272; Tue, 25 Feb 2025 22:51:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHV35z8kbWqbSL9vh/1yfYoUXaFR7vWmBJtbtyfB+VFciOqC8XT2KD2pNgEqDPEDsoJaF+wug== X-Received: by 2002:a17:902:f706:b0:215:b058:289c with SMTP id d9443c01a7336-22320061fd6mr33779145ad.8.1740552696890; Tue, 25 Feb 2025 22:51:36 -0800 (PST) Received: from [10.213.103.17] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2230a0aec2dsm25207555ad.221.2025.02.25.22.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 22:51:36 -0800 (PST) From: Maulik Shah Date: Wed, 26 Feb 2025 12:21:27 +0530 Subject: [PATCH v2] arm64: dts: qcom: sm8750: Fix cluster hierarchy for idle states Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250226-sm8750_cluster_idle-v2-1-ef0ac81e242f@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAO65vmcC/32NUQ6CMBBEr0L225K2Wqh+eQ9DCJatbAJUu0A0h LtbOYA/k7xJ5s0KjJGQ4ZKtEHEhpjAm0IcMXNeMDxTUJgYttZFaWcGDLY2sXT/zhLGmtkdReDw ai3frSoS0fEb09N6ttypxRzyF+NlPFvVr//sWJZQwRp9bL6UvTvoamPPX3PQuDEOeAqpt277mM dBovQAAAA== X-Change-ID: 20250218-sm8750_cluster_idle-6fe358eb8c7e To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jishnu Prakash , Raviteja Laggyshetty , Taniya Das , Melody Olvera Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_lsrao@quicinc.com, Maulik Shah X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1740552692; l=3306; i=maulik.shah@oss.qualcomm.com; s=20240109; h=from:subject:message-id; bh=Nr2XquDEcWIZ32z5BYr9PlI+GG2FDN7caaV4ha/WbSw=; b=ZT/bM7gO9LUVNNS40pPZ5AyoHIVjlAU0uvW2M5t5IO6XhJ8jPDotS7MoBj36K7mPsdsfAb7B4 sKLUdVl3tRvC6qZhZnP5ZAZlnf86hMFVm+G6OAAbYfsD4TzneZ+zenr X-Developer-Key: i=maulik.shah@oss.qualcomm.com; a=ed25519; pk=bd9h5FIIliUddIk8p3BlQWBlzKEQ/YW5V+fe759hTWQ= X-Proofpoint-ORIG-GUID: crr2CEIO-ayMN7fgUkZpta12EIWYeyfV X-Proofpoint-GUID: crr2CEIO-ayMN7fgUkZpta12EIWYeyfV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-25_08,2025-02-26_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 impostorscore=0 adultscore=0 mlxlogscore=687 spamscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502260053 SM8750 have two different clusters. cluster0 have CPU 0-5 as child and cluster1 have CPU 6-7 as child. Each cluster requires its own idle state and power domain in order to achieve complete domain sleep state. However only single cluster idle state is added mapping CPU 0-7 to the same power domain. Fix this by correctly mapping each CPU to respective cluster power domain and make cluster1 power domain use same domain idle state as cluster0 since both use same idle state parameters. Fixes: 068c3d3c83be ("arm64: dts: qcom: Add base SM8750 dtsi") Signed-off-by: Maulik Shah --- Changes in v2: - Use single cluster domain idle state and point cluster0/1 to use same - Link to v1: https://lore.kernel.org/r/20250218-sm8750_cluster_idle-v1-1-5529df00f642@oss.qualcomm.com --- arch/arm64/boot/dts/qcom/sm8750.dtsi | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) --- base-commit: e5d3fd687aac5eceb1721fa92b9f49afcf4c3717 change-id: 20250218-sm8750_cluster_idle-6fe358eb8c7e Best regards, diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi index 3bbd7d18598ee0a3a0d5130c03a3166e1fc14d82..d08a2dbeb0f7924662c9a1de61df95561397c2a3 100644 --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi @@ -233,53 +233,59 @@ psci { cpu_pd0: power-domain-cpu0 { #power-domain-cells = <0>; - power-domains = <&cluster_pd>; + power-domains = <&cluster0_pd>; domain-idle-states = <&cluster0_c4>; }; cpu_pd1: power-domain-cpu1 { #power-domain-cells = <0>; - power-domains = <&cluster_pd>; + power-domains = <&cluster0_pd>; domain-idle-states = <&cluster0_c4>; }; cpu_pd2: power-domain-cpu2 { #power-domain-cells = <0>; - power-domains = <&cluster_pd>; + power-domains = <&cluster0_pd>; domain-idle-states = <&cluster0_c4>; }; cpu_pd3: power-domain-cpu3 { #power-domain-cells = <0>; - power-domains = <&cluster_pd>; + power-domains = <&cluster0_pd>; domain-idle-states = <&cluster0_c4>; }; cpu_pd4: power-domain-cpu4 { #power-domain-cells = <0>; - power-domains = <&cluster_pd>; + power-domains = <&cluster0_pd>; domain-idle-states = <&cluster0_c4>; }; cpu_pd5: power-domain-cpu5 { #power-domain-cells = <0>; - power-domains = <&cluster_pd>; + power-domains = <&cluster0_pd>; domain-idle-states = <&cluster0_c4>; }; cpu_pd6: power-domain-cpu6 { #power-domain-cells = <0>; - power-domains = <&cluster_pd>; + power-domains = <&cluster1_pd>; domain-idle-states = <&cluster1_c4>; }; cpu_pd7: power-domain-cpu7 { #power-domain-cells = <0>; - power-domains = <&cluster_pd>; + power-domains = <&cluster1_pd>; domain-idle-states = <&cluster1_c4>; }; - cluster_pd: power-domain-cluster { + cluster0_pd: power-domain-cluster0 { + #power-domain-cells = <0>; + domain-idle-states = <&cluster_cl5>; + power-domains = <&system_pd>; + }; + + cluster1_pd: power-domain-cluster1 { #power-domain-cells = <0>; domain-idle-states = <&cluster_cl5>; power-domains = <&system_pd>;