From patchwork Sat Mar 1 20:39:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 869597 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0DE71E9B30 for ; Sat, 1 Mar 2025 20:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740861599; cv=none; b=PCiWcsz0eb8gJG2rTeuXfYQ0rTRuv4eGFrz4IVGeXAniMO3/T9JRyhUO0Qai9BmlGhy3+P9XD+HibI4Xmpk/B0/zytstQHwraIEOj4dMAiorgXPuH7ORj2m9mT73xmeCf7+KbpEZF2UTINVu5l8xgLxnA70EBfIhZLLmScKSU3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740861599; c=relaxed/simple; bh=oiT3XieBMSIfrzEMIa7+tHW3r4Yaol9yvhPjl0hzeR0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PVI6ztu8OQzQphUOyIwcMxcO6TR6giTytnMnbiFhb7Ses710gklG7IOGEN5XRvWPzUBHhnTUrMUeMJBIZWrT6ZaScayrj7178ZKJoN/wMrneKp0an8GpAy061aq2VIITkjzhf19iixVKtbhAB/x+22M4/MC0Xw7Ri9bCXPS/WF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zWIwj8tS; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zWIwj8tS" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-30930b0b420so27193711fa.2 for ; Sat, 01 Mar 2025 12:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740861596; x=1741466396; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lm0hqPFeMjlAJa0zmvxvNTEk2emtnpzkaRSrh6He2DY=; b=zWIwj8tSn2uemlpxRIuCzljgwb+uun95ewpUTqvz+L99gpIP3OeM3Y7kmeJaWdKVYv f2/u7x7KSP/PtJmrM5slNKX1tcPDBJtLvK/EJf0+3vQCRhK1QLEXx/tZwaGcjqCgBqIv JsR5RtDOstoTabilar5n2a8LaVcjzQGr4EfqLA8IBCymhCPpwFKNjJgtkNAn54lkjlGo rQ1hSPCcoW+JOd2t+C394IJt4tSOmVlzCpWsWA8tgfMwcMJaUQa6GYccLcnhsLbWjzYv xjWHOxyDrg5N9clcPkKvx3gPXR5yxquRxJ2UKn6MMNaBcE/dUQfJdLh/mEflUtDFQNiH kFUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740861596; x=1741466396; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lm0hqPFeMjlAJa0zmvxvNTEk2emtnpzkaRSrh6He2DY=; b=aH6iiQcqks37oKFxzRzPrxbCT3FXtWnENjlM5/ql/4jpKWoTdooVe7EZAYwzkTLCuy EXB3TA1nDngWbxOwzzSnvmATrz5IcVkQOe5c9gPCK57sVA0jYHpL37PB7JkKpRsh7UjA p6/VDVxS1gVPrDFwK/M8rVLCHLBXVx8849kOHrMsX3WqCEZDhwbcrvCCMR/jyXsu2Yit iLY9QiVXp4IRTJgc9twovYNWfdE4ZQp7BYWdwDlDgwDP16r6CnJvhSPC061UzM0fYZvu nMwcz8DhY37YrNoZ2ep88nHROxyTrOjfHQ9MiXo2VSgXi3n1ygUUEk19rzonClpocOFw xm5Q== X-Forwarded-Encrypted: i=1; AJvYcCUWtPWBpILPRTIPk/Fdag32Zo/TLZ9oTP8dFzLgmg958iNjP1JXWp8E4vlfhPaAxa2F9hq92Qo+CSDAMByp@vger.kernel.org X-Gm-Message-State: AOJu0Yx+V1SPiOuMc11H3/iwa8TJAgxvR231J/jxuI7SYnCBaUujxcyU q47GqRYhQ5x1tqyCCelxvFR1190BDggG0Gz5IezUbFPb6N6lNGcRdSxijBQThoI= X-Gm-Gg: ASbGncsxozhQCgHNUgLwu6BiSpHmJw35srcWnUB5HmZdS25Cqogauju+7A/vscs+5kG 7OG5fsQ8T+xy6b1dzkK077D6j3XDj4MPX5TSbo8kcgEyBMHwYW2uXQm8SLznZSGzlZt53UDcq/u cHHYGUygPNYvp9hmbXOLzPzicdXe3+v532S500inMjY0PM6C/SK+kmc1lQ0nb6KhVSH08g88pcn 2W7NkWXukbDwRAZQD/UVNH8ly8v6H2LB2vRnb9Imesfo7ZCDBSZPZN6FgfCSLZvtlVlHW2NtwLw MPwg7PsFlqg1zz35kPPFc0cFPaUidcSiic21DRKPW95gN8iA6Agy X-Google-Smtp-Source: AGHT+IEmTXK0sA2OkUpupOigZVSjmXwjzqW3fKRIwNjJwyTslP6vQRr4qY7BVPOJdFvgcDcjK+gOIA== X-Received: by 2002:a2e:b896:0:b0:302:1cdd:73c6 with SMTP id 38308e7fff4ca-30b9326af9bmr30502271fa.20.1740861595853; Sat, 01 Mar 2025 12:39:55 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30b931524efsm6668921fa.60.2025.03.01.12.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Mar 2025 12:39:54 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 01 Mar 2025 22:39:39 +0200 Subject: [PATCH RFC v2 4/7] drm/display: dp-aux-dev: use new DCPD access helpers Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250301-drm-rework-dpcd-access-v2-4-4d92602fc7cd@linaro.org> References: <20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org> In-Reply-To: <20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org> To: Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Jani Nikula Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Jani Nikula X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1430; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=oiT3XieBMSIfrzEMIa7+tHW3r4Yaol9yvhPjl0hzeR0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnw3CQKEcLkja2c5fPc4XKGOP4nL47TK+u5bXfS KNn90N+yo2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ8NwkAAKCRCLPIo+Aiko 1UG6CACk3GBifF0q/szx7lNrtLDJrKctDw1YTztUYefU9Y3YIjzg+oBXe4rU31154ET5jAIQEhc vUr+oWgIA+hJOAmPNkXvYWBYhXOBMfO6jpjerRnGOTA3mArW7GX+cc1EckkIb+hVgai/PVo/g7o OAFQBhPJTA/A67N7ugFi/EqD+Irbp4Ya1yt6VKSkwftQLg5UjPDF4HqBDv9cfM3GFAKi19ageVt xGfPppiBwqlSMyq5AFXeuI49x4SSB1fayq9tjEvss07cQfWjtXK6VR7C5eFGXEmKvkA6REGiCra m1aBW/rjjQ/Km0TKrKP2ALBrLsxGnA9DkvZzmBAH4Bo9IJCq X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_aux_dev.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_aux_dev.c b/drivers/gpu/drm/display/drm_dp_aux_dev.c index 29555b9f03c8c42681c17c4a01e74a966cf8611f..a31ab3f41efb71fd5f936c24ba5c3b8ebea68a5e 100644 --- a/drivers/gpu/drm/display/drm_dp_aux_dev.c +++ b/drivers/gpu/drm/display/drm_dp_aux_dev.c @@ -163,17 +163,16 @@ static ssize_t auxdev_read_iter(struct kiocb *iocb, struct iov_iter *to) break; } - res = drm_dp_dpcd_read(aux_dev->aux, pos, buf, todo); - + res = drm_dp_dpcd_read_data(aux_dev->aux, pos, buf, todo); if (res <= 0) break; - if (copy_to_iter(buf, res, to) != res) { + if (copy_to_iter(buf, todo, to) != todo) { res = -EFAULT; break; } - pos += res; + pos += todo; } if (pos != iocb->ki_pos) @@ -211,12 +210,11 @@ static ssize_t auxdev_write_iter(struct kiocb *iocb, struct iov_iter *from) break; } - res = drm_dp_dpcd_write(aux_dev->aux, pos, buf, todo); - + res = drm_dp_dpcd_write_data(aux_dev->aux, pos, buf, todo); if (res <= 0) break; - pos += res; + pos += todo; } if (pos != iocb->ki_pos)