| Message ID | 20250425-fix-nexus-4-v3-6-da4e39e86d41@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: qcom: fix APQ8064 schema warnings | expand |
Hi Dmitry On 25/04/2025 18:47, Dmitry Baryshkov wrote: > As most other CoreSight devices the replicator can use either of the > optional clocks. Document those optional clocks in the schema. > Additionally document the one-off case of Zynq-7000 platforms which uses > apb_pclk and two additional debug clocks. What is the plan for merging this series ? I am happy to pick this patch via coresight tree. > > Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Otherwise, Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> Suzuki > --- > .../bindings/arm/arm,coresight-static-replicator.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..0c1017affbad2f03892b250ad864d9a5dc8d02f1 100644 > --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > @@ -30,6 +30,19 @@ properties: > power-domains: > maxItems: 1 > > + clocks: > + minItems: 1 > + maxItems: 3 > + > + clock-names: > + oneOf: > + - items: > + - enum: [apb_pclk, atclk] > + - items: # Zynq-700 > + - const: apb_pclk > + - const: dbg_trc > + - const: dbg_apb > + > in-ports: > $ref: /schemas/graph.yaml#/properties/ports > additionalProperties: false >
On Mon, 28 Apr 2025 at 12:06, Suzuki K Poulose <suzuki.poulose@arm.com> wrote: > > Hi Dmitry > > On 25/04/2025 18:47, Dmitry Baryshkov wrote: > > As most other CoreSight devices the replicator can use either of the > > optional clocks. Document those optional clocks in the schema. > > Additionally document the one-off case of Zynq-7000 platforms which uses > > apb_pclk and two additional debug clocks. > > What is the plan for merging this series ? I am happy to pick this patch > via coresight tree. Please pick up coresight-related patch. Each of the maintainers is expected to pick relevant parts. > > > > > Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > Otherwise, > > > Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> > > Suzuki > > > > > --- > > .../bindings/arm/arm,coresight-static-replicator.yaml | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > > index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..0c1017affbad2f03892b250ad864d9a5dc8d02f1 100644 > > --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml > > @@ -30,6 +30,19 @@ properties: > > power-domains: > > maxItems: 1 > > > > + clocks: > > + minItems: 1 > > + maxItems: 3 > > + > > + clock-names: > > + oneOf: > > + - items: > > + - enum: [apb_pclk, atclk] > > + - items: # Zynq-700 > > + - const: apb_pclk > > + - const: dbg_trc > > + - const: dbg_apb > > + > > in-ports: > > $ref: /schemas/graph.yaml#/properties/ports > > additionalProperties: false > > >
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml index a6f793ea03b6c193fc0ff72a45e0249a63a2ba3c..0c1017affbad2f03892b250ad864d9a5dc8d02f1 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml @@ -30,6 +30,19 @@ properties: power-domains: maxItems: 1 + clocks: + minItems: 1 + maxItems: 3 + + clock-names: + oneOf: + - items: + - enum: [apb_pclk, atclk] + - items: # Zynq-700 + - const: apb_pclk + - const: dbg_trc + - const: dbg_apb + in-ports: $ref: /schemas/graph.yaml#/properties/ports additionalProperties: false
As most other CoreSight devices the replicator can use either of the optional clocks. Document those optional clocks in the schema. Additionally document the one-off case of Zynq-7000 platforms which uses apb_pclk and two additional debug clocks. Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema") Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> --- .../bindings/arm/arm,coresight-static-replicator.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)