diff mbox series

[1/3] dt-bindings: media: qcom,x1e80100-camss: Tighten the property regex pattern

Message ID 20250502204142.2064496-2-vladimir.zapolskiy@linaro.org
State New
Headers show
Series dt-bindings: media: qcom,x1e80100-camss: Some minor fixes | expand

Commit Message

Vladimir Zapolskiy May 2, 2025, 8:41 p.m. UTC
There are 4 CSIPHY ports on X1E80100, it'd be preferred to tinker a too
loose the regexp, which covers all these port names.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 .../devicetree/bindings/media/qcom,x1e80100-camss.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski May 6, 2025, 9:01 a.m. UTC | #1
On 02/05/2025 22:41, Vladimir Zapolskiy wrote:
> There are 4 CSIPHY ports on X1E80100, it'd be preferred to tinker a too
> loose the regexp, which covers all these port names.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
>  .../devicetree/bindings/media/qcom,x1e80100-camss.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
kernel test robot May 7, 2025, 9:01 a.m. UTC | #2
Hi Vladimir,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20250502]
[cannot apply to robh/for-next v6.15-rc4 v6.15-rc3 v6.15-rc2 linus/master v6.15-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vladimir-Zapolskiy/dt-bindings-media-qcom-x1e80100-camss-Tighten-the-property-regex-pattern/20250503-044307
base:   next-20250502
patch link:    https://lore.kernel.org/r/20250502204142.2064496-2-vladimir.zapolskiy%40linaro.org
patch subject: [PATCH 1/3] dt-bindings: media: qcom,x1e80100-camss: Tighten the property regex pattern
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250507/202505071636.546zWm4r-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250507/202505071636.546zWm4r-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505071636.546zWm4r-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/scsi/qedf/qedf_main.c:702:9: warning: braces around scalar initializer
     702 |         {
         |         ^
   drivers/scsi/qedf/qedf_main.c:702:9: note: (near initialization for 'qedf_cb_ops.get_login_failures')
>> drivers/scsi/qedf/qedf_main.c:703:17: error: field name not in record or union initializer
     703 |                 .link_update = qedf_link_update,
         |                 ^
   drivers/scsi/qedf/qedf_main.c:703:17: note: (near initialization for 'qedf_cb_ops.get_login_failures')
>> drivers/scsi/qedf/qedf_main.c:703:32: error: initialization of 'u32 (*)(void *)' {aka 'unsigned int (*)(void *)'} from incompatible pointer type 'void (*)(void *, struct qed_link_output *)' [-Werror=incompatible-pointer-types]
     703 |                 .link_update = qedf_link_update,
         |                                ^~~~~~~~~~~~~~~~
   drivers/scsi/qedf/qedf_main.c:703:32: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:704:17: error: field name not in record or union initializer
     704 |                 .bw_update = qedf_bw_update,
         |                 ^
   drivers/scsi/qedf/qedf_main.c:704:17: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:704:30: warning: excess elements in scalar initializer
     704 |                 .bw_update = qedf_bw_update,
         |                              ^~~~~~~~~~~~~~
   drivers/scsi/qedf/qedf_main.c:704:30: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:705:17: error: field name not in record or union initializer
     705 |                 .schedule_recovery_handler = qedf_schedule_recovery_handler,
         |                 ^
   drivers/scsi/qedf/qedf_main.c:705:17: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:705:46: warning: excess elements in scalar initializer
     705 |                 .schedule_recovery_handler = qedf_schedule_recovery_handler,
         |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/qedf/qedf_main.c:705:46: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:706:17: error: field name not in record or union initializer
     706 |                 .dcbx_aen = qedf_dcbx_handler,
         |                 ^
   drivers/scsi/qedf/qedf_main.c:706:17: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:706:29: warning: excess elements in scalar initializer
     706 |                 .dcbx_aen = qedf_dcbx_handler,
         |                             ^~~~~~~~~~~~~~~~~
   drivers/scsi/qedf/qedf_main.c:706:29: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:707:17: error: field name not in record or union initializer
     707 |                 .get_generic_tlv_data = qedf_get_generic_tlv_data,
         |                 ^
   drivers/scsi/qedf/qedf_main.c:707:17: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:707:41: warning: excess elements in scalar initializer
     707 |                 .get_generic_tlv_data = qedf_get_generic_tlv_data,
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/qedf/qedf_main.c:707:41: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:708:17: error: field name not in record or union initializer
     708 |                 .get_protocol_tlv_data = qedf_get_protocol_tlv_data,
         |                 ^
   drivers/scsi/qedf/qedf_main.c:708:17: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:708:42: warning: excess elements in scalar initializer
     708 |                 .get_protocol_tlv_data = qedf_get_protocol_tlv_data,
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/qedf/qedf_main.c:708:42: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:709:17: error: field name not in record or union initializer
     709 |                 .schedule_hw_err_handler = qedf_schedule_hw_err_handler,
         |                 ^
   drivers/scsi/qedf/qedf_main.c:709:17: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:709:44: warning: excess elements in scalar initializer
     709 |                 .schedule_hw_err_handler = qedf_schedule_hw_err_handler,
         |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/qedf/qedf_main.c:709:44: note: (near initialization for 'qedf_cb_ops.get_login_failures')
   drivers/scsi/qedf/qedf_main.c:702:9: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     702 |         {
         |         ^
   drivers/scsi/qedf/qedf_main.c:702:9: note: (near initialization for 'qedf_cb_ops')
   cc1: some warnings being treated as errors
--
   drivers/net/ethernet/qlogic/qede/qede_main.c:206:9: warning: braces around scalar initializer
     206 |         {
         |         ^
   drivers/net/ethernet/qlogic/qede/qede_main.c:206:9: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:208:17: error: field name not in record or union initializer
     208 |                 .arfs_filter_op = qede_arfs_filter_op,
         |                 ^
   drivers/net/ethernet/qlogic/qede/qede_main.c:208:17: note: (near initialization for 'qede_ll_ops.force_mac')
>> drivers/net/ethernet/qlogic/qede/qede_main.c:208:35: error: initialization of 'void (*)(void *, u8 *, bool)' {aka 'void (*)(void *, unsigned char *, _Bool)'} from incompatible pointer type 'void (*)(void *, void *, u8)' {aka 'void (*)(void *, void *, unsigned char)'} [-Werror=incompatible-pointer-types]
     208 |                 .arfs_filter_op = qede_arfs_filter_op,
         |                                   ^~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/qlogic/qede/qede_main.c:208:35: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:210:17: error: field name not in record or union initializer
     210 |                 .link_update = qede_link_update,
         |                 ^
   drivers/net/ethernet/qlogic/qede/qede_main.c:210:17: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:210:32: warning: excess elements in scalar initializer
     210 |                 .link_update = qede_link_update,
         |                                ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/qlogic/qede/qede_main.c:210:32: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:211:17: error: field name not in record or union initializer
     211 |                 .schedule_recovery_handler = qede_schedule_recovery_handler,
         |                 ^
   drivers/net/ethernet/qlogic/qede/qede_main.c:211:17: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:211:46: warning: excess elements in scalar initializer
     211 |                 .schedule_recovery_handler = qede_schedule_recovery_handler,
         |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/qlogic/qede/qede_main.c:211:46: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:212:17: error: field name not in record or union initializer
     212 |                 .schedule_hw_err_handler = qede_schedule_hw_err_handler,
         |                 ^
   drivers/net/ethernet/qlogic/qede/qede_main.c:212:17: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:212:44: warning: excess elements in scalar initializer
     212 |                 .schedule_hw_err_handler = qede_schedule_hw_err_handler,
         |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/qlogic/qede/qede_main.c:212:44: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:213:17: error: field name not in record or union initializer
     213 |                 .get_generic_tlv_data = qede_get_generic_tlv_data,
         |                 ^
   drivers/net/ethernet/qlogic/qede/qede_main.c:213:17: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:213:41: warning: excess elements in scalar initializer
     213 |                 .get_generic_tlv_data = qede_get_generic_tlv_data,
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/qlogic/qede/qede_main.c:213:41: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:214:17: error: field name not in record or union initializer
     214 |                 .get_protocol_tlv_data = qede_get_eth_tlv_data,
         |                 ^
   drivers/net/ethernet/qlogic/qede/qede_main.c:214:17: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:214:42: warning: excess elements in scalar initializer
     214 |                 .get_protocol_tlv_data = qede_get_eth_tlv_data,
         |                                          ^~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/qlogic/qede/qede_main.c:214:42: note: (near initialization for 'qede_ll_ops.force_mac')
   drivers/net/ethernet/qlogic/qede/qede_main.c:206:9: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
     206 |         {
         |         ^
   drivers/net/ethernet/qlogic/qede/qede_main.c:206:9: note: (near initialization for 'qede_ll_ops')
   drivers/net/ethernet/qlogic/qede/qede_main.c:216:22: warning: initialized field overwritten [-Woverride-init]
     216 |         .force_mac = qede_force_mac,
         |                      ^~~~~~~~~~~~~~
   drivers/net/ethernet/qlogic/qede/qede_main.c:216:22: note: (near initialization for 'qede_ll_ops.force_mac')
   cc1: some warnings being treated as errors


vim +703 drivers/scsi/qedf/qedf_main.c

61d8658b4a435e Dupuis, Chad   2017-02-15  700  
61d8658b4a435e Dupuis, Chad   2017-02-15  701  static struct qed_fcoe_cb_ops qedf_cb_ops = {
61d8658b4a435e Dupuis, Chad   2017-02-15  702  	{
61d8658b4a435e Dupuis, Chad   2017-02-15 @703  		.link_update = qedf_link_update,
6e7c8eea929e54 Saurav Kashyap 2020-04-16  704  		.bw_update = qedf_bw_update,
f6b172f21999cf Chad Dupuis    2020-04-16  705  		.schedule_recovery_handler = qedf_schedule_recovery_handler,
61d8658b4a435e Dupuis, Chad   2017-02-15  706  		.dcbx_aen = qedf_dcbx_handler,
8673daf4f55bf3 Chad Dupuis    2018-05-22  707  		.get_generic_tlv_data = qedf_get_generic_tlv_data,
642a0b37e66946 Chad Dupuis    2018-05-22  708  		.get_protocol_tlv_data = qedf_get_protocol_tlv_data,
55e049910e08ca Saurav Kashyap 2020-09-07  709  		.schedule_hw_err_handler = qedf_schedule_hw_err_handler,
61d8658b4a435e Dupuis, Chad   2017-02-15  710  	}
61d8658b4a435e Dupuis, Chad   2017-02-15  711  };
61d8658b4a435e Dupuis, Chad   2017-02-15  712
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
index 113565cf2a99..680f3f514132 100644
--- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
@@ -133,7 +133,7 @@  properties:
       CSI input ports.
 
     patternProperties:
-      "^port@[0-3]+$":
+      "^port@[0-3]$":
         $ref: /schemas/graph.yaml#/$defs/port-base
         unevaluatedProperties: false