| Message ID | 20250507031019.4080541-2-quic_ziyuzhan@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | pci: qcom: Add QCS8300 PCIe support | expand |
On Wed, May 07, 2025 at 11:10:14AM GMT, Ziyue Zhang wrote: > qcs8300 pcie1 phy use the same clocks as sa8775p, in the review comments > of qcs8300 patches, gcc aux clock should be removed and replace it with > phy_aux clock.So move "qcom,sa8775p-qmp-gen4x4-pcie-phy" compatible from > 7 clocks' list to 6 clocks' list to solve the dtb check error. > > qcs8300 pcie phy only use 6 clocks, so move qcs8300 gen4x2 pcie phy > compatible from 7 clocks' list to 6 clocks' list. I don't understand any of this. You just submitted the bindings not so far ago. Does this mean they were never tested? What does it mean that gcc aux clock should be removed in the review comments? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml index 2c6c9296e4c0..a11a7e78636d 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml @@ -176,6 +176,8 @@ allOf: contains: enum: - qcom,qcs615-qmp-gen3x1-pcie-phy + - qcom,qcs8300-qmp-gen4x2-pcie-phy + - qcom,sa8775p-qmp-gen4x4-pcie-phy - qcom,sc8280xp-qmp-gen3x1-pcie-phy - qcom,sc8280xp-qmp-gen3x2-pcie-phy - qcom,sc8280xp-qmp-gen3x4-pcie-phy @@ -196,9 +198,7 @@ allOf: compatible: contains: enum: - - qcom,qcs8300-qmp-gen4x2-pcie-phy - qcom,sa8775p-qmp-gen4x2-pcie-phy - - qcom,sa8775p-qmp-gen4x4-pcie-phy then: properties: clocks:
qcs8300 pcie1 phy use the same clocks as sa8775p, in the review comments of qcs8300 patches, gcc aux clock should be removed and replace it with phy_aux clock.So move "qcom,sa8775p-qmp-gen4x4-pcie-phy" compatible from 7 clocks' list to 6 clocks' list to solve the dtb check error. qcs8300 pcie phy only use 6 clocks, so move qcs8300 gen4x2 pcie phy compatible from 7 clocks' list to 6 clocks' list. Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com> --- .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)