From patchwork Fri May 9 08:38:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dikshita Agarwal X-Patchwork-Id: 888840 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0800B27A478; Fri, 9 May 2025 08:39:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746779991; cv=none; b=inWtrAvzKAmUlwdDrcU8nBpSGOcc+iE3bJEg9Ot8pohdh8rhW6EHdS9sEE9DkaKLGtX4nGfUnAWwUtX/SIO2OwCkqHwaJmjnR7QlLnst1fyo1eSM3YkP+q0aJCh66f9ny/H5G8QTXspNROrOVwVmFujG/s35KWjBrSX8xlLISJc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746779991; c=relaxed/simple; bh=cxi10bo3btxihK2zbOtisLWdH0bGPWMs9E1ml3Psu2k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=iBscscYAiBshvnzePS1Vxz0jUIl2kHtgtVz/X9RasmkTePe5XB9nKdKIKhMjcOP8cVYORDa06qu5OUM8YVGRhr+qHE91SndeR0h5XYqD/6p5NS6jTNsgO7qokW5skeM85ZZVX2EdgHkPu8rhfthZHI5aTnOZK+R8782gSEzlbGo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=nXLtDLwp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="nXLtDLwp" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5493CCZL002149; Fri, 9 May 2025 08:39:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kgKXb/wevRePuoFnpW+rns4trD7cirDzG0VuSG7VzvU=; b=nXLtDLwpDfsIKL2e 2UP5wnjLwaMnMVSdULtrA8PA8WbUmqJjJGlA7RjcSkTvTFiRAHYpX3V2Y2lHV+SJ sCc1bLNoV94QjLjsnEIrGRG1+cmX66PK2JnpXNRtr2WuZs6MLho2BFdyYs42garS pyt47KwaKYqitj+d0GI/sc7UqQgyo+cr6DMG/jXFKM28O9KzUmgmB4N3Qk3uYtpO BVVm3zlDk2K0wqGDIPloW4NsgmvrjUJ0f3y3xIdhVHPpX/de5zlkD9qPvFlL49Ot woI0vIwA0yB4ug4ITYH5DcwOektBKLpxJ2z3zTW2utrqAbX4c33mayP3XIk8oi3N /79stA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46gnp5bxb4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 May 2025 08:39:46 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 5498di08031392 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 9 May 2025 08:39:44 GMT Received: from hu-dikshita-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 9 May 2025 01:39:40 -0700 From: Dikshita Agarwal Date: Fri, 9 May 2025 14:08:55 +0530 Subject: [PATCH v5 09/26] media: iris: Fix missing function pointer initialization Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20250509-video-iris-hevc-vp9-v5-9-59b4ff7d331c@quicinc.com> References: <20250509-video-iris-hevc-vp9-v5-0-59b4ff7d331c@quicinc.com> In-Reply-To: <20250509-video-iris-hevc-vp9-v5-0-59b4ff7d331c@quicinc.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Stefan Schmidt , Hans Verkuil CC: , , , Dmitry Baryshkov , Neil Armstrong , Nicolas Dufresne , Dan Carpenter , Dikshita Agarwal , X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746779937; l=1703; i=quic_dikshita@quicinc.com; s=20240917; h=from:subject:message-id; bh=cxi10bo3btxihK2zbOtisLWdH0bGPWMs9E1ml3Psu2k=; b=5EFSBYOc23koKlrsOecmhWbepAQ6RhAkALF2YafuaQAT1qG6ivF1twvAO75brvCRyf++P7R0P z9591rfmQQFApYmcL8xAQicw/h8RClyaGIGWj5AunG2/CvfPWnhxMN2 X-Developer-Key: i=quic_dikshita@quicinc.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=XL0wSRhE c=1 sm=1 tr=0 ts=681dbf52 cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=KKAkSRfTAAAA:8 a=KBDEKiRkX8NPVKSMWrcA:9 a=QEXdDO2ut3YA:10 a=TjNXssC_j7lpFel5tvFf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: KDtrj_hXuirJJ0CY1R6f0_dRn7Q9dzBC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA5MDA4MyBTYWx0ZWRfX0ym5PpDRoZ+7 0WW8L3xzXA+6kA6y4SQyBN23qASCIMvvNUq+mw+NiYRf+GGTBEpMF6nVuGxwZQWvFwGF4fOAYl3 miUZRyQh+zQXW09Rg9eCBuEuQ9c3sGKNOZDpZYus0PCeSPxmaf+vtrzgMKqQzG5pBaqhKhnXLHK TPlJ2doAC8LIWEs0IoQE1hEIvsuVFXyAzpByDqqCjZWaljG3nG9dGA6eL2v3Kiig5aWYqMxsZCy Si3jgCtg90X8W9B6K8sJL87QpfYLd8TBoWCaEQ154TP2OGuGHaz6la03Mb0ppRUy8pd0vWQMMzR wVwANg/lrxM7Y3zUCn1pk3l3EOYk0VMnQPs39hs1jTNW9kMoBf4uZPpmlCb2OUBVEdiEyX4502t O6snM2YCssOv80PNaD8/FPd0Jrg2qCkvcwub4ikRJ0O2vQhfmf5+EHmu2D2CcO8eHzvKpBUs X-Proofpoint-ORIG-GUID: KDtrj_hXuirJJ0CY1R6f0_dRn7Q9dzBC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-09_03,2025-05-08_04,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505090083 The function pointers responsible for setting firmware properties were never initialized in the instance capability structure, causing it to remain NULL. As a result, the firmware properties were not being set correctly. Fix this by properly assigning the function pointers from the core capability to the instance capability, ensuring that the properties are correctly applied to the firmware. Cc: stable@vger.kernel.org Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon") Acked-by: Vikash Garodia Reviewed-by: Bryan O'Donoghue Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8550-HDK Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_ctrls.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 915de101fcba47bf1d1d9019cc5e704b87e2b9bb..13f5cf0d0e8a445aa68fa87a3569bd99ac23a32a 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -157,6 +157,7 @@ void iris_session_init_caps(struct iris_core *core) core->inst_fw_caps[cap_id].value = caps[i].value; core->inst_fw_caps[cap_id].flags = caps[i].flags; core->inst_fw_caps[cap_id].hfi_id = caps[i].hfi_id; + core->inst_fw_caps[cap_id].set = caps[i].set; } }