| Message ID | 20250620040736.3032667-2-quic_wenmliu@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add current load setting for qcom camss csiphy | expand |
On 20/06/2025 06:07, Wenmeng Liu wrote: > Add regulator current load support for vdda-phy vdda-pll. > > Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com> > --- > .../devicetree/bindings/media/qcom,sc7280-camss.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > This patch fails on so many levels... do internal reviews first. Use existing properties, see regulators. If not, use existing unit suffixes. Otherwise it is just another downstream property you send us, to which we responded many times - don't. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Read meeting notes from internal discussions where you discussed this already. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml index ee35e3bc97ff..a1ae4701d178 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml @@ -131,6 +131,12 @@ properties: description: Phandle to 1.8V regulator supply to PHY refclk pll block. + regulator-load-current: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: | + Specifies the load current (in microamperes) for the regulators used by the device. + The first value corresponds to vdda-phy, and the second to vdda-pll. + ports: $ref: /schemas/graph.yaml#/properties/ports
Add regulator current load support for vdda-phy vdda-pll. Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com> --- .../devicetree/bindings/media/qcom,sc7280-camss.yaml | 6 ++++++ 1 file changed, 6 insertions(+)