From patchwork Fri Jun 20 15:45:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 898422 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386DE2EAB67 for ; Fri, 20 Jun 2025 15:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750434350; cv=none; b=pED9jzLTDVGl6X8+p65YTTR3Cl2kmxPaDwfvFaHaIH0vJJrtAfL2+ULc3YAEgXZDXGnK+toJe5fY9Hf03IjSJUS26uP8/1Lo5JFz980ZTvBTMK5dhJ/R0aUTqgak8te8PCio5LGEqonCHVofFHLBYoSRHKW+W3gC1f11t5CqwyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750434350; c=relaxed/simple; bh=nXgUqQdyDTDmUCSlus96vQ7zp/8O8nNWvr6C6TQ8+ag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ezFYa7F8XSYvOliOSf5/J4e1pXYN6S7UAy1cblfRiL7RzGbBR1Upr7XYlSU49GlWB454PNGT5ZjytugyrxwVFJXc3sqZvQKNMvkDO77sKVhgCsjpA1bUAps/uFwmnM54S7sPaDOH4Cmn6xnY9ve1eZS5k8aSMPNgo1R7xasaUU4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fBdG1v4O; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fBdG1v4O" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55KDHdXf017879 for ; Fri, 20 Jun 2025 15:45:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=C2Mw8hDedlh HIu8wE01JvXGicmu3xM3Nu6IiIJHmMkU=; b=fBdG1v4OHwDOATjWpu/VacCWiaE KMa/eig7Meb6q+zYF5fn4ALlF7D7vCgah2Pzdw9mk21oLl/RJXvd1bArRnao224E 7QsXk62dWFUEDU0HWZb3KfVxH4UHvQIETWDnGamP5hbffECt93++APkU8/j0+nEl 9PGhnbFs8hjfmhDbHPwuQuSYjqaDiER/VovIZKevpDIDekCOV4xKt7HJzHn7U/OE kmx/HT/WnOuSD30vtekl41h1edn0m9JU0JS+OwmF75FuRIFrAzuFt2FHst7SFaJZ tOtj+JCzNvHijNFRw97Xn2t+aItkUtuzLOLisgZvNsfjyIWo9kDSlp72S3g== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47d0pchs7b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 20 Jun 2025 15:45:48 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-23689228a7fso30058025ad.1 for ; Fri, 20 Jun 2025 08:45:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750434347; x=1751039147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C2Mw8hDedlhHIu8wE01JvXGicmu3xM3Nu6IiIJHmMkU=; b=b9wEjeGiU7m7bXL2rawUBmHmS5psUYEaFG9o39tadaYJuG6CKPl9dBrl90n7JTd42u FR19tGKiK+qHfLvVXgMYL7LZ+kV5pZms6QbcG4g0GMfAKEqGxjuvFMBjwCoypIVWYlKl Q18xphKyrB+mygRzHDLyFa8juOR8feXCAlYA2xOqJIXpXWtlWOmli5ROPLJZuHW2HHy1 MoPoBj+fvEIcAhuLIJ8nFIDcgqWdrXhBhFj+E8W4gf1tQkvbS9vDMTc5752gec9n+2yw MMEc10M/t+L3hN/6EXVGt86OVFrSiznJxXNAtg8mqgnxbxcXjIbTuXCz1du1xKLEYQ+g 7xhg== X-Gm-Message-State: AOJu0YzqiyV3j/BlRM/EymOgSPitGv7Uc/lTrAOriVTf+o2gNf0zoGNi EFZXjW3dEYnLLF+ciL6lDYwnMWuKPLdbWlpC1Tv5EMQ20MTRRai9yAi4t3cVjleJgavE4OGGvFR gdlVbAbl2Je4YY0SMQS9O0AI379FJqqQkW1a6iSo2zseW42/ekf0MjV/i5kCdsO3Zl7vS X-Gm-Gg: ASbGnctELnMRTZhnEnhRGoD4GkerpLT23FpiM5t8dlHXdRoxgkN9TNzIjyOGPH6sEXm h/EhZdTKEAtVNZRKaiZB+9OW+s9mcEAXS5AAYY9UwceUinigccEfwHCF4LEl6S0upKtcIk+qT8Q 3gSIuKWrtfYH0K9T7LzQcjBImRtSDhTm/2soTQiwbGNGNNp09V57XVUqA7uHih6uNJ/4dPRJPM1 nDKEV+yMPMa6bDE7mCIo/WrdE2285v9ZZE9pwQMu9p14X/jasH2b4jLQcfd+qqtkAD8gfqfonyN 7pb2qsLpkmBLH1zsiZUdl57wlmPBd1r2 X-Received: by 2002:a17:902:f70d:b0:234:e3b7:5ce0 with SMTP id d9443c01a7336-237d99d83f3mr42383345ad.47.1750434347250; Fri, 20 Jun 2025 08:45:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDiFB/XTk6onD/OV+d4aZvXfxm168CHsEY2UxE+rWdnNuvA7GDtDI7V0CiMaCnXa9H6JV/nw== X-Received: by 2002:a17:902:f70d:b0:234:e3b7:5ce0 with SMTP id d9443c01a7336-237d99d83f3mr42383045ad.47.1750434346876; Fri, 20 Jun 2025 08:45:46 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d875c1f7sm20922405ad.257.2025.06.20.08.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 08:45:46 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Danilo Krummrich , Rob Clark , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 1/2] drm/gpuvm: Fix doc comments Date: Fri, 20 Jun 2025 08:45:35 -0700 Message-ID: <20250620154537.89514-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620154537.89514-1-robin.clark@oss.qualcomm.com> References: <20250620154537.89514-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: RkxZhg3Uus_zGS9VS9DooUb1O_1j57ph X-Authority-Analysis: v=2.4 cv=YKyfyQGx c=1 sm=1 tr=0 ts=6855822c cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=5Yek0j1-lJT91Je3aSMA:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: RkxZhg3Uus_zGS9VS9DooUb1O_1j57ph X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjIwMDExMiBTYWx0ZWRfX2UGxlMMA446h Jq1DbHebZ7YdWiZPopfCm17qK9v8TlKYs+NBkwE35EPHztmaSone2wzq8vQwMHySZP1swAOYfGq zr3s8qFSjJm/mCkLqxmFBr0ekmAwvNnZ9QCeexu+cy93IPpcEPac9RtqEK+wSIkUW8T5sNPlG2T IN/KOU+JMRqmTHitjZ/NYZbTkaGw4jriwDyuxo/0QHBPltaov9hTMVYEstC4Yyoja/8084fnGl1 T1OwbGEAvHm9nLJt+bVGiUZ4Fq0LJlmvlRGBy7p3qHNrRn83f8YfcXKW1lPigVsVhIOScM4iP2M pVN7+O8zZFjxStOyhamjdraGMALkC+aTw+Tb/J8vwfaLBrf7vtmZjE7DMyUszYsX1fMx67h3pxN e5H0l8jpbCHUZeeySC5A1qg8+MJv6JfRIfI1ScPDqMjoJFiOFsof1SZuFGzmPm1rNPcuCGAY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-20_06,2025-06-20_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506200112 Correctly summerize drm_gpuvm_sm_map/unmap, and fix the parameter order and names. Just something I noticed in passing. v2: Don't rename the arg names in prototypes to match function declarations [Danilo] Signed-off-by: Rob Clark Acked-by: Danilo Krummrich --- drivers/gpu/drm/drm_gpuvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c index f9eb56f24bef..0ca717130541 100644 --- a/drivers/gpu/drm/drm_gpuvm.c +++ b/drivers/gpu/drm/drm_gpuvm.c @@ -2299,13 +2299,13 @@ __drm_gpuvm_sm_unmap(struct drm_gpuvm *gpuvm, } /** - * drm_gpuvm_sm_map() - creates the &drm_gpuva_op split/merge steps + * drm_gpuvm_sm_map() - calls the &drm_gpuva_op split/merge steps * @gpuvm: the &drm_gpuvm representing the GPU VA space + * @priv: pointer to a driver private data structure * @req_addr: the start address of the new mapping * @req_range: the range of the new mapping * @req_obj: the &drm_gem_object to map * @req_offset: the offset within the &drm_gem_object - * @priv: pointer to a driver private data structure * * This function iterates the given range of the GPU VA space. It utilizes the * &drm_gpuvm_ops to call back into the driver providing the split and merge @@ -2349,7 +2349,7 @@ drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm, void *priv, EXPORT_SYMBOL_GPL(drm_gpuvm_sm_map); /** - * drm_gpuvm_sm_unmap() - creates the &drm_gpuva_ops to split on unmap + * drm_gpuvm_sm_unmap() - calls the &drm_gpuva_ops to split on unmap * @gpuvm: the &drm_gpuvm representing the GPU VA space * @priv: pointer to a driver private data structure * @req_addr: the start address of the range to unmap